mirror of
https://github.com/azaion/admin.git
synced 2026-04-22 22:06:33 +00:00
Sync .cursor from suite (autodev orchestrator + monorepo skills)
This commit is contained in:
@@ -0,0 +1,133 @@
|
||||
# API Contract Template
|
||||
|
||||
A contract is the **frozen, reviewed interface** between two or more components. When task A produces a shared model, DTO, schema, event payload, or public API, and task B consumes it, they must not reverse-engineer each other's implementation — they must read the contract.
|
||||
|
||||
Save the filled contract at `_docs/02_document/contracts/<component>/<name>.md`. Reference it from the producing task's `## Contract` section and from every consuming task's `## Dependencies` section.
|
||||
|
||||
---
|
||||
|
||||
```markdown
|
||||
# Contract: [contract-name]
|
||||
|
||||
**Component**: [component-name]
|
||||
**Producer task**: [TRACKER-ID] — [task filename]
|
||||
**Consumer tasks**: [list of TRACKER-IDs or "TBD at decompose time"]
|
||||
**Version**: 1.0.0
|
||||
**Status**: [draft | frozen | deprecated]
|
||||
**Last Updated**: [YYYY-MM-DD]
|
||||
|
||||
## Purpose
|
||||
|
||||
Short statement of what this contract represents and why it is shared (1–3 sentences).
|
||||
|
||||
## Shape
|
||||
|
||||
Choose ONE of the following shape forms per the contract type:
|
||||
|
||||
### For data models (DTO / schema / event)
|
||||
|
||||
```[language]
|
||||
// language-native type definitions — e.g., Python dataclass, C# record, TypeScript interface, Rust struct, JSON Schema
|
||||
```
|
||||
|
||||
For each field:
|
||||
|
||||
| Field | Type | Required | Description | Constraints |
|
||||
|-------|------|----------|-------------|-------------|
|
||||
| `id` | `string` (UUID) | yes | Unique identifier | RFC 4122 v4 |
|
||||
| `created_at` | `datetime` (ISO 8601 UTC) | yes | Creation timestamp | |
|
||||
| `...` | ... | ... | ... | ... |
|
||||
|
||||
### For function / method APIs
|
||||
|
||||
| Name | Signature | Throws / Errors | Blocking? |
|
||||
|------|-----------|-----------------|-----------|
|
||||
| `do_x` | `(input: InputDto) -> Result<OutputDto, XError>` | `XError::NotFound`, `XError::Invalid` | sync |
|
||||
| ... | ... | ... | ... |
|
||||
|
||||
### For HTTP / RPC endpoints
|
||||
|
||||
| Method | Path | Request body | Response | Status codes |
|
||||
|--------|------|--------------|----------|--------------|
|
||||
| `POST` | `/api/v1/resource` | `CreateResource` | `Resource` | 201, 400, 409 |
|
||||
| ... | ... | ... | ... | ... |
|
||||
|
||||
## Invariants
|
||||
|
||||
Properties that MUST hold for every valid instance or every allowed interaction. These survive refactors.
|
||||
|
||||
- Invariant 1: [statement]
|
||||
- Invariant 2: [statement]
|
||||
|
||||
## Non-Goals
|
||||
|
||||
Things this contract intentionally does NOT cover. Helps prevent scope creep.
|
||||
|
||||
- Not covered: [statement]
|
||||
|
||||
## Versioning Rules
|
||||
|
||||
- **Breaking changes** (field renamed/removed, type changed, required→optional flipped) require a new major version and a deprecation path for consumers.
|
||||
- **Non-breaking additions** (new optional field, new error variant consumers already tolerate) require a minor version bump.
|
||||
|
||||
## Test Cases
|
||||
|
||||
Representative cases that both producer and consumer tests must cover. Keep short — this is the contract test surface, not an exhaustive suite.
|
||||
|
||||
| Case | Input | Expected | Notes |
|
||||
|------|-------|----------|-------|
|
||||
| valid-minimal | minimal valid instance | accepted | |
|
||||
| invalid-missing-required | missing `id` | rejected with specific error | |
|
||||
| edge-case-x | ... | ... | |
|
||||
|
||||
## Change Log
|
||||
|
||||
| Version | Date | Change | Author |
|
||||
|---------|------|--------|--------|
|
||||
| 1.0.0 | YYYY-MM-DD | Initial contract | [agent/user] |
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Decompose-skill rules for emitting contracts
|
||||
|
||||
A task is a **shared-models / shared-API task** when ANY of the following is true:
|
||||
|
||||
- The component spec lists it as a shared component (under `shared/*` in `module-layout.md`).
|
||||
- The task's **Scope.Included** mentions any of: "public interface", "DTO", "schema", "event", "contract", "API endpoint", "shared model".
|
||||
- The task is parented to a cross-cutting epic (`epic_type: cross-cutting`).
|
||||
- The task is depended on by ≥2 other tasks across different components.
|
||||
|
||||
For every shared-models / shared-API task:
|
||||
|
||||
1. Create a contract file at `_docs/02_document/contracts/<component>/<name>.md` using this template.
|
||||
2. Fill in Shape, Invariants, Non-Goals, Versioning Rules, and at least 3 Test Cases.
|
||||
3. Add a mandatory `## Contract` section to the task spec that links to the contract file:
|
||||
|
||||
```markdown
|
||||
## Contract
|
||||
|
||||
This task produces/implements the contract at `_docs/02_document/contracts/<component>/<name>.md`.
|
||||
Consumers MUST read that file — not this task spec — to discover the interface.
|
||||
```
|
||||
|
||||
4. For every consuming task, add the contract path to its `## Dependencies` section as a document dependency (not a task dependency):
|
||||
|
||||
```markdown
|
||||
### Document Dependencies
|
||||
- `_docs/02_document/contracts/<component>/<name>.md` — API contract produced by [TRACKER-ID].
|
||||
```
|
||||
|
||||
5. If the contract changes after it was frozen, the producer task must bump the `Version` and note the change in `Change Log`. Consumers referenced in the contract header must be notified (surface to user via Choose format).
|
||||
|
||||
## Code-review-skill rules for verifying contracts
|
||||
|
||||
Phase 2 (Spec Compliance) adds a check:
|
||||
|
||||
- For every task with a `## Contract` section:
|
||||
- Verify the referenced contract file exists at the stated path.
|
||||
- Verify the implementation's public signatures (types, method shapes, endpoint paths) match the contract's Shape section.
|
||||
- If they diverge, emit a `Spec-Gap` finding with High severity.
|
||||
- For every consuming task's Document Dependencies that reference a contract:
|
||||
- Verify the consumer's imports / calls match the contract's Shape.
|
||||
- If they diverge, emit a `Spec-Gap` finding with High severity and a hint that either the contract or the consumer is drifting.
|
||||
@@ -0,0 +1,107 @@
|
||||
# Module Layout Template
|
||||
|
||||
The module layout is the **authoritative file-ownership map** used by the `/implement` skill to assign OWNED / READ-ONLY / FORBIDDEN files to implementer subagents. It is derived from `_docs/02_document/architecture.md` and the component specs at `_docs/02_document/components/`, and it follows the target language's standard project-layout conventions.
|
||||
|
||||
Save as `_docs/02_document/module-layout.md`. This file is produced by the decompose skill (Step 1.5 module layout) and consumed by the implement skill (Step 4 file ownership). Task specs remain purely behavioral — they do NOT carry file paths. The layout is the single place where component → filesystem mapping lives.
|
||||
|
||||
---
|
||||
|
||||
```markdown
|
||||
# Module Layout
|
||||
|
||||
**Language**: [python | csharp | rust | typescript | go | mixed]
|
||||
**Layout Convention**: [src-layout | crates-workspace | packages-workspace | custom]
|
||||
**Root**: [src/ | crates/ | packages/ | ./]
|
||||
**Last Updated**: [YYYY-MM-DD]
|
||||
|
||||
## Layout Rules
|
||||
|
||||
1. Each component owns ONE top-level directory under the root.
|
||||
2. Shared code lives under `<root>/shared/` (or language equivalent: `src/shared/`, `crates/shared/`, `packages/shared/`).
|
||||
3. Cross-cutting concerns (logging, config, error handling, telemetry) live under `<root>/shared/<concern>/`.
|
||||
4. Public API surface per component = files listed in `public:` below. Everything else is internal — other components MUST NOT import it directly.
|
||||
5. Tests live outside the component tree in a separate `tests/` or `<component>/tests/` directory per the language's test convention.
|
||||
|
||||
## Per-Component Mapping
|
||||
|
||||
### Component: [component-name]
|
||||
|
||||
- **Epic**: [TRACKER-ID]
|
||||
- **Directory**: `src/<path>/`
|
||||
- **Public API**: files in this list are importable by other components
|
||||
- `src/<path>/public_api.py` (or `mod.rs`, `index.ts`, `PublicApi.cs`, etc.)
|
||||
- `src/<path>/types.py`
|
||||
- **Internal (do NOT import from other components)**:
|
||||
- `src/<path>/internal/*`
|
||||
- `src/<path>/_helpers.py`
|
||||
- **Owns (exclusive write during implementation)**: `src/<path>/**`
|
||||
- **Imports from**: [list of other components whose Public API this component may use]
|
||||
- **Consumed by**: [list of components that depend on this component's Public API]
|
||||
|
||||
### Component: [next-component]
|
||||
...
|
||||
|
||||
## Shared / Cross-Cutting
|
||||
|
||||
### shared/models
|
||||
- **Directory**: `src/shared/models/`
|
||||
- **Purpose**: DTOs, value types, schemas shared across components
|
||||
- **Owned by**: whoever implements task `[TRACKER-ID]_shared_models`
|
||||
- **Consumed by**: all components
|
||||
|
||||
### shared/logging
|
||||
- **Directory**: `src/shared/logging/`
|
||||
- **Purpose**: structured logging setup
|
||||
- **Owned by**: cross-cutting task `[TRACKER-ID]_logging`
|
||||
- **Consumed by**: all components
|
||||
|
||||
### shared/[other concern]
|
||||
...
|
||||
|
||||
## Allowed Dependencies (layering)
|
||||
|
||||
Read top-to-bottom; an upper layer may import from a lower layer but NEVER the reverse.
|
||||
|
||||
| Layer | Components | May import from |
|
||||
|-------|------------|-----------------|
|
||||
| 4. API / Entry | [list] | 1, 2, 3 |
|
||||
| 3. Application | [list] | 1, 2 |
|
||||
| 2. Domain | [list] | 1 |
|
||||
| 1. Shared / Foundation | shared/* | (none) |
|
||||
|
||||
Violations of this table are **Architecture** findings in code-review Phase 7 and are High severity.
|
||||
|
||||
## Layout Conventions (reference)
|
||||
|
||||
| Language | Root | Per-component path | Public API file | Test path |
|
||||
|----------|------|-------------------|-----------------|-----------|
|
||||
| Python | `src/<pkg>/` | `src/<pkg>/<component>/` | `src/<pkg>/<component>/__init__.py` (re-exports) | `tests/<component>/` |
|
||||
| C# (.NET) | `src/` | `src/<Component>/` | `src/<Component>/<Component>.cs` (namespace root) | `tests/<Component>.Tests/` |
|
||||
| Rust | `crates/` | `crates/<component>/` | `crates/<component>/src/lib.rs` | `crates/<component>/tests/` |
|
||||
| TypeScript / React | `packages/` or `src/` | `src/<component>/` | `src/<component>/index.ts` (barrel) | `src/<component>/__tests__/` or `tests/<component>/` |
|
||||
| Go | `./` | `internal/<component>/` or `pkg/<component>/` | `internal/<component>/doc.go` + exported symbols | `internal/<component>/*_test.go` |
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Self-verification for the decompose skill
|
||||
|
||||
When writing `_docs/02_document/module-layout.md`, verify:
|
||||
|
||||
- [ ] Every component in `_docs/02_document/components/` has a Per-Component Mapping entry.
|
||||
- [ ] Every shared / cross-cutting epic has an entry in the Shared section.
|
||||
- [ ] Layering table rows cover every component.
|
||||
- [ ] No component's `Imports from` list contains a component at a higher layer.
|
||||
- [ ] Paths follow the detected language's convention.
|
||||
- [ ] No two components own overlapping paths.
|
||||
|
||||
## How the implement skill consumes this
|
||||
|
||||
The implement skill's Step 4 (File Ownership) reads this file and, for each task in the batch:
|
||||
|
||||
1. Resolve the task's Component field to a Per-Component Mapping entry.
|
||||
2. Set OWNED = the component's `Owns` glob.
|
||||
3. Set READ-ONLY = the Public API files of every component listed in `Imports from`, plus `shared/*` Public API files.
|
||||
4. Set FORBIDDEN = every other component's Owns glob.
|
||||
|
||||
If two tasks in the same batch map to the same component, the implement skill schedules them sequentially (one implementer at a time for that component) to avoid file conflicts on shared internal files.
|
||||
@@ -81,6 +81,17 @@ Then [expected result]
|
||||
**Risk 1: [Title]**
|
||||
- *Risk*: [Description]
|
||||
- *Mitigation*: [Approach]
|
||||
|
||||
## Contract
|
||||
|
||||
<!--
|
||||
OMIT this section for behavioral-only tasks.
|
||||
INCLUDE this section ONLY for shared-models / shared-API / contract tasks.
|
||||
See decompose/SKILL.md Step 2 shared-models rule and decompose/templates/api-contract.md.
|
||||
-->
|
||||
|
||||
This task produces/implements the contract at `_docs/02_document/contracts/<component>/<name>.md`.
|
||||
Consumers MUST read that file — not this task spec — to discover the interface.
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
Reference in New Issue
Block a user