Files
annotations/_docs/02_document/diagrams/flows/flow_annotation_create.md
T
Oleksandr Bezdieniezhnykh 03f879206e docs+src: complete Steps 1-3 outcomes + auth re-sync baseline
This commit captures everything produced during autodev existing-code
Steps 1 (Document), 2 (Architecture Baseline Scan), and 3 (Test Spec),
together with the targeted auth + CORS re-sync triggered on 2026-05-14
when codebase drift was detected at Step 4 entry. None of this work was
previously committed.

Step 1 (Document) — 50+ _docs/02_document/ files: problem, solution,
architecture, system flows, glossary, module-layout, per-component
specs (01..06), modules, deployment, diagrams, data model, FINAL
report, verification log, discovery.

Step 2 (Architecture Baseline) — architecture_compliance_baseline.md.
Verdict PASS_WITH_WARNINGS (0 Critical, 0 High, 1 Medium, 2 Low). No
High/Critical findings; auto-chained to Step 3 per existing-code flow.

Step 3 (Test Spec) — _docs/02_document/tests/* (67 scenarios across
blackbox, security, resilience, resource-limit, performance), plus
e2e/docker-compose.test.yml, e2e/seed/run.sh, scripts/run-tests.sh,
scripts/run-performance-tests.sh. Coverage 88% over the active scope
(40 of 45 items covered, 6 RB-deferred, 5 documented-as-uncovered).

Targeted auth + CORS re-sync — replaces the deleted in-house token
issuer with a JWKS-verifier model. AuthController and TokenService
removed; JwtExtensions switched from HS256 symmetric to ES256 over
admin's JWKS. ConfigurationResolver and CorsConfigurationValidator
added under src/Infrastructure/. ADR-002 and ADR-006 retired; SEC-01,
SEC-02, SEC-03 marked Closed. One new testability risk recorded in
architecture.md Open Risks Section 6 (JWKS HTTPS gating).

Source changes:
- src/Auth/JwtExtensions.cs (modified) — ES256, JWKS, alg pinning
- src/Program.cs (modified) — DI wiring for ConfigurationResolver
  and CorsConfigurationValidator
- src/Controllers/AuthController.cs (deleted) — no in-service issuance
- src/Services/TokenService.cs (deleted) — same
- src/Infrastructure/ConfigurationResolver.cs (new)
- src/Infrastructure/CorsConfigurationValidator.cs (new)
- .env.example (new) — required env var documentation
- .gitignore (updated)

Cross-repo coordination: _docs/cross-repo/flights_h1_h2_h3_change_spec
captures the change-spec for downstream services that consumed the now
deleted /auth endpoints.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-14 20:19:05 +03:00

3.4 KiB

Flow F1 — Annotation Create

Cross-reference: system-flows.md → Flow F1.

Sequence (verified against Services/AnnotationService.cs)

sequenceDiagram
    autonumber
    participant Caller as Detections / UI
    participant Ctrl as AnnotationsController (01)
    participant Svc as AnnotationService (01)
    participant Path as PathResolver (06)
    participant DB as PostgreSQL (06)
    participant FS as Filesystem
    participant Evt as AnnotationEventService (02)
    participant Q as annotations_queue_records (DB / 02)

    Caller->>Ctrl: POST /annotations (CreateAnnotationRequest, JWT ANN)
    Ctrl->>Svc: CreateAnnotation(request, userIdFromJwt)

    alt request.Image bytes provided
        Svc->>Svc: ComputeHash (XxHash64 over sampled bytes) -> id
        Svc->>FS: write {id}.jpg under images_dir
        Svc->>DB: SELECT media WHERE id = :id
        opt media row missing
            Svc->>DB: INSERT media (Image, MediaStatus.New, ...)
        end
    else MediaId provided
        Svc->>DB: SELECT media WHERE id = :MediaId (404 if missing)
        opt source media file exists & target image missing
            Svc->>FS: copy media.Path -> images_dir/{id}.jpg
        end
    end

    Svc->>DB: INSERT annotations
    Svc->>DB: BulkCopy detection rows
    Svc->>FS: write {id}.txt (YOLO label) under labels_dir
    Svc->>Evt: PublishAsync(AnnotationEventDto)
    Svc->>DB: SELECT system_settings (FirstOrDefault)
    alt SilentDetection != true
        Svc->>Q: FailsafeProducer.EnqueueAsync(db, id, QueueOperation.Created)
    end
    Svc-->>Ctrl: Annotation
    Ctrl-->>Caller: 201 Created (Location: /annotations/{id})

Flowchart

flowchart TD
    start([POST /annotations]) --> auth{JWT valid + ANN claim?}
    auth -->|no| rej401([401 / 403])
    auth -->|yes| input{bytes or MediaId?}
    input -->|neither| arg([400 ArgumentException])
    input -->|bytes| hash[ComputeHash sampled XxHash64 -> id]
    input -->|MediaId| lookupMedia[SELECT media WHERE id = MediaId]
    lookupMedia -->|missing| nf404([404 KeyNotFound])
    lookupMedia -->|exists| copyImg[copy media.Path to images dir if missing]
    hash --> writeImg[write {id}.jpg]
    writeImg --> mediaRow[INSERT media if absent]
    mediaRow --> writeDb
    copyImg --> writeDb[INSERT annotations + BulkCopy detections]
    writeDb --> writeLabel[write {id}.txt YOLO label]
    writeLabel --> sse[PublishAsync SSE event]
    sse --> readSettings[SELECT system_settings]
    readSettings --> silentChk{SilentDetection?}
    silentChk -->|yes| ok([201 Created])
    silentChk -->|no| outbox[FailsafeProducer.EnqueueAsync Created]
    outbox --> ok

    writeImg -->|IOException| err500([500 via ErrorHandlingMiddleware])
    writeDb -->|DB error| err500
    writeLabel -->|IOException| err500
    outbox -->|DB error| err500

Notes

  • Image hashing is XxHash64 over a sampled input (length prefix + head/middle/tail 1KB) for inputs > 3072 bytes. See ADR-004 in architecture.md for collision implications.
  • The implementation is not transactional across FS + DB + outbox. Partial failure can leave orphan files or unsent outbox rows. Captured in system-flows.md → Open Behavioral Questions §4.
  • Update, UpdateStatus, DeleteAnnotation paths do NOT publish SSE or enqueue outbox today. Captured in system-flows.md → Open Behavioral Questions §1.
  • Outbox row is consumed asynchronously by Flow F4 (FailsafeProducer).