[AZ-381] Fix ISam2GraphHandleImpl missing get_pose_key + comments

mirror of https://github.com/azaion/gps-denied-onboard.git synced 2026-06-22 15:51:14 +00:00

F1 (High/Architecture) from cumulative review of batches 01-22:
`ISam2GraphHandleImpl` did not satisfy C4's `ISam2GraphHandle`
Protocol stub (AZ-355) because it lacked `get_pose_key`.
`pose_factory`'s isinstance gate would have raised at composition.
Two Protocols (C4 minimal consumer cut, C5 richer producer surface)
are intentional per AZ-355 Risk 1 — the impl just needed to expose
the canonical name. Delegates to estimator.key_for_frame.

Added cross-component conformance test asserting the C5 impl
satisfies both Protocols, so future drift trips a unit test.

F2 (Medium/Maintainability): added justifying comments at four
`except: pass` sites in runtime_root, c8_fc_adapter (ap + inav),
and c13_fdr writer. No behavioral change.

Updated cumulative review report verdict from FAIL to PASS and
recorded a post-mortem on the initial misframing
(treated the dual-Protocol design as duplication on first read).

Autodev state: batch 22 done, cumulative-review PASS,
ready for batch 23.

Co-authored-by: Cursor <cursoragent@cursor.com>

This commit is contained in:

Oleksandr Bezdieniezhnykh

2026-05-12 03:55:41 +03:00

parent 8a83166261

commit 48281db9e9

8 changed files with 216 additions and 3 deletions

_docs/_autodev_state.md

+3 -3

View File

@@ -6,9 +6,9 @@ step: 7
 name: Implement
 status: in_progress
 sub_step:
   phase: 6
   name: implement-tasks
   detail: ""
   phase: 14
   name: cumulative-code-review
   detail: "PASS after F1+F2 remediation in-session; F3 informational; ready for batch 23"
 retry_count: 0
 cycle: 1
 tracker: jira