azaion/gps-denied-onboard
1
0
Fork 0
mirror of https://github.com/azaion/gps-denied-onboard.git synced 2026-06-22 10:41:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AZ-337] [AZ-338] [AZ-508] Cumulative review batches 46-48

Browse Source 
Verdict: PASS_WITH_WARNINGS. Per-batch reviews already validated
each task's ACs; this cumulative review focuses on cross-batch
drift and surfaces 1 Medium + 2 Low maintainability findings:

- F1 (Medium): `_iso_ts_from_clock` Clock-injected helper duplicated
  across 4 files (c2_vpr/net_vlad + ultra_vpr + _faiss_bridge,
  c12_operator_orchestrator/operator_reloc_service). B46 + B47
  carry inline comments anticipating AZ-508 would consolidate this,
  but AZ-508 (Batch 48) scoped itself narrower (stdlib-only,
  Excluded the Clock-injected variant). Recommend a 2-point follow-up
  PBI adding `iso_ts_from_clock(clock)` to helpers/iso_timestamps.py
  before AZ-339 / AZ-340 / AZ-358 / AZ-389 add more copies.

- F2 (Low): `_assert_engine_output_dim` near-duplicated between
  NetVLAD and UltraVPR. Defer consolidation until 5 c2_vpr strategies
  are in flight (after AZ-339 / AZ-340).

- F3 (Low): Clock-driven helper outputs `+00:00`; canonical FDR `ts`
  is `Z`. Fold into F1 follow-up PBI.

No Critical or High findings; auto-chain to next batch allowed.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
2026-05-13 23:26:58 +03:00
parent 5441ea2017
commit fbeeab60b3
2 changed files with 248 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_docs/_autodev_state.md
+2 -2
View File
@@ -8,9 +8,9 @@ status: in_progress
sub_step:
phase: 7
name: batch-loop
detail: "cumulative review batches 46-48 due before next batch"
detail: ""
retry_count: 0
cycle: 1
tracker: jira
last_completed_batch: 48
last_cumulative_review: batches_43-45
last_cumulative_review: batches_46-48