Files
gps-denied-onboard/tests/unit/c6_tile_cache/test_protocol_conformance.py
T
Oleksandr Bezdieniezhnykh f925af9de3 [AZ-303] C6 storage interfaces: Protocols + DTOs + factories
Freezes the c6_tile_cache Public API per
_docs/02_document/contracts/c6_tile_cache/{tile_store,tile_metadata_store,
descriptor_index}.md v1.0.0:

- Three runtime_checkable Protocols (TileStore 4-method, TileMetadataStore
  9-method, DescriptorIndex 5-method) in components/c6_tile_cache/interface.py.
- Frozen DTOs + enums (TileId, TileMetadata, TileMetadataPersistent,
  TileQualityMetadata, Bbox, SectorBoundary, HnswParams, IndexMetadata,
  TileSource, FreshnessLabel, VotingStatus, SectorClassification) in
  components/c6_tile_cache/_types.py. Constructor-time validation rejects
  out-of-range zoom_level / lat / lon and inverted Bbox.
- TilePixelHandle ABC for read-only mmap access (Invariant I-4).
- TileCacheError family (6 subtypes) + IndexBuildError (deliberately
  outside the family) in components/c6_tile_cache/errors.py.
- C6TileCacheConfig per-component config block, registered on package
  import; validates known runtime labels at construction time.
- Composition-root factories build_tile_store / build_tile_metadata_store /
  build_descriptor_index in runtime_root/storage_factory.py, with lazy
  concrete-impl imports gated by BUILD_FAISS_INDEX (AC-5 / Risk 2:
  no module-level FAISS import when the flag is OFF).
- RuntimeNotAvailableError defined in runtime_root/errors.py to be shared
  with AZ-297 (composition-time error, distinct from per-component
  runtime errors).

51 conformance tests cover all 10 ACs + NFR-perf-factory (p99 build_*
under 50 ms across 1000 calls) + NFR-reliability-error-family. AC-9
introspects each contract file's Shape table and asserts method
parity against the runtime Protocol.

Retired the AZ-263 scaffolding SectorClassification (dataclass) and
TileQualityMetadata from _types/tile.py since their canonical home is
now c6_tile_cache._types; Tile and TileRecord remain in _types/tile.py
until c3_matcher (AZ-344) and c11_tile_manager (AZ-316/319) retire
their interface stubs.

Full unit-test sweep: 791 passed, 2 pre-existing environment skips.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-12 04:21:44 +03:00

609 lines
19 KiB
Python

"""AZ-303 — C6 storage Protocol + DTO + error + factory conformance.
Covers all 10 ACs of AZ-303 (see ``_docs/02_tasks/todo/AZ-303_...``).
The factory ACs (AC-4 / AC-5) substitute lazy-importable fake impl
modules at ``sys.modules`` boundaries so the test never touches FAISS
or psycopg2.
"""
from __future__ import annotations
import dataclasses
import re
import sys
import types
from datetime import datetime, timezone
from pathlib import Path
import pytest
from gps_denied_onboard.components.c6_tile_cache import (
Bbox,
C6TileCacheConfig,
ContentHashMismatchError,
DescriptorIndex,
FreshnessLabel,
FreshnessRejectionError,
HnswParams,
IndexBuildError,
IndexMetadata,
IndexUnavailableError,
SectorBoundary,
SectorClassification,
TileCacheError,
TileFsError,
TileId,
TileMetadata,
TileMetadataError,
TileMetadataPersistent,
TileMetadataStore,
TileNotFoundError,
TilePixelHandle,
TileQualityMetadata,
TileSource,
TileStore,
VotingStatus,
)
from gps_denied_onboard.components.c6_tile_cache.config import (
KNOWN_DESCRIPTOR_INDEX_RUNTIMES,
)
from gps_denied_onboard.config.schema import Config, ConfigError
from gps_denied_onboard.runtime_root.errors import RuntimeNotAvailableError
from gps_denied_onboard.runtime_root.storage_factory import (
build_descriptor_index,
build_tile_metadata_store,
build_tile_store,
)
_CONTRACT_DIR = Path(__file__).resolve().parents[3] / (
"_docs/02_document/contracts/c6_tile_cache"
)
_FAKE_IMPL_MODULE = "gps_denied_onboard.components.c6_tile_cache.faiss_descriptor_index"
_FAKE_STORE_MODULE = (
"gps_denied_onboard.components.c6_tile_cache.postgres_filesystem_store"
)
def _valid_tile_id(zoom: int = 18, lat: float = 49.94, lon: float = 36.31) -> TileId:
return TileId(zoom_level=zoom, lat=lat, lon=lon)
def _valid_tile_metadata() -> TileMetadata:
return TileMetadata(
tile_id=_valid_tile_id(),
tile_size_meters=256.0,
tile_size_pixels=256,
capture_timestamp=datetime(2026, 1, 1, tzinfo=timezone.utc),
source=TileSource.GOOGLEMAPS,
content_sha256_hex="a" * 64,
freshness_label=FreshnessLabel.FRESH,
flight_id=None,
companion_id=None,
quality_metadata=None,
voting_status=VotingStatus.TRUSTED,
)
def _config_with_c6(overrides: dict[str, object] | None = None) -> Config:
overrides = overrides or {}
block = C6TileCacheConfig(**overrides) # type: ignore[arg-type]
return Config.with_blocks(c6_tile_cache=block)
# ----------------------------------------------------------------------
# AC-1: three Protocols are conformance-checkable.
class _FullTileStore:
def read_tile_pixels(self, tile_id):
raise NotImplementedError
def write_tile(self, tile_blob, metadata):
raise NotImplementedError
def tile_exists(self, tile_id):
raise NotImplementedError
def delete_tile(self, tile_id):
raise NotImplementedError
class _PartialTileStore:
def read_tile_pixels(self, tile_id):
raise NotImplementedError
def write_tile(self, tile_blob, metadata):
raise NotImplementedError
def tile_exists(self, tile_id):
raise NotImplementedError
class _FullTileMetadataStore:
def query_by_bbox(self, bbox, zoom, *, voting_filter=None, source_filter=None):
raise NotImplementedError
def insert_metadata(self, metadata):
raise NotImplementedError
def update_voting_status(self, tile_id, status):
raise NotImplementedError
def mark_uploaded(self, tile_id, uploaded_at):
raise NotImplementedError
def pending_uploads(self):
raise NotImplementedError
def record_lru_access(self, tile_id, accessed_at):
raise NotImplementedError
def lru_candidates(self, *, max_count):
raise NotImplementedError
def total_disk_bytes(self):
raise NotImplementedError
def get_by_id(self, tile_id):
raise NotImplementedError
class _PartialTileMetadataStore:
def query_by_bbox(self, bbox, zoom, *, voting_filter=None, source_filter=None):
raise NotImplementedError
class _FullDescriptorIndex:
def search_topk(self, query, k):
raise NotImplementedError
def descriptor_dim(self):
raise NotImplementedError
def mmap_handle(self):
raise NotImplementedError
def rebuild_from_descriptors(self, descriptors, tile_ids, hnsw_params):
raise NotImplementedError
def index_metadata(self):
raise NotImplementedError
class _PartialDescriptorIndex:
def search_topk(self, query, k):
raise NotImplementedError
def descriptor_dim(self):
raise NotImplementedError
def test_ac1_tile_store_conformance_full() -> None:
assert isinstance(_FullTileStore(), TileStore)
def test_ac1_tile_store_conformance_partial_missing_delete() -> None:
assert not isinstance(_PartialTileStore(), TileStore)
def test_ac1_tile_metadata_store_conformance_full() -> None:
assert isinstance(_FullTileMetadataStore(), TileMetadataStore)
def test_ac1_tile_metadata_store_conformance_partial() -> None:
assert not isinstance(_PartialTileMetadataStore(), TileMetadataStore)
def test_ac1_descriptor_index_conformance_full() -> None:
assert isinstance(_FullDescriptorIndex(), DescriptorIndex)
def test_ac1_descriptor_index_conformance_partial_missing_metadata() -> None:
assert not isinstance(_PartialDescriptorIndex(), DescriptorIndex)
# ----------------------------------------------------------------------
# AC-2: frozen DTOs reject mutation.
@pytest.mark.parametrize(
"dto, field_name, new_value",
[
(_valid_tile_id(), "lat", 0.0),
(_valid_tile_metadata(), "tile_size_meters", 9999.0),
(Bbox(min_lat=0.0, min_lon=0.0, max_lat=1.0, max_lon=1.0), "min_lat", 5.0),
(HnswParams(), "m", 64),
(
TileQualityMetadata(
estimator_label="satellite_anchored",
covariance_2x2=((0.1, 0.0), (0.0, 0.1)),
last_anchor_age_ms=100,
mre_px=0.5,
imu_bias_norm=0.01,
),
"mre_px",
1.0,
),
],
)
def test_ac2_frozen_dtos_reject_mutation(dto, field_name: str, new_value) -> None:
original_value = getattr(dto, field_name)
with pytest.raises(dataclasses.FrozenInstanceError):
setattr(dto, field_name, new_value)
assert getattr(dto, field_name) == original_value
# ----------------------------------------------------------------------
# AC-3: error hierarchy catchable as a single family.
@pytest.mark.parametrize(
"exc_factory",
[
TileNotFoundError,
TileFsError,
TileMetadataError,
ContentHashMismatchError,
FreshnessRejectionError,
IndexUnavailableError,
],
)
def test_ac3_all_runtime_errors_caught_as_family(exc_factory) -> None:
with pytest.raises(TileCacheError):
raise exc_factory("boom")
def test_ac3_unrelated_exception_not_caught_as_family() -> None:
with pytest.raises(ValueError):
try:
raise ValueError("not us")
except TileCacheError:
pytest.fail("ValueError must not be caught as TileCacheError")
def test_ac3_index_build_error_outside_family() -> None:
with pytest.raises(IndexBuildError):
try:
raise IndexBuildError("offline only")
except TileCacheError:
pytest.fail("IndexBuildError must NOT be in the TileCacheError family")
# ----------------------------------------------------------------------
# AC-4 + AC-5: factory honours config + BUILD flag gate.
@pytest.fixture
def faiss_module_cleanup():
"""Ensure no residual fake FAISS impl module leaks between tests."""
sys.modules.pop(_FAKE_IMPL_MODULE, None)
yield
sys.modules.pop(_FAKE_IMPL_MODULE, None)
@pytest.fixture
def store_module_cleanup():
sys.modules.pop(_FAKE_STORE_MODULE, None)
yield
sys.modules.pop(_FAKE_STORE_MODULE, None)
def _install_fake_faiss_impl_module() -> type:
"""Install a fake ``faiss_descriptor_index`` module in ``sys.modules``.
The fake's ``FaissDescriptorIndex`` class structurally satisfies the
:class:`DescriptorIndex` Protocol. We attach the class via
``types.ModuleType`` so the factory's lazy import succeeds.
"""
class _FakeFaissDescriptorIndex(_FullDescriptorIndex):
def __init__(self, config: Config) -> None:
self.config = config
fake_module = types.ModuleType(_FAKE_IMPL_MODULE)
fake_module.FaissDescriptorIndex = _FakeFaissDescriptorIndex # type: ignore[attr-defined]
sys.modules[_FAKE_IMPL_MODULE] = fake_module
return _FakeFaissDescriptorIndex
def _install_fake_postgres_store_module() -> type:
class _FakePostgresFilesystemStore(_FullTileStore, _FullTileMetadataStore):
def __init__(self, config: Config) -> None:
self.config = config
fake_module = types.ModuleType(_FAKE_STORE_MODULE)
fake_module.PostgresFilesystemStore = _FakePostgresFilesystemStore # type: ignore[attr-defined]
sys.modules[_FAKE_STORE_MODULE] = fake_module
return _FakePostgresFilesystemStore
def test_ac4_build_descriptor_index_returns_protocol_impl(
monkeypatch, faiss_module_cleanup
) -> None:
monkeypatch.setenv("BUILD_FAISS_INDEX", "ON")
fake_cls = _install_fake_faiss_impl_module()
config = _config_with_c6()
handle = build_descriptor_index(config)
assert isinstance(handle, fake_cls)
assert isinstance(handle, DescriptorIndex)
def test_ac5_build_descriptor_index_flag_off_raises_no_import(
monkeypatch, faiss_module_cleanup
) -> None:
monkeypatch.delenv("BUILD_FAISS_INDEX", raising=False)
config = _config_with_c6()
with pytest.raises(RuntimeNotAvailableError) as exc_info:
build_descriptor_index(config)
assert "faiss_hnsw" in str(exc_info.value)
assert _FAKE_IMPL_MODULE not in sys.modules
def test_ac4_build_tile_store_returns_protocol_impl(store_module_cleanup) -> None:
fake_cls = _install_fake_postgres_store_module()
config = _config_with_c6()
store = build_tile_store(config)
assert isinstance(store, fake_cls)
assert isinstance(store, TileStore)
def test_ac4_build_tile_metadata_store_returns_protocol_impl(
store_module_cleanup,
) -> None:
fake_cls = _install_fake_postgres_store_module()
config = _config_with_c6()
md = build_tile_metadata_store(config)
assert isinstance(md, fake_cls)
assert isinstance(md, TileMetadataStore)
def test_ac5_tile_store_runtime_module_missing_raises(store_module_cleanup) -> None:
config = _config_with_c6()
with pytest.raises(RuntimeNotAvailableError) as exc_info:
build_tile_store(config)
assert "postgres_filesystem" in str(exc_info.value)
# ----------------------------------------------------------------------
# AC-6: unknown runtime label rejected at config load.
def test_ac6_unknown_descriptor_index_runtime_rejected() -> None:
with pytest.raises(ConfigError) as exc_info:
C6TileCacheConfig(descriptor_index_runtime="scann")
msg = str(exc_info.value)
assert "scann" in msg
for valid in KNOWN_DESCRIPTOR_INDEX_RUNTIMES:
assert valid in msg
def test_ac6_unknown_store_runtime_rejected() -> None:
with pytest.raises(ConfigError):
C6TileCacheConfig(store_runtime="sqlite_filesystem")
def test_ac6_unknown_metadata_runtime_rejected() -> None:
with pytest.raises(ConfigError):
C6TileCacheConfig(metadata_runtime="sqlite_filesystem")
# ----------------------------------------------------------------------
# AC-7: constructor-time validation rejects bad input.
@pytest.mark.parametrize(
"kwargs, offending_field",
[
({"zoom_level": 22, "lat": 0.0, "lon": 0.0}, "zoom_level"),
({"zoom_level": -1, "lat": 0.0, "lon": 0.0}, "zoom_level"),
({"zoom_level": 18, "lat": 100.0, "lon": 0.0}, "lat"),
({"zoom_level": 18, "lat": 0.0, "lon": -200.0}, "lon"),
],
)
def test_ac7_tile_id_rejects_bad_input(
kwargs: dict[str, float], offending_field: str
) -> None:
with pytest.raises(ValueError) as exc_info:
TileId(**kwargs) # type: ignore[arg-type]
assert offending_field in str(exc_info.value)
@pytest.mark.parametrize(
"kwargs",
[
{"min_lat": 10.0, "min_lon": 0.0, "max_lat": 5.0, "max_lon": 10.0},
{"min_lat": 0.0, "min_lon": 10.0, "max_lat": 5.0, "max_lon": 5.0},
{"min_lat": 5.0, "min_lon": 5.0, "max_lat": 5.0, "max_lon": 10.0},
],
)
def test_ac7_bbox_rejects_inverted_or_degenerate(kwargs: dict[str, float]) -> None:
with pytest.raises(ValueError):
Bbox(**kwargs) # type: ignore[arg-type]
# ----------------------------------------------------------------------
# AC-8: TilePixelHandle is read-only by contract.
class _BytesTilePixelHandle(TilePixelHandle):
"""In-memory fake used by tests; mirrors the mmap impl's read-only contract."""
def __init__(self, blob: bytes, path: Path) -> None:
self._blob = blob
self._path = path
self._view: memoryview | None = None
@property
def filesystem_path(self) -> Path:
return self._path
def __enter__(self) -> memoryview:
self._view = memoryview(self._blob)
return self._view
def __exit__(self, exc_type, exc_val, exc_tb) -> None:
if self._view is not None:
self._view.release()
self._view = None
def test_ac8_tile_pixel_handle_returns_read_only_memoryview(tmp_path: Path) -> None:
blob = b"\xff\xd8\xff" + b"\x00" * 100 # JPEG SOI + filler
handle_path = tmp_path / "fake.jpg"
handle = _BytesTilePixelHandle(blob, handle_path)
with handle as memview:
with pytest.raises(TypeError):
memview[0] = 0xFF # type: ignore[index]
assert bytes(memview[:3]) == b"\xff\xd8\xff"
# ----------------------------------------------------------------------
# AC-9: contract files match Protocol shapes.
_METHOD_TABLE_RE = re.compile(r"^\|\s*`(?P<name>[a-z_][a-z0-9_]*)`\s*\|", re.MULTILINE)
def _methods_from_contract(contract_file: Path) -> set[str]:
"""Pull every backtick-quoted method name from the ``## Shape`` table."""
text = contract_file.read_text(encoding="utf-8")
shape_start = text.index("## Shape")
next_section = text.find("\n## ", shape_start + len("## Shape"))
shape_section = text[shape_start:next_section] if next_section != -1 else text[shape_start:]
return {m.group("name") for m in _METHOD_TABLE_RE.finditer(shape_section)}
def _protocol_methods(proto: type) -> set[str]:
"""Reflect over a Protocol's method names."""
return {
name
for name in dir(proto)
if not name.startswith("_") and callable(getattr(proto, name))
}
@pytest.mark.parametrize(
"contract_filename, proto",
[
("tile_store.md", TileStore),
("tile_metadata_store.md", TileMetadataStore),
("descriptor_index.md", DescriptorIndex),
],
)
def test_ac9_contract_methods_match_protocol(
contract_filename: str, proto: type
) -> None:
contract_path = _CONTRACT_DIR / contract_filename
contract_methods = _methods_from_contract(contract_path)
protocol_methods = _protocol_methods(proto)
missing_in_protocol = contract_methods - protocol_methods
missing_in_contract = protocol_methods - contract_methods
assert not missing_in_protocol, (
f"{contract_filename}: methods declared in contract but missing from "
f"Protocol: {sorted(missing_in_protocol)}"
)
assert not missing_in_contract, (
f"{contract_filename}: methods present on Protocol but missing from "
f"contract: {sorted(missing_in_contract)}"
)
# ----------------------------------------------------------------------
# AC-10: VotingStatus surface.
def test_ac10_voting_status_has_documented_states_only() -> None:
assert {v.value for v in VotingStatus} == {"pending", "trusted", "rejected"}
assert VotingStatus.PENDING.value == "pending"
assert VotingStatus.TRUSTED.value == "trusted"
assert VotingStatus.REJECTED.value == "rejected"
# ----------------------------------------------------------------------
# NFR-reliability-error-family + smoke surface tests.
@pytest.mark.parametrize(
"exc_type",
[
TileNotFoundError,
TileFsError,
TileMetadataError,
ContentHashMismatchError,
FreshnessRejectionError,
IndexUnavailableError,
],
)
def test_nfr_reliability_all_runtime_errors_subclass_family(exc_type) -> None:
assert issubclass(exc_type, TileCacheError)
def test_nfr_reliability_index_build_error_not_in_family() -> None:
assert not issubclass(IndexBuildError, TileCacheError)
def test_sector_classification_enum_surface() -> None:
assert {v.value for v in SectorClassification} == {
"active_conflict",
"stable_rear",
}
def test_sector_boundary_dto_constructs_and_freezes() -> None:
bbox = Bbox(min_lat=0.0, min_lon=0.0, max_lat=1.0, max_lon=1.0)
sector = SectorBoundary(bbox=bbox, classification=SectorClassification.ACTIVE_CONFLICT)
with pytest.raises(dataclasses.FrozenInstanceError):
sector.classification = SectorClassification.STABLE_REAR # type: ignore[misc]
def test_tile_metadata_persistent_dto_constructs_and_freezes() -> None:
md = _valid_tile_metadata()
persistent = TileMetadataPersistent(
metadata=md,
accessed_at=datetime(2026, 1, 2, tzinfo=timezone.utc),
uploaded_at=None,
disk_bytes=12345,
)
with pytest.raises(dataclasses.FrozenInstanceError):
persistent.disk_bytes = 0 # type: ignore[misc]
def test_nfr_perf_build_factories_under_50ms_p99(
monkeypatch, faiss_module_cleanup, store_module_cleanup
) -> None:
"""Factory triple p99 ≤ 50 ms across 1000 calls (NFR-perf-factory)."""
import time
monkeypatch.setenv("BUILD_FAISS_INDEX", "ON")
_install_fake_faiss_impl_module()
_install_fake_postgres_store_module()
config = _config_with_c6()
durations_ms: list[float] = []
for _ in range(1000):
for factory in (build_tile_store, build_tile_metadata_store, build_descriptor_index):
t0 = time.perf_counter()
factory(config)
durations_ms.append((time.perf_counter() - t0) * 1000.0)
durations_ms.sort()
p99 = durations_ms[int(0.99 * len(durations_ms))]
assert p99 <= 50.0, f"build_*() p99={p99:.3f} ms exceeds 50 ms NFR"
def test_index_metadata_dto_constructs_and_freezes(tmp_path: Path) -> None:
md = IndexMetadata(
descriptor_dim=512,
n_vectors=10_000,
backbone_label="ultra_vpr_v0",
backbone_sha256_hex="b" * 64,
built_at=datetime(2026, 1, 3, tzinfo=timezone.utc),
hnsw_params=HnswParams(),
sidecar_sha256_hex="c" * 64,
file_path=tmp_path / "tiles.index",
)
with pytest.raises(dataclasses.FrozenInstanceError):
md.n_vectors = 0 # type: ignore[misc]