mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-22 22:01:15 +00:00
[AZ-488] UAV tile batch upload + 5-rule quality gate
Replaces the 501 stub at POST /api/satellite/upload with a multipart
batch endpoint that ingests UAV-captured tiles, runs each item through
a 5-rule quality gate, and persists accepted tiles via the AZ-484
multi-source storage path with source='uav'.
Quality gate (in fixed order, first failure wins): JPEG format
(content-type + magic), size band 5 KiB-5 MiB, exact 256x256
dimensions, captured-at age (no future >30 s skew, no older than
7 days), luminance variance on 32x32 downsample. Closed reject-reason
enumeration in v1.0.0 contract.
Authorization: custom PermissionsRequirement / PermissionsAuthorization
Handler that reads the JWT `permissions` claim (tolerates both
repeated-string and JSON-array shapes). Endpoint protected by
RequiresGpsPermission policy; 401 without token, 403 without GPS perm.
Persistence: file-first to ./tiles/uav/{z}/{x}/{y}.jpg, then
ITileRepository.InsertAsync UPSERT (per-source UPSERT contract from
AZ-484). Per-item failures reported in response without aborting the
batch. Kestrel MaxRequestBodySize and FormOptions limits set to
MaxBatchSize x MaxBytes (default 100 x 5 MiB = 500 MiB).
New frozen contract: _docs/02_document/contracts/api/uav-tile-upload.md
v1.0.0. PT-08 NFR added to performance-tests.md as Deferred (harness
work tracked in PT-07 leftover, per AZ-488 § Risk 4).
Tests: 11 quality-gate unit tests, 5 handler unit tests, 3 file-path
unit tests, 12 permission-handler unit tests, 7 integration tests
(AC-1..AC-6, AC-8). All 253 unit tests + smoke integration suite
green.
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
@@ -0,0 +1,107 @@
|
||||
using System.Security.Claims;
|
||||
using FluentAssertions;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
using SatelliteProvider.Api.Authentication;
|
||||
|
||||
namespace SatelliteProvider.Tests.Authentication;
|
||||
|
||||
public class PermissionsRequirementTests
|
||||
{
|
||||
[Fact]
|
||||
public void Constructor_RejectsBlankPermission()
|
||||
{
|
||||
// Act
|
||||
var act = () => new PermissionsRequirement(" ");
|
||||
|
||||
// Assert
|
||||
act.Should().Throw<ArgumentException>();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_SucceedsWhenSingleStringClaimMatches()
|
||||
{
|
||||
// Arrange
|
||||
var requirement = new PermissionsRequirement(SatellitePermissions.Gps);
|
||||
var handler = new PermissionsAuthorizationHandler();
|
||||
var user = BuildUser(new Claim(PermissionsAuthorizationHandler.ClaimType, "GPS"));
|
||||
var context = new AuthorizationHandlerContext(new[] { requirement }, user, null);
|
||||
|
||||
// Act
|
||||
await handler.HandleAsync(context);
|
||||
|
||||
// Assert
|
||||
context.HasSucceeded.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_SucceedsWhenMultipleClaimsContainTarget()
|
||||
{
|
||||
// Arrange
|
||||
var requirement = new PermissionsRequirement(SatellitePermissions.Gps);
|
||||
var handler = new PermissionsAuthorizationHandler();
|
||||
var user = BuildUser(
|
||||
new Claim(PermissionsAuthorizationHandler.ClaimType, "FL"),
|
||||
new Claim(PermissionsAuthorizationHandler.ClaimType, "GPS"));
|
||||
var context = new AuthorizationHandlerContext(new[] { requirement }, user, null);
|
||||
|
||||
// Act
|
||||
await handler.HandleAsync(context);
|
||||
|
||||
// Assert
|
||||
context.HasSucceeded.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_SucceedsWhenSingleClaimEncodesJsonArray()
|
||||
{
|
||||
// Arrange
|
||||
var requirement = new PermissionsRequirement(SatellitePermissions.Gps);
|
||||
var handler = new PermissionsAuthorizationHandler();
|
||||
var user = BuildUser(new Claim(PermissionsAuthorizationHandler.ClaimType, "[\"FL\",\"GPS\"]"));
|
||||
var context = new AuthorizationHandlerContext(new[] { requirement }, user, null);
|
||||
|
||||
// Act
|
||||
await handler.HandleAsync(context);
|
||||
|
||||
// Assert
|
||||
context.HasSucceeded.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_DoesNotSucceedWhenClaimIsMissing()
|
||||
{
|
||||
// Arrange
|
||||
var requirement = new PermissionsRequirement(SatellitePermissions.Gps);
|
||||
var handler = new PermissionsAuthorizationHandler();
|
||||
var user = BuildUser(new Claim(PermissionsAuthorizationHandler.ClaimType, "FL"));
|
||||
var context = new AuthorizationHandlerContext(new[] { requirement }, user, null);
|
||||
|
||||
// Act
|
||||
await handler.HandleAsync(context);
|
||||
|
||||
// Assert
|
||||
context.HasSucceeded.Should().BeFalse();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_DoesNotSucceedWhenUserIsAnonymous()
|
||||
{
|
||||
// Arrange
|
||||
var requirement = new PermissionsRequirement(SatellitePermissions.Gps);
|
||||
var handler = new PermissionsAuthorizationHandler();
|
||||
var anon = new ClaimsPrincipal(new ClaimsIdentity());
|
||||
var context = new AuthorizationHandlerContext(new[] { requirement }, anon, null);
|
||||
|
||||
// Act
|
||||
await handler.HandleAsync(context);
|
||||
|
||||
// Assert
|
||||
context.HasSucceeded.Should().BeFalse();
|
||||
}
|
||||
|
||||
private static ClaimsPrincipal BuildUser(params Claim[] claims)
|
||||
{
|
||||
var identity = new ClaimsIdentity(claims, authenticationType: "Test");
|
||||
return new ClaimsPrincipal(identity);
|
||||
}
|
||||
}
|
||||
@@ -21,6 +21,7 @@
|
||||
<PackageReference Include="Microsoft.Extensions.Options" Version="9.0.10" />
|
||||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
|
||||
<PackageReference Include="Moq" Version="4.20.72" />
|
||||
<PackageReference Include="SixLabors.ImageSharp" Version="3.1.11" />
|
||||
<PackageReference Include="xunit" Version="2.5.3" />
|
||||
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.3" />
|
||||
</ItemGroup>
|
||||
|
||||
@@ -0,0 +1,74 @@
|
||||
using SixLabors.ImageSharp;
|
||||
using SixLabors.ImageSharp.Formats.Jpeg;
|
||||
using SixLabors.ImageSharp.Formats.Png;
|
||||
using SixLabors.ImageSharp.PixelFormats;
|
||||
|
||||
namespace SatelliteProvider.Tests.TestUtilities;
|
||||
|
||||
internal static class UavTileImageFactory
|
||||
{
|
||||
public static byte[] CreateRandomJpeg(int width = 256, int height = 256, int seed = 42, int quality = 95)
|
||||
{
|
||||
using var image = new Image<Rgba32>(width, height);
|
||||
var random = new Random(seed);
|
||||
|
||||
image.ProcessPixelRows(accessor =>
|
||||
{
|
||||
for (var y = 0; y < accessor.Height; y++)
|
||||
{
|
||||
var row = accessor.GetRowSpan(y);
|
||||
for (var x = 0; x < row.Length; x++)
|
||||
{
|
||||
row[x] = new Rgba32(
|
||||
(byte)random.Next(256),
|
||||
(byte)random.Next(256),
|
||||
(byte)random.Next(256));
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
using var stream = new MemoryStream();
|
||||
image.Save(stream, new JpegEncoder { Quality = quality });
|
||||
return stream.ToArray();
|
||||
}
|
||||
|
||||
public static byte[] CreateUniformGreyJpeg(int width = 256, int height = 256, byte value = 128, int quality = 95)
|
||||
{
|
||||
using var image = new Image<L8>(width, height);
|
||||
image.ProcessPixelRows(accessor =>
|
||||
{
|
||||
for (var y = 0; y < accessor.Height; y++)
|
||||
{
|
||||
var row = accessor.GetRowSpan(y);
|
||||
for (var x = 0; x < row.Length; x++)
|
||||
{
|
||||
row[x] = new L8(value);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
using var stream = new MemoryStream();
|
||||
image.Save(stream, new JpegEncoder { Quality = quality });
|
||||
return stream.ToArray();
|
||||
}
|
||||
|
||||
public static byte[] CreatePng(int width = 256, int height = 256)
|
||||
{
|
||||
using var image = new Image<Rgba32>(width, height);
|
||||
image.ProcessPixelRows(accessor =>
|
||||
{
|
||||
for (var y = 0; y < accessor.Height; y++)
|
||||
{
|
||||
var row = accessor.GetRowSpan(y);
|
||||
for (var x = 0; x < row.Length; x++)
|
||||
{
|
||||
row[x] = new Rgba32(255, 255, 255);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
using var stream = new MemoryStream();
|
||||
image.Save(stream, new PngEncoder());
|
||||
return stream.ToArray();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
using FluentAssertions;
|
||||
using SatelliteProvider.Common.Configs;
|
||||
using SatelliteProvider.Services.TileDownloader;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class UavTileFilePathTests
|
||||
{
|
||||
[Theory]
|
||||
[InlineData("./tiles", 18, 76800, 50331)]
|
||||
[InlineData("/var/lib/sat/tiles", 16, 12345, 67890)]
|
||||
public void BuildUavTileFilePath_MatchesContract(string root, int zoom, int x, int y)
|
||||
{
|
||||
// Arrange
|
||||
var storage = new StorageConfig { TilesDirectory = root };
|
||||
|
||||
// Act
|
||||
var path = UavTileUploadHandler.BuildUavTileFilePath(storage, zoom, x, y);
|
||||
|
||||
// Assert
|
||||
var expected = Path.Combine(root, "uav", zoom.ToString(), x.ToString(), y + ".jpg");
|
||||
path.Should().Be(expected,
|
||||
"UAV file paths follow `./tiles/uav/{zoom}/{x}/{y}.jpg` per `uav-tile-upload.md` v1.0.0");
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,237 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using SatelliteProvider.Common.Configs;
|
||||
using SatelliteProvider.Common.DTO;
|
||||
using SatelliteProvider.Services.TileDownloader;
|
||||
using SatelliteProvider.Tests.TestUtilities;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class UavTileQualityGateTests
|
||||
{
|
||||
private const string JpegContentType = "image/jpeg";
|
||||
|
||||
[Fact]
|
||||
public void Validate_NonJpegContentType_RejectsInvalidFormat()
|
||||
{
|
||||
// Arrange
|
||||
var gate = BuildGate();
|
||||
var bytes = UavTileImageFactory.CreatePng();
|
||||
var metadata = ValidMetadata();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, "image/png", metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.InvalidFormat);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WrongMagicBytes_RejectsInvalidFormat()
|
||||
{
|
||||
// Arrange
|
||||
var gate = BuildGate();
|
||||
var bytes = new byte[6_000];
|
||||
bytes[0] = 0x89; bytes[1] = 0x50; bytes[2] = 0x4E; bytes[3] = 0x47;
|
||||
var metadata = ValidMetadata();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.InvalidFormat);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_ValidJpeg_PassesFormatRule()
|
||||
{
|
||||
// Arrange
|
||||
var gate = BuildGate();
|
||||
var bytes = UavTileImageFactory.CreateRandomJpeg();
|
||||
var metadata = ValidMetadata();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_TooSmall_RejectsSizeOutOfBand()
|
||||
{
|
||||
// Arrange
|
||||
var bytes = new byte[200];
|
||||
bytes[0] = 0xFF; bytes[1] = 0xD8; bytes[2] = 0xFF;
|
||||
var gate = BuildGate();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.SizeOutOfBand);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_TooLarge_RejectsSizeOutOfBand()
|
||||
{
|
||||
// Arrange — craft a JPEG-prefixed byte blob just over the configured MaxBytes ceiling.
|
||||
var qualityConfig = new UavQualityConfig { MaxBytes = 8 * 1024 };
|
||||
var oversized = new byte[qualityConfig.MaxBytes + 1];
|
||||
oversized[0] = 0xFF; oversized[1] = 0xD8; oversized[2] = 0xFF;
|
||||
var gate = BuildGate(qualityConfig);
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(oversized, JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.SizeOutOfBand);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_WrongDimensions_RejectsWrongDimensions()
|
||||
{
|
||||
// Arrange
|
||||
var bytes = UavTileImageFactory.CreateRandomJpeg(width: 512, height: 512);
|
||||
var gate = BuildGate();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.WrongDimensions);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_CapturedAtFuture_RejectsCapturedAtFuture()
|
||||
{
|
||||
// Arrange
|
||||
var now = new DateTime(2026, 5, 11, 12, 0, 0, DateTimeKind.Utc);
|
||||
var gate = BuildGate(timeProvider: new FixedTimeProvider(now));
|
||||
var bytes = UavTileImageFactory.CreateRandomJpeg();
|
||||
var metadata = ValidMetadata() with { CapturedAt = now.AddHours(1) };
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.CapturedAtFuture);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_CapturedAtTooOld_RejectsCapturedAtTooOld()
|
||||
{
|
||||
// Arrange
|
||||
var now = new DateTime(2026, 5, 11, 12, 0, 0, DateTimeKind.Utc);
|
||||
var gate = BuildGate(timeProvider: new FixedTimeProvider(now));
|
||||
var bytes = UavTileImageFactory.CreateRandomJpeg();
|
||||
var metadata = ValidMetadata() with { CapturedAt = now.AddDays(-8) };
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.CapturedAtTooOld);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_CapturedAtSlightlyInFuture_WithinSkew_Accepts()
|
||||
{
|
||||
// Arrange
|
||||
var now = new DateTime(2026, 5, 11, 12, 0, 0, DateTimeKind.Utc);
|
||||
var gate = BuildGate(timeProvider: new FixedTimeProvider(now));
|
||||
var bytes = UavTileImageFactory.CreateRandomJpeg();
|
||||
var metadata = ValidMetadata() with { CapturedAt = now.AddSeconds(20) };
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, metadata);
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_UniformGreyImage_RejectsImageTooUniform()
|
||||
{
|
||||
// Arrange — uniform-color JPEGs compress to far below the
|
||||
// default 5 KiB MinBytes (rule 2). Drop MinBytes so rule 5
|
||||
// remains the active filter for this test.
|
||||
var bytes = UavTileImageFactory.CreateUniformGreyJpeg(value: 128);
|
||||
var gate = BuildGate(new UavQualityConfig { MinBytes = 1 });
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.ImageTooUniform);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_FirstFailingRuleWins_FormatBeforeDimensions()
|
||||
{
|
||||
// Arrange — a PNG resized to 512x512 fails BOTH rule 1 (content-type
|
||||
// says JPEG but magic bytes don't) AND rule 3 (dimensions != 256).
|
||||
// Rule 1 runs first so we expect INVALID_FORMAT.
|
||||
var bytes = UavTileImageFactory.CreatePng(width: 512, height: 512);
|
||||
var gate = BuildGate();
|
||||
|
||||
// Act
|
||||
var result = gate.Validate(bytes, JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeFalse();
|
||||
result.Reason.Should().Be(UavTileRejectReasons.InvalidFormat);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Validate_HappyPath_RandomNoiseJpeg_Accepts()
|
||||
{
|
||||
// Act
|
||||
var result = BuildGate().Validate(UavTileImageFactory.CreateRandomJpeg(), JpegContentType, ValidMetadata());
|
||||
|
||||
// Assert
|
||||
result.Accepted.Should().BeTrue();
|
||||
result.Reason.Should().BeNull();
|
||||
}
|
||||
|
||||
private static UavTileQualityGate BuildGate(UavQualityConfig? quality = null, MapConfig? map = null, TimeProvider? timeProvider = null)
|
||||
{
|
||||
return new UavTileQualityGate(
|
||||
Options.Create(quality ?? new UavQualityConfig()),
|
||||
Options.Create(map ?? new MapConfig { TileSizePixels = 256 }),
|
||||
timeProvider ?? new FixedTimeProvider(new DateTime(2026, 5, 11, 12, 0, 0, DateTimeKind.Utc)));
|
||||
}
|
||||
|
||||
private static UavTileMetadata ValidMetadata() => new()
|
||||
{
|
||||
Latitude = 47.461747,
|
||||
Longitude = 37.647063,
|
||||
TileZoom = 18,
|
||||
TileSizeMeters = 200.0,
|
||||
CapturedAt = new DateTime(2026, 5, 11, 11, 30, 0, DateTimeKind.Utc),
|
||||
};
|
||||
|
||||
private sealed class FixedTimeProvider : TimeProvider
|
||||
{
|
||||
private readonly DateTime _utcNow;
|
||||
|
||||
public FixedTimeProvider(DateTime utcNow)
|
||||
{
|
||||
if (utcNow.Kind != DateTimeKind.Utc)
|
||||
{
|
||||
throw new ArgumentException("DateTime must be UTC", nameof(utcNow));
|
||||
}
|
||||
_utcNow = utcNow;
|
||||
}
|
||||
|
||||
public override DateTimeOffset GetUtcNow() => new(_utcNow, TimeSpan.Zero);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,213 @@
|
||||
using System.Text.Json;
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Moq;
|
||||
using SatelliteProvider.Common.Configs;
|
||||
using SatelliteProvider.Common.DTO;
|
||||
using SatelliteProvider.Common.Enums;
|
||||
using SatelliteProvider.DataAccess.Models;
|
||||
using SatelliteProvider.DataAccess.Repositories;
|
||||
using SatelliteProvider.Services.TileDownloader;
|
||||
using SatelliteProvider.Tests.TestUtilities;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class UavTileUploadHandlerTests : IDisposable
|
||||
{
|
||||
private readonly string _tilesRoot;
|
||||
|
||||
public UavTileUploadHandlerTests()
|
||||
{
|
||||
_tilesRoot = Path.Combine(Path.GetTempPath(), "satprov-uavtests-" + Guid.NewGuid().ToString("N"));
|
||||
Directory.CreateDirectory(_tilesRoot);
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_tilesRoot))
|
||||
{
|
||||
Directory.Delete(_tilesRoot, recursive: true);
|
||||
}
|
||||
GC.SuppressFinalize(this);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_HappyPath_PersistsRowAndAcceptsItem()
|
||||
{
|
||||
// Arrange
|
||||
var jpeg = UavTileImageFactory.CreateRandomJpeg();
|
||||
var metadata = ValidMetadata();
|
||||
var (handler, repo) = BuildHandler();
|
||||
var inserted = new List<TileEntity>();
|
||||
repo.Setup(r => r.InsertAsync(It.IsAny<TileEntity>()))
|
||||
.ReturnsAsync(Guid.NewGuid())
|
||||
.Callback<TileEntity>(e => inserted.Add(e));
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
JsonSerializer.Serialize(new UavTileBatchMetadataPayload { Items = { metadata } }),
|
||||
new List<UavUploadFile> { new("tile.jpg", "image/jpeg", jpeg) });
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeFalse();
|
||||
result.Response!.Items.Should().HaveCount(1);
|
||||
result.Response.Items[0].Status.Should().Be(UavTileUploadStatus.Accepted);
|
||||
result.Response.Items[0].TileId.Should().NotBeNull();
|
||||
inserted.Should().HaveCount(1);
|
||||
inserted[0].Source.Should().Be(TileSourceConverter.ToWireValue(TileSource.Uav));
|
||||
inserted[0].FilePath.Should().Contain(Path.Combine("uav", "18"));
|
||||
File.Exists(inserted[0].FilePath).Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_MixedBatch_AcceptsValidRejectsBadItems()
|
||||
{
|
||||
// Arrange
|
||||
var goodJpeg = UavTileImageFactory.CreateRandomJpeg();
|
||||
var wrongDimensions = UavTileImageFactory.CreateRandomJpeg(width: 512, height: 512);
|
||||
var notJpeg = new byte[6000];
|
||||
notJpeg[0] = 0x89; notJpeg[1] = 0x50; notJpeg[2] = 0x4E; notJpeg[3] = 0x47;
|
||||
var meta = ValidMetadata();
|
||||
var (handler, repo) = BuildHandler();
|
||||
repo.Setup(r => r.InsertAsync(It.IsAny<TileEntity>())).ReturnsAsync(Guid.NewGuid());
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
JsonSerializer.Serialize(new UavTileBatchMetadataPayload
|
||||
{
|
||||
Items = { meta, meta with { Latitude = meta.Latitude + 0.001 }, meta with { Latitude = meta.Latitude + 0.002 } }
|
||||
}),
|
||||
new List<UavUploadFile>
|
||||
{
|
||||
new("a.jpg", "image/jpeg", goodJpeg),
|
||||
new("b.jpg", "image/jpeg", wrongDimensions),
|
||||
new("c.jpg", "image/jpeg", notJpeg),
|
||||
});
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeFalse();
|
||||
result.Response!.Items.Should().HaveCount(3);
|
||||
result.Response.Items[0].Status.Should().Be(UavTileUploadStatus.Accepted);
|
||||
result.Response.Items[1].Status.Should().Be(UavTileUploadStatus.Rejected);
|
||||
result.Response.Items[1].RejectReason.Should().Be(UavTileRejectReasons.WrongDimensions);
|
||||
result.Response.Items[2].Status.Should().Be(UavTileUploadStatus.Rejected);
|
||||
result.Response.Items[2].RejectReason.Should().Be(UavTileRejectReasons.InvalidFormat);
|
||||
repo.Verify(r => r.InsertAsync(It.IsAny<TileEntity>()), Times.Once,
|
||||
"only the single accepted item should reach the repository");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_OversizedBatch_ReturnsEnvelopeError()
|
||||
{
|
||||
// Arrange
|
||||
var (handler, _) = BuildHandler(new UavQualityConfig { MaxBatchSize = 2 });
|
||||
var metadata = ValidMetadata();
|
||||
var payload = new UavTileBatchMetadataPayload { Items = { metadata, metadata, metadata } };
|
||||
var jpeg = UavTileImageFactory.CreateRandomJpeg();
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
JsonSerializer.Serialize(payload),
|
||||
new List<UavUploadFile>
|
||||
{
|
||||
new("a.jpg", "image/jpeg", jpeg),
|
||||
new("b.jpg", "image/jpeg", jpeg),
|
||||
new("c.jpg", "image/jpeg", jpeg),
|
||||
});
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeTrue();
|
||||
result.EnvelopeError.Should().Contain("exceeds the configured maximum");
|
||||
result.Response.Should().BeNull();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_MismatchedFilesAndMetadata_ReturnsEnvelopeError()
|
||||
{
|
||||
// Arrange
|
||||
var (handler, _) = BuildHandler();
|
||||
var jpeg = UavTileImageFactory.CreateRandomJpeg();
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
JsonSerializer.Serialize(new UavTileBatchMetadataPayload { Items = { ValidMetadata(), ValidMetadata() } }),
|
||||
new List<UavUploadFile> { new("a.jpg", "image/jpeg", jpeg) });
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeTrue();
|
||||
result.EnvelopeError.Should().Contain("Mismatched batch");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_EmptyMetadata_ReturnsEnvelopeError()
|
||||
{
|
||||
// Arrange
|
||||
var (handler, _) = BuildHandler();
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
metadataJson: "",
|
||||
files: new List<UavUploadFile>());
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task HandleAsync_InvalidMetadataJson_ReturnsEnvelopeError()
|
||||
{
|
||||
// Arrange
|
||||
var (handler, _) = BuildHandler();
|
||||
|
||||
// Act
|
||||
var result = await handler.HandleAsync(
|
||||
metadataJson: "{ not valid json",
|
||||
files: new List<UavUploadFile>());
|
||||
|
||||
// Assert
|
||||
result.EnvelopeRejected.Should().BeTrue();
|
||||
result.EnvelopeError.Should().Contain("Invalid `metadata` JSON");
|
||||
}
|
||||
|
||||
private (UavTileUploadHandler Handler, Mock<ITileRepository> Repo) BuildHandler(UavQualityConfig? quality = null)
|
||||
{
|
||||
var qualityConfig = quality ?? new UavQualityConfig();
|
||||
var mapConfig = new MapConfig { TileSizePixels = 256 };
|
||||
var storageConfig = new StorageConfig { TilesDirectory = _tilesRoot };
|
||||
var time = new FixedTimeProvider(new DateTime(2026, 5, 11, 12, 0, 0, DateTimeKind.Utc));
|
||||
|
||||
var gate = new UavTileQualityGate(
|
||||
Options.Create(qualityConfig),
|
||||
Options.Create(mapConfig),
|
||||
time);
|
||||
|
||||
var repo = new Mock<ITileRepository>();
|
||||
var handler = new UavTileUploadHandler(
|
||||
gate,
|
||||
repo.Object,
|
||||
Options.Create(storageConfig),
|
||||
Options.Create(mapConfig),
|
||||
Options.Create(qualityConfig),
|
||||
NullLogger<UavTileUploadHandler>.Instance,
|
||||
time);
|
||||
|
||||
return (handler, repo);
|
||||
}
|
||||
|
||||
private static UavTileMetadata ValidMetadata() => new()
|
||||
{
|
||||
Latitude = 47.461747,
|
||||
Longitude = 37.647063,
|
||||
TileZoom = 18,
|
||||
TileSizeMeters = 200.0,
|
||||
CapturedAt = new DateTime(2026, 5, 11, 11, 30, 0, DateTimeKind.Utc),
|
||||
};
|
||||
|
||||
private sealed class FixedTimeProvider : TimeProvider
|
||||
{
|
||||
private readonly DateTime _utcNow;
|
||||
public FixedTimeProvider(DateTime utcNow) => _utcNow = utcNow;
|
||||
public override DateTimeOffset GetUtcNow() => new(_utcNow, TimeSpan.Zero);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user