azaion/satellite-provider
1
0
Fork 0
mirror of https://github.com/azaion/satellite-provider.git synced 2026-06-22 14:21:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AZ-371] Refactor C18: magic numbers to ProcessingConfig/MapConfig

Browse Source 
Promotes 8 operational levers into config keys with defaults that match
the prior source literals byte-for-byte:
  ProcessingConfig: RegionProcessingTimeoutSeconds (300),
  RouteProcessingPollIntervalSeconds (5),
  MaxRoutePointSpacingMeters (200), LatLonTolerance (0.0001).
  MapConfig: TileSizePixels (256), AllowedZoomLevels ([15..19]),
  RetryBaseDelaySeconds (1), RetryMaxDelaySeconds (30).

Sites updated: RegionService, RouteProcessingService,
RoutePointGraphBuilder, RouteValidator, RouteService 4-arg ctor,
RouteImageRenderer, GoogleMapsDownloaderV2, TileService. Closes LF-2 by
forwarding HttpContext.RequestAborted from GetTileByLatLon into the
downloader. appsettings.json gains the 8 new keys at default values.

Tests: 141 / 141 unit + 5 / 5 smoke green. New ConfigDefaultsTests pins
defaults to original literals; new TileService unit test asserts CT
identity from caller to downloader (AZ-371 AC-3).

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
2026-05-11 03:30:07 +03:00
parent ee42b1716b
commit 1dcd089d39
21 changed files with 404 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SatelliteProvider.Tests/RouteValidatorTests.cs
+15 -10
View File
@@ -1,4 +1,6 @@
using FluentAssertions;
using Microsoft.Extensions.Options;
using SatelliteProvider.Common.Configs;
using SatelliteProvider.Common.DTO;
using SatelliteProvider.Services.RouteManagement;
using SatelliteProvider.Tests.Fixtures;
@@ -7,6 +9,9 @@ namespace SatelliteProvider.Tests;
public class RouteValidatorTests
{
private static RouteValidator MakeValidator() =>
new(Options.Create(new ProcessingConfig()));
private static CreateRouteRequest BuildValidRequest()
{
return new CreateRouteRequest
@@ -25,7 +30,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_ValidRequest_DoesNotThrow_AZ365_AC2()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
Action act = () => sut.Validate(request);
@@ -36,7 +41,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_FewerThanTwoPoints_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Points = new List<RoutePoint> { new() { Latitude = 47.46, Longitude = 37.64 } };
@@ -48,7 +53,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_RegionSizeOutOfRange_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.RegionSizeMeters = 50;
@@ -61,7 +66,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_BlankName_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Name = " ";
@@ -73,7 +78,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_GeofencePolygonZeroZero_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Geofences = new Geofences
{
@@ -92,7 +97,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_GeofenceInvertedLatitudes_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Geofences = new Geofences
{
@@ -114,7 +119,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_NullPolygonCorner_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Geofences = new Geofences
{
@@ -133,7 +138,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_OutOfRangeLatitude_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Geofences = new Geofences
{
@@ -156,7 +161,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_MultipleErrors_AggregatesIntoSingleException_AZ365_AC2()
{
var sut = new RouteValidator();
var sut = MakeValidator();
var request = BuildValidRequest();
request.Name = "";
request.RegionSizeMeters = 50;
@@ -175,7 +180,7 @@ public class RouteValidatorTests
[Fact]
public void Validate_NullRequest_Throws()
{
var sut = new RouteValidator();
var sut = MakeValidator();
Action act = () => sut.Validate(null!);