azaion/satellite-provider
1
0
Fork 0
mirror of https://github.com/azaion/satellite-provider.git synced 2026-06-26 07:21:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AZ-1074] [AZ-1075] gRPC tile stream tests and shared proto
ci/woodpecker/push/01-test Pipeline failed
Details
ci/woodpecker/push/02-build-push unknown status
Details

Browse Source 
Extract tile_provision.proto into GrpcContracts, add integration
tests and validation hardening for DeliverRouteTiles streaming.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
2026-06-25 10:04:41 +03:00
parent 275ee1b554
commit 7633134a8a
20 changed files with 725 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_docs/03_implementation/reviews/batch_01_cycle9_review.md
+22
View File
@@ -0,0 +1,22 @@
# Code Review — Batch 01 Cycle 9
**Tasks**: AZ-1074, AZ-1075
**Verdict**: PASS_WITH_WARNINGS
**Date**: 2026-06-25
## Findings
| Severity | Category | Location | Description | Suggestion |
|----------|----------|----------|-------------|------------|
| Low | Maintainability | SatelliteProvider.IntegrationTests/Dockerfile | `linux/amd64` platform pin required on arm64 hosts for protoc stability | Document in batch report / README troubleshooting |
| Low | Style | RouteTileDeliveryOrchestrator.cs | InvalidArgument detail strings include `(Parameter 'job')` suffix from ArgumentException | Optional: strip parameter name for cleaner gRPC detail |
## Spec Compliance
- AZ-1074: DeliverRouteTiles streaming, validation, InvalidArgument mapping — satisfied (unit + integration).
- AZ-1075: Happy path, invalid requests, backpressure/SHA256, REST vs gRPC overlap — satisfied (smoke integration run passed).
## Security
- No new auth bypass; gRPC inherits JWT from existing API setup.
- No secrets in source.