azaion/satellite-provider
1
0
Fork 0
mirror of https://github.com/azaion/satellite-provider.git synced 2026-06-22 18:21:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AZ-375] [AZ-377] HashSet tile lookup + consolidate Earth constants
ci/woodpecker/push/01-test Pipeline was successful
Details
ci/woodpecker/push/02-build-push Pipeline was successful
Details

Browse Source 
Batch 24 of 03-code-quality-refactoring run; closes the run.

AZ-375 (C22): GoogleMapsDownloaderV2.DownloadTilesGridAsync now
builds a HashSet<(int X, int Y, int Z)> once from existingTiles
and tests Contains((x, y, zoomLevel)) per cell. Removes the per-cell
FirstOrDefault tolerance scan and the unused _processingConfig
.LatLonTolerance reference at this site.

AZ-377 (C24): promote Earth + tile-pixel constants to a single
home. GeoUtils now exposes EarthRadiusMeters, EarthEquatorial
CircumferenceMeters, MetersPerDegreeLatitude as public const.
MapConfig adds DefaultTileSizePixels (const) wired as the
TileSizePixels property default. TileRepository and Google
MapsDownloaderV2 read those constants instead of duplicating
the literals 6378137, 40075016.686, 111000.0, and 256.

Tests: +6 new (DownloaderRefactorTests, extended GeoUtils
RefactorTests). 200/200 unit tests pass.

Cumulative K=3 review (batches 22-24): PASS_WITH_WARNINGS,
4 Low findings only — see
_docs/03_implementation/reviews/cumulative_review_22-24.md.

Tooling fix: scripts/run-tests.sh --unit-only path now restores
before testing (was failing on SixLabors resolution in clean
container). Stripped stray BOM from MapConfig.cs to satisfy the
.editorconfig charset gate.

Updates _dependencies_table.md to reflect all 27 03-code-quality-
refactoring tasks done; updates _autodev_state.md to refactor
phase 5 (test-sync).

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
2026-05-11 05:14:51 +03:00
parent 6099d1c86b
commit 9a53bff92e
13 changed files with 456 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SatelliteProvider.Services.TileDownloader/GoogleMapsDownloaderV2.cs
+11 -11
View File
@@ -138,10 +138,9 @@ public class GoogleMapsDownloaderV2 : ISatelliteDownloader
private double CalculateTileSizeInMeters(int zoomLevel, double latitude)
{
const double EARTH_CIRCUMFERENCE_METERS = 40075016.686;
var tileSizePixels = _mapConfig.TileSizePixels;
var latRad = latitude * Math.PI / 180.0;
var metersPerPixel = (EARTH_CIRCUMFERENCE_METERS * Math.Cos(latRad)) / (Math.Pow(2, zoomLevel) * tileSizePixels);
var metersPerPixel = (GeoUtils.EarthEquatorialCircumferenceMeters * Math.Cos(latRad)) / (Math.Pow(2, zoomLevel) * tileSizePixels);
return metersPerPixel * tileSizePixels;
}
@@ -239,6 +238,14 @@ public class GoogleMapsDownloaderV2 : ISatelliteDownloader
var (xMin, yMin) = GeoUtils.WorldToTilePos(new GeoPoint(latMax, lonMin), zoomLevel);
var (xMax, yMax) = GeoUtils.WorldToTilePos(new GeoPoint(latMin, lonMax), zoomLevel);
var existingTileKeys = new HashSet<(int X, int Y, int Z)>();
foreach (var t in existingTiles)
{
if (t.TileZoom != zoomLevel) continue;
var (etx, ety) = GeoUtils.WorldToTilePos(new GeoPoint(t.Latitude, t.Longitude), t.TileZoom);
existingTileKeys.Add((etx, ety, t.TileZoom));
}
var tilesToDownload = new List<(int x, int y, GeoPoint center, double tileSizeMeters)>();
int skippedCount = 0;
@@ -246,20 +253,13 @@ public class GoogleMapsDownloaderV2 : ISatelliteDownloader
{
for (var x = xMin; x <= xMax; x++)
{
var tileCenter = GeoUtils.TileToWorldPos(x, y, zoomLevel);
var tolerance = _processingConfig.LatLonTolerance;
var existingTile = existingTiles.FirstOrDefault(t =>
Math.Abs(t.Latitude - tileCenter.Lat) < tolerance &&
Math.Abs(t.Longitude - tileCenter.Lon) < tolerance &&
t.TileZoom == zoomLevel);
if (existingTile != null)
if (existingTileKeys.Contains((x, y, zoomLevel)))
{
skippedCount++;
continue;
}
var tileCenter = GeoUtils.TileToWorldPos(x, y, zoomLevel);
var tileSizeMeters = CalculateTileSizeInMeters(zoomLevel, tileCenter.Lat);
tilesToDownload.Add((x, y, tileCenter, tileSizeMeters));
}