mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-22 20:21:14 +00:00
[AZ-286] [AZ-287] [AZ-288] Service-level unit tests (mocked deps)
Batch 2: 27 new tests, 31/31 total passing.
AZ-286 TileService (9 tests):
- BT-01 download stores tiles via repository
- BT-02 cache reuse passes existing tiles to downloader
- BT-02b stale-version cached tiles are NOT treated as still-valid
- BT-N02 GoogleMapsDownloaderV2 rejects zoom levels not in {15..19}
- GetTileAsync known/unknown id
AZ-287 RegionService (6 tests):
- AC-1 RequestRegionAsync inserts entity and queues request
- AC-2/AC-3 ProcessRegionAsync transitions queued→processing→completed
and writes CSV + summary files
- AC-4 stitch path is set when stitchTiles=true
- ProcessRegionAsync handles RateLimitException by writing failed
summary with the error message preserved
- GetRegionStatusAsync mapping
- Missing region id is logged and short-circuits without DB writes
AZ-288 RouteService (12 tests):
- AC-1 every consecutive pair is ≤200m apart on 2-point route
- AC-2 first/last user points keep their roles; middles are interpolated
- BT-10 10pt route → 1 start, 1 end, 8 action, plus intermediates
- BT-12 20pt route → 1 start, 1 end, 18 action
- AC-3 TotalDistanceMeters == Σ Haversine(point[i-1], point[i])
- BT-N03 < 2 points throws ArgumentException
- regionSize <100 / >10000 throws ArgumentException
- BT-N04 (0,0) corner throws
- BT-N05 inverted NW.lat <= SE.lat throws
- BT-11 valid geofence creates region requests + links them with
isGeofence=true
- BT-07 GetRouteAsync returns route + points
- GetRouteAsync unknown id returns null
Code review: PASS_WITH_WARNINGS — 3 Low Spec-Gap findings:
1. BT-N01 (invalid coords) deferred to AZ-289 integration tests
(TileService doesn't validate coordinates — API-layer concern)
2. Point-type label drift between blackbox-tests.md ("original")
and code ("start"/"action"/"end")
3. Region status drift: spec "pending" vs code "queued" — initial
state on insert
Verification: docker dotnet test — 31/31 pass in 0.83s.
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
@@ -0,0 +1,281 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Moq;
|
||||
using SatelliteProvider.Common.Configs;
|
||||
using SatelliteProvider.Common.DTO;
|
||||
using SatelliteProvider.Common.Interfaces;
|
||||
using SatelliteProvider.DataAccess.Models;
|
||||
using SatelliteProvider.DataAccess.Repositories;
|
||||
using SatelliteProvider.Services;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class RegionServiceTests : IDisposable
|
||||
{
|
||||
private readonly string _readyDir;
|
||||
|
||||
public RegionServiceTests()
|
||||
{
|
||||
_readyDir = Path.Combine(Path.GetTempPath(), "sp-region-tests-" + Guid.NewGuid().ToString("N"));
|
||||
Directory.CreateDirectory(_readyDir);
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
if (Directory.Exists(_readyDir))
|
||||
{
|
||||
Directory.Delete(_readyDir, recursive: true);
|
||||
}
|
||||
}
|
||||
|
||||
private RegionService BuildService(
|
||||
Mock<IRegionRepository> regionRepo,
|
||||
Mock<IRegionRequestQueue> queue,
|
||||
Mock<ITileService> tileService)
|
||||
{
|
||||
var storage = Options.Create(new StorageConfig { ReadyDirectory = _readyDir, TilesDirectory = "/tiles" });
|
||||
return new RegionService(regionRepo.Object, queue.Object, tileService.Object, storage, NullLogger<RegionService>.Instance);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RequestRegionAsync_InsertsEntityAndQueues_BT03_AC1()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
var queue = new Mock<IRegionRequestQueue>();
|
||||
var tileService = new Mock<ITileService>();
|
||||
var service = BuildService(regionRepo, queue, tileService);
|
||||
|
||||
var id = Guid.NewGuid();
|
||||
|
||||
// Act
|
||||
var status = await service.RequestRegionAsync(id, 47.461747, 37.647063, 200, 18);
|
||||
|
||||
// Assert
|
||||
status.Id.Should().Be(id);
|
||||
status.Status.Should().Be("queued");
|
||||
regionRepo.Verify(r => r.InsertAsync(It.Is<RegionEntity>(re =>
|
||||
re.Id == id &&
|
||||
re.Status == "queued" &&
|
||||
re.SizeMeters == 200 &&
|
||||
re.ZoomLevel == 18)), Times.Once);
|
||||
queue.Verify(q => q.EnqueueAsync(It.Is<RegionRequest>(rr =>
|
||||
rr.Id == id &&
|
||||
rr.SizeMeters == 200 &&
|
||||
rr.ZoomLevel == 18 &&
|
||||
rr.StitchTiles == false), It.IsAny<CancellationToken>()), Times.Once);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ProcessRegionAsync_HappyPath_TransitionsToCompletedAndWritesArtifacts_BT03_AC2_AC3()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
var queue = new Mock<IRegionRequestQueue>();
|
||||
var tileService = new Mock<ITileService>();
|
||||
|
||||
var id = Guid.NewGuid();
|
||||
var entity = new RegionEntity
|
||||
{
|
||||
Id = id,
|
||||
Latitude = 47.461747,
|
||||
Longitude = 37.647063,
|
||||
SizeMeters = 200,
|
||||
ZoomLevel = 18,
|
||||
Status = "queued",
|
||||
StitchTiles = false,
|
||||
CreatedAt = DateTime.UtcNow,
|
||||
UpdatedAt = DateTime.UtcNow,
|
||||
};
|
||||
|
||||
regionRepo.Setup(r => r.GetByIdAsync(id)).ReturnsAsync(entity);
|
||||
|
||||
var capturedStatuses = new List<string>();
|
||||
regionRepo
|
||||
.Setup(r => r.UpdateAsync(It.IsAny<RegionEntity>()))
|
||||
.Callback<RegionEntity>(e => capturedStatuses.Add(e.Status))
|
||||
.ReturnsAsync(1);
|
||||
|
||||
tileService
|
||||
.Setup(t => t.GetTilesByRegionAsync(entity.Latitude, entity.Longitude, entity.SizeMeters, entity.ZoomLevel))
|
||||
.ReturnsAsync(Array.Empty<TileMetadata>());
|
||||
tileService
|
||||
.Setup(t => t.DownloadAndStoreTilesAsync(
|
||||
entity.Latitude, entity.Longitude, entity.SizeMeters, entity.ZoomLevel,
|
||||
It.IsAny<CancellationToken>()))
|
||||
.ReturnsAsync(new List<TileMetadata>
|
||||
{
|
||||
new()
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
Latitude = entity.Latitude,
|
||||
Longitude = entity.Longitude,
|
||||
TileZoom = entity.ZoomLevel,
|
||||
TileSizePixels = 256,
|
||||
ImageType = "jpg",
|
||||
FilePath = "tiles/18/0/0/x.jpg",
|
||||
},
|
||||
});
|
||||
|
||||
var service = BuildService(regionRepo, queue, tileService);
|
||||
|
||||
// Act
|
||||
await service.ProcessRegionAsync(id);
|
||||
|
||||
// Assert
|
||||
capturedStatuses.Should().ContainInOrder("processing", "completed");
|
||||
entity.Status.Should().Be("completed");
|
||||
entity.CsvFilePath.Should().NotBeNullOrEmpty();
|
||||
entity.SummaryFilePath.Should().NotBeNullOrEmpty();
|
||||
entity.TilesDownloaded.Should().Be(1);
|
||||
entity.TilesReused.Should().Be(0);
|
||||
File.Exists(entity.CsvFilePath!).Should().BeTrue("CSV file is written to ReadyDirectory");
|
||||
File.Exists(entity.SummaryFilePath!).Should().BeTrue("summary file is written to ReadyDirectory");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ProcessRegionAsync_MissingRegionId_LogsAndReturns()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
regionRepo.Setup(r => r.GetByIdAsync(It.IsAny<Guid>())).ReturnsAsync((RegionEntity?)null);
|
||||
var service = BuildService(regionRepo, new Mock<IRegionRequestQueue>(), new Mock<ITileService>());
|
||||
|
||||
// Act
|
||||
await service.ProcessRegionAsync(Guid.NewGuid());
|
||||
|
||||
// Assert
|
||||
regionRepo.Verify(r => r.UpdateAsync(It.IsAny<RegionEntity>()), Times.Never);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ProcessRegionAsync_DownloaderFailure_TransitionsToFailedAndWritesErrorSummary()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
var queue = new Mock<IRegionRequestQueue>();
|
||||
var tileService = new Mock<ITileService>();
|
||||
|
||||
var id = Guid.NewGuid();
|
||||
var entity = new RegionEntity
|
||||
{
|
||||
Id = id,
|
||||
Latitude = 47.461747,
|
||||
Longitude = 37.647063,
|
||||
SizeMeters = 200,
|
||||
ZoomLevel = 18,
|
||||
Status = "queued",
|
||||
StitchTiles = false,
|
||||
CreatedAt = DateTime.UtcNow,
|
||||
UpdatedAt = DateTime.UtcNow,
|
||||
};
|
||||
|
||||
regionRepo.Setup(r => r.GetByIdAsync(id)).ReturnsAsync(entity);
|
||||
|
||||
var capturedStatuses = new List<string>();
|
||||
regionRepo
|
||||
.Setup(r => r.UpdateAsync(It.IsAny<RegionEntity>()))
|
||||
.Callback<RegionEntity>(e => capturedStatuses.Add(e.Status))
|
||||
.ReturnsAsync(1);
|
||||
|
||||
tileService
|
||||
.Setup(t => t.GetTilesByRegionAsync(It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>()))
|
||||
.ReturnsAsync(Array.Empty<TileMetadata>());
|
||||
tileService
|
||||
.Setup(t => t.DownloadAndStoreTilesAsync(
|
||||
It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>(),
|
||||
It.IsAny<CancellationToken>()))
|
||||
.ThrowsAsync(new RateLimitException("Google Maps rate limit exceeded"));
|
||||
|
||||
var service = BuildService(regionRepo, queue, tileService);
|
||||
|
||||
// Act
|
||||
await service.ProcessRegionAsync(id);
|
||||
|
||||
// Assert
|
||||
capturedStatuses.Should().ContainInOrder("processing", "failed");
|
||||
entity.Status.Should().Be("failed");
|
||||
entity.SummaryFilePath.Should().NotBeNullOrEmpty();
|
||||
File.Exists(entity.SummaryFilePath!).Should().BeTrue();
|
||||
File.ReadAllText(entity.SummaryFilePath!).Should().Contain("Rate limit exceeded");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task ProcessRegionAsync_StitchEnabled_SetsStitchedImagePath_BT05_AC4()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
var queue = new Mock<IRegionRequestQueue>();
|
||||
var tileService = new Mock<ITileService>();
|
||||
|
||||
var id = Guid.NewGuid();
|
||||
var entity = new RegionEntity
|
||||
{
|
||||
Id = id,
|
||||
Latitude = 47.461747,
|
||||
Longitude = 37.647063,
|
||||
SizeMeters = 500,
|
||||
ZoomLevel = 18,
|
||||
Status = "queued",
|
||||
StitchTiles = true,
|
||||
CreatedAt = DateTime.UtcNow,
|
||||
UpdatedAt = DateTime.UtcNow,
|
||||
};
|
||||
|
||||
regionRepo.Setup(r => r.GetByIdAsync(id)).ReturnsAsync(entity);
|
||||
regionRepo.Setup(r => r.UpdateAsync(It.IsAny<RegionEntity>())).ReturnsAsync(1);
|
||||
|
||||
tileService
|
||||
.Setup(t => t.GetTilesByRegionAsync(It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>()))
|
||||
.ReturnsAsync(Array.Empty<TileMetadata>());
|
||||
tileService
|
||||
.Setup(t => t.DownloadAndStoreTilesAsync(
|
||||
It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>(),
|
||||
It.IsAny<CancellationToken>()))
|
||||
.ReturnsAsync(new List<TileMetadata>
|
||||
{
|
||||
new()
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
Latitude = entity.Latitude,
|
||||
Longitude = entity.Longitude,
|
||||
TileZoom = entity.ZoomLevel,
|
||||
TileSizePixels = 256,
|
||||
ImageType = "jpg",
|
||||
// Path doesn't exist on disk — stitcher will skip but still produce an empty image.
|
||||
FilePath = Path.Combine(_readyDir, "missing.jpg"),
|
||||
},
|
||||
});
|
||||
|
||||
var service = BuildService(regionRepo, queue, tileService);
|
||||
|
||||
// Act
|
||||
await service.ProcessRegionAsync(id);
|
||||
|
||||
// Assert
|
||||
entity.Status.Should().Be("completed");
|
||||
var stitchedPath = Path.Combine(_readyDir, $"region_{id}_stitched.jpg");
|
||||
File.Exists(stitchedPath).Should().BeTrue("stitched image must exist when stitchTiles=true");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetRegionStatusAsync_KnownId_ReturnsMappedStatus()
|
||||
{
|
||||
// Arrange
|
||||
var regionRepo = new Mock<IRegionRepository>();
|
||||
var id = Guid.NewGuid();
|
||||
regionRepo.Setup(r => r.GetByIdAsync(id))
|
||||
.ReturnsAsync(new RegionEntity { Id = id, Status = "completed", TilesDownloaded = 5, TilesReused = 2 });
|
||||
var service = BuildService(regionRepo, new Mock<IRegionRequestQueue>(), new Mock<ITileService>());
|
||||
|
||||
// Act
|
||||
var result = await service.GetRegionStatusAsync(id);
|
||||
|
||||
// Assert
|
||||
result.Should().NotBeNull();
|
||||
result!.Status.Should().Be("completed");
|
||||
result.TilesDownloaded.Should().Be(5);
|
||||
result.TilesReused.Should().Be(2);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,303 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Moq;
|
||||
using SatelliteProvider.Common.DTO;
|
||||
using SatelliteProvider.Common.Interfaces;
|
||||
using SatelliteProvider.Common.Utils;
|
||||
using SatelliteProvider.DataAccess.Models;
|
||||
using SatelliteProvider.DataAccess.Repositories;
|
||||
using SatelliteProvider.Services;
|
||||
using SatelliteProvider.Tests.Fixtures;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class RouteServiceTests
|
||||
{
|
||||
private static RouteService BuildService(
|
||||
Mock<IRouteRepository> routeRepo,
|
||||
Mock<IRegionService> regionService)
|
||||
{
|
||||
return new RouteService(routeRepo.Object, regionService.Object, NullLogger<RouteService>.Instance);
|
||||
}
|
||||
|
||||
private static CreateRouteRequest BuildRequest(IEnumerable<(double Lat, double Lon)> points, double regionSize = 500, int zoom = 18, bool requestMaps = false, Geofences? geofences = null)
|
||||
{
|
||||
return new CreateRouteRequest
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
Name = "test route",
|
||||
Description = "unit test route",
|
||||
RegionSizeMeters = regionSize,
|
||||
ZoomLevel = zoom,
|
||||
Points = points.Select(p => new RoutePoint { Latitude = p.Lat, Longitude = p.Lon }).ToList(),
|
||||
RequestMaps = requestMaps,
|
||||
Geofences = geofences,
|
||||
};
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_TwoPointRoute_GeneratesIntermediatePointsAtMax200mSpacing_BT06_AC1()
|
||||
{
|
||||
// Arrange
|
||||
var routeRepo = new Mock<IRouteRepository>();
|
||||
var regionService = new Mock<IRegionService>();
|
||||
var service = BuildService(routeRepo, regionService);
|
||||
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points, regionSize: 500, zoom: 18);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
result.TotalPoints.Should().BeGreaterThan(2, "intermediate points must be inserted between user-supplied points");
|
||||
result.Points.Should().HaveCount(result.TotalPoints);
|
||||
|
||||
// Spacing AC: every consecutive pair within a segment must be ≤200m apart.
|
||||
for (int i = 1; i < result.Points.Count; i++)
|
||||
{
|
||||
var prev = result.Points[i - 1];
|
||||
var cur = result.Points[i];
|
||||
var distance = GeoUtils.CalculateDistance(
|
||||
new GeoPoint(prev.Latitude, prev.Longitude),
|
||||
new GeoPoint(cur.Latitude, cur.Longitude));
|
||||
distance.Should().BeLessThanOrEqualTo(200.5, $"point {i - 1}→{i} must be ≤200m");
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_TwoPointRoute_FirstAndLastUserPointsKeepTheirRoles_BT06_AC2()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
result.Points.First().PointType.Should().Be("start", "first user-supplied point");
|
||||
result.Points.Last().PointType.Should().Be("end", "last user-supplied point");
|
||||
result.Points.Skip(1).Take(result.Points.Count - 2).Should().OnlyContain(p => p.PointType == "intermediate",
|
||||
"every middle point in a 2-point route is interpolated");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_TenPointRoute_HasOneStartOneEndAndOnlyIntermediatesBetween_BT10()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(TestCoordinates.Route.Route04Points, regionSize: 300);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
result.Points.Count(p => p.PointType == "start").Should().Be(1);
|
||||
result.Points.Count(p => p.PointType == "end").Should().Be(1);
|
||||
result.Points.Count(p => p.PointType == "action").Should().Be(8, "8 middle user-supplied waypoints in a 10-point route");
|
||||
result.Points.Should().Contain(p => p.PointType == "intermediate", "long route always interpolates");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_TwentyPointRoute_HasOneStartOneEndAndEighteenAction_BT12()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(TestCoordinates.Route.Route06Points, regionSize: 300);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
result.Points.Count(p => p.PointType == "start").Should().Be(1);
|
||||
result.Points.Count(p => p.PointType == "end").Should().Be(1);
|
||||
result.Points.Count(p => p.PointType == "action").Should().Be(18, "18 middle user-supplied waypoints in a 20-point route");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_ComputesTotalDistanceViaHaversine_AC3()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert: distance is positive and equals the sum of consecutive spacings ± rounding.
|
||||
result.TotalDistanceMeters.Should().BeGreaterThan(0);
|
||||
|
||||
var summed = 0.0;
|
||||
for (int i = 1; i < result.Points.Count; i++)
|
||||
{
|
||||
var prev = result.Points[i - 1];
|
||||
var cur = result.Points[i];
|
||||
summed += GeoUtils.CalculateDistance(
|
||||
new GeoPoint(prev.Latitude, prev.Longitude),
|
||||
new GeoPoint(cur.Latitude, cur.Longitude));
|
||||
}
|
||||
result.TotalDistanceMeters.Should().BeApproximately(summed, 1.0,
|
||||
"TotalDistanceMeters must equal Σ Haversine(point[i-1], point[i])");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_LessThanTwoPoints_Throws_BTN03_AC4()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(new[] { (47.461747, 37.647063) });
|
||||
|
||||
// Act
|
||||
Func<Task> act = () => service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
await act.Should().ThrowAsync<ArgumentException>()
|
||||
.WithMessage("*at least 2 points*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_InvalidRegionSize_Throws()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points, regionSize: 50);
|
||||
|
||||
// Act
|
||||
Func<Task> act = () => service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
await act.Should().ThrowAsync<ArgumentException>()
|
||||
.WithMessage("*Region size must be between 100 and 10000*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_GeofenceWithZeroZeroCorner_Throws_BTN04()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var geofences = new Geofences
|
||||
{
|
||||
Polygons = new List<GeofencePolygon>
|
||||
{
|
||||
new() { NorthWest = new GeoPoint(0, 0), SouthEast = new GeoPoint(0, 0) },
|
||||
},
|
||||
};
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points, geofences: geofences);
|
||||
|
||||
// Act
|
||||
Func<Task> act = () => service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
await act.Should().ThrowAsync<ArgumentException>()
|
||||
.WithMessage("*coordinates cannot be (0,0)*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_GeofenceWithInvertedCorners_Throws_BTN05()
|
||||
{
|
||||
// Arrange
|
||||
var service = BuildService(new Mock<IRouteRepository>(), new Mock<IRegionService>());
|
||||
var geofences = new Geofences
|
||||
{
|
||||
Polygons = new List<GeofencePolygon>
|
||||
{
|
||||
// northWest.Lat (48.250) <= southEast.Lat (48.280) → invalid
|
||||
new() { NorthWest = new GeoPoint(48.250, 37.370), SouthEast = new GeoPoint(48.280, 37.395) },
|
||||
},
|
||||
};
|
||||
var request = BuildRequest(TestCoordinates.Route.Route01Points, geofences: geofences);
|
||||
|
||||
// Act
|
||||
Func<Task> act = () => service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
await act.Should().ThrowAsync<ArgumentException>()
|
||||
.WithMessage("*northWest latitude*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateRouteAsync_ValidGeofence_QueuesGeofenceRegions_BT11()
|
||||
{
|
||||
// Arrange
|
||||
var routeRepo = new Mock<IRouteRepository>();
|
||||
var regionService = new Mock<IRegionService>();
|
||||
|
||||
regionService
|
||||
.Setup(r => r.RequestRegionAsync(It.IsAny<Guid>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>(), false))
|
||||
.ReturnsAsync(new RegionStatus { Status = "queued" });
|
||||
|
||||
var service = BuildService(routeRepo, regionService);
|
||||
|
||||
var geofences = new Geofences
|
||||
{
|
||||
Polygons = new List<GeofencePolygon>
|
||||
{
|
||||
new() { NorthWest = new GeoPoint(48.280, 37.370), SouthEast = new GeoPoint(48.265, 37.395) },
|
||||
},
|
||||
};
|
||||
var request = BuildRequest(TestCoordinates.Route.Route04Points, regionSize: 300, geofences: geofences);
|
||||
|
||||
// Act
|
||||
var result = await service.CreateRouteAsync(request);
|
||||
|
||||
// Assert
|
||||
result.TotalPoints.Should().BeGreaterThan(0);
|
||||
regionService.Verify(r => r.RequestRegionAsync(
|
||||
It.IsAny<Guid>(), It.IsAny<double>(), It.IsAny<double>(),
|
||||
300, It.IsAny<int>(), false), Times.AtLeastOnce,
|
||||
"geofence creates at least one region request");
|
||||
routeRepo.Verify(r => r.LinkRouteToRegionAsync(
|
||||
request.Id, It.IsAny<Guid>(), true, 0), Times.AtLeastOnce,
|
||||
"geofence regions are linked to the route with isGeofence=true");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetRouteAsync_KnownId_ReturnsRouteWithPoints_BT07()
|
||||
{
|
||||
// Arrange
|
||||
var routeRepo = new Mock<IRouteRepository>();
|
||||
var id = Guid.NewGuid();
|
||||
var routeEntity = new RouteEntity
|
||||
{
|
||||
Id = id,
|
||||
Name = "test",
|
||||
RegionSizeMeters = 500,
|
||||
ZoomLevel = 18,
|
||||
TotalDistanceMeters = 1234,
|
||||
TotalPoints = 4,
|
||||
};
|
||||
routeRepo.Setup(r => r.GetByIdAsync(id)).ReturnsAsync(routeEntity);
|
||||
routeRepo.Setup(r => r.GetRoutePointsAsync(id)).ReturnsAsync(new List<RoutePointEntity>
|
||||
{
|
||||
new() { Id = Guid.NewGuid(), RouteId = id, SequenceNumber = 0, Latitude = 1, Longitude = 2, PointType = "start", SegmentIndex = 0 },
|
||||
new() { Id = Guid.NewGuid(), RouteId = id, SequenceNumber = 1, Latitude = 3, Longitude = 4, PointType = "end", SegmentIndex = 1 },
|
||||
});
|
||||
|
||||
var service = BuildService(routeRepo, new Mock<IRegionService>());
|
||||
|
||||
// Act
|
||||
var result = await service.GetRouteAsync(id);
|
||||
|
||||
// Assert
|
||||
result.Should().NotBeNull();
|
||||
result!.Id.Should().Be(id);
|
||||
result.Points.Should().HaveCount(2);
|
||||
result.Points[0].PointType.Should().Be("start");
|
||||
result.Points[1].PointType.Should().Be("end");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetRouteAsync_UnknownId_ReturnsNull()
|
||||
{
|
||||
// Arrange
|
||||
var routeRepo = new Mock<IRouteRepository>();
|
||||
routeRepo.Setup(r => r.GetByIdAsync(It.IsAny<Guid>())).ReturnsAsync((RouteEntity?)null);
|
||||
var service = BuildService(routeRepo, new Mock<IRegionService>());
|
||||
|
||||
// Act
|
||||
var result = await service.GetRouteAsync(Guid.NewGuid());
|
||||
|
||||
// Assert
|
||||
result.Should().BeNull();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,259 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Moq;
|
||||
using SatelliteProvider.Common.Configs;
|
||||
using SatelliteProvider.Common.DTO;
|
||||
using SatelliteProvider.Common.Interfaces;
|
||||
using SatelliteProvider.DataAccess.Models;
|
||||
using SatelliteProvider.DataAccess.Repositories;
|
||||
using SatelliteProvider.Services;
|
||||
using SatelliteProvider.Tests.Fixtures;
|
||||
|
||||
namespace SatelliteProvider.Tests;
|
||||
|
||||
public class TileServiceTests
|
||||
{
|
||||
private static TileService BuildService(
|
||||
Mock<ISatelliteDownloader> downloader,
|
||||
Mock<ITileRepository> tileRepo)
|
||||
{
|
||||
return new TileService(downloader.Object, tileRepo.Object, NullLogger<TileService>.Instance);
|
||||
}
|
||||
|
||||
private static DownloadedTileInfoV2 MakeDownloaded(int x, int y, int zoom, double lat, double lon, string filePath = "tiles/18/0/0/tile.jpg")
|
||||
{
|
||||
return new DownloadedTileInfoV2(x, y, zoom, lat, lon, filePath, 100.0);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task DownloadAndStoreTilesAsync_NoExistingTiles_StoresAllDownloadedTiles_BT01()
|
||||
{
|
||||
// Arrange
|
||||
var downloader = new Mock<ISatelliteDownloader>();
|
||||
var tileRepo = new Mock<ITileRepository>();
|
||||
|
||||
tileRepo
|
||||
.Setup(r => r.GetTilesByRegionAsync(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, 200, TestCoordinates.DefaultZoom))
|
||||
.ReturnsAsync(Array.Empty<TileEntity>());
|
||||
|
||||
var downloaded = new List<DownloadedTileInfoV2>
|
||||
{
|
||||
MakeDownloaded(123, 456, TestCoordinates.DefaultZoom, TestCoordinates.TileLat, TestCoordinates.TileLon),
|
||||
};
|
||||
downloader
|
||||
.Setup(d => d.GetTilesWithMetadataAsync(
|
||||
It.IsAny<GeoPoint>(),
|
||||
It.IsAny<double>(),
|
||||
TestCoordinates.DefaultZoom,
|
||||
It.Is<IEnumerable<ExistingTileInfo>>(e => !e.Any()),
|
||||
It.IsAny<CancellationToken>()))
|
||||
.ReturnsAsync(downloaded);
|
||||
|
||||
var service = BuildService(downloader, tileRepo);
|
||||
|
||||
// Act
|
||||
var result = await service.DownloadAndStoreTilesAsync(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, 200, TestCoordinates.DefaultZoom);
|
||||
|
||||
// Assert
|
||||
result.Should().HaveCount(1);
|
||||
result[0].TileZoom.Should().Be(TestCoordinates.DefaultZoom);
|
||||
result[0].TileSizePixels.Should().Be(256);
|
||||
result[0].ImageType.Should().Be("jpg");
|
||||
result[0].FilePath.Should().NotBeNullOrEmpty();
|
||||
tileRepo.Verify(r => r.InsertAsync(It.IsAny<TileEntity>()), Times.Once);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task DownloadAndStoreTilesAsync_HasCachedTiles_PassesThemToDownloader_BT02()
|
||||
{
|
||||
// Arrange
|
||||
var downloader = new Mock<ISatelliteDownloader>();
|
||||
var tileRepo = new Mock<ITileRepository>();
|
||||
|
||||
var existing = new List<TileEntity>
|
||||
{
|
||||
new()
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
TileZoom = TestCoordinates.DefaultZoom,
|
||||
Latitude = TestCoordinates.TileLat,
|
||||
Longitude = TestCoordinates.TileLon,
|
||||
Version = DateTime.UtcNow.Year,
|
||||
FilePath = "tiles/18/0/0/cached.jpg",
|
||||
TileSizePixels = 256,
|
||||
ImageType = "jpg",
|
||||
},
|
||||
};
|
||||
tileRepo
|
||||
.Setup(r => r.GetTilesByRegionAsync(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, 200, TestCoordinates.DefaultZoom))
|
||||
.ReturnsAsync(existing);
|
||||
|
||||
IEnumerable<ExistingTileInfo>? capturedExisting = null;
|
||||
downloader
|
||||
.Setup(d => d.GetTilesWithMetadataAsync(
|
||||
It.IsAny<GeoPoint>(),
|
||||
It.IsAny<double>(),
|
||||
TestCoordinates.DefaultZoom,
|
||||
It.IsAny<IEnumerable<ExistingTileInfo>>(),
|
||||
It.IsAny<CancellationToken>()))
|
||||
.Callback<GeoPoint, double, int, IEnumerable<ExistingTileInfo>, CancellationToken>(
|
||||
(_, _, _, e, _) => capturedExisting = e.ToList())
|
||||
.ReturnsAsync(new List<DownloadedTileInfoV2>());
|
||||
|
||||
var service = BuildService(downloader, tileRepo);
|
||||
|
||||
// Act
|
||||
var result = await service.DownloadAndStoreTilesAsync(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, 200, TestCoordinates.DefaultZoom);
|
||||
|
||||
// Assert
|
||||
result.Should().HaveCount(1);
|
||||
result[0].Id.Should().Be(existing[0].Id);
|
||||
capturedExisting.Should().NotBeNull();
|
||||
capturedExisting!.Should().ContainSingle()
|
||||
.Which.Should().BeEquivalentTo(new ExistingTileInfo(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, TestCoordinates.DefaultZoom));
|
||||
tileRepo.Verify(r => r.InsertAsync(It.IsAny<TileEntity>()), Times.Never,
|
||||
"cached tile should not be re-inserted");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task DownloadAndStoreTilesAsync_IgnoresStaleVersionCachedTiles_BT02b()
|
||||
{
|
||||
// Arrange
|
||||
var downloader = new Mock<ISatelliteDownloader>();
|
||||
var tileRepo = new Mock<ITileRepository>();
|
||||
|
||||
var stale = new List<TileEntity>
|
||||
{
|
||||
new()
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
TileZoom = TestCoordinates.DefaultZoom,
|
||||
Latitude = TestCoordinates.TileLat,
|
||||
Longitude = TestCoordinates.TileLon,
|
||||
Version = DateTime.UtcNow.Year - 1,
|
||||
FilePath = "tiles/18/0/0/old.jpg",
|
||||
},
|
||||
};
|
||||
tileRepo
|
||||
.Setup(r => r.GetTilesByRegionAsync(
|
||||
It.IsAny<double>(), It.IsAny<double>(), It.IsAny<double>(), It.IsAny<int>()))
|
||||
.ReturnsAsync(stale);
|
||||
|
||||
IEnumerable<ExistingTileInfo>? capturedExisting = null;
|
||||
downloader
|
||||
.Setup(d => d.GetTilesWithMetadataAsync(
|
||||
It.IsAny<GeoPoint>(),
|
||||
It.IsAny<double>(),
|
||||
It.IsAny<int>(),
|
||||
It.IsAny<IEnumerable<ExistingTileInfo>>(),
|
||||
It.IsAny<CancellationToken>()))
|
||||
.Callback<GeoPoint, double, int, IEnumerable<ExistingTileInfo>, CancellationToken>(
|
||||
(_, _, _, e, _) => capturedExisting = e.ToList())
|
||||
.ReturnsAsync(new List<DownloadedTileInfoV2>
|
||||
{
|
||||
MakeDownloaded(123, 456, TestCoordinates.DefaultZoom, TestCoordinates.TileLat, TestCoordinates.TileLon),
|
||||
});
|
||||
|
||||
var service = BuildService(downloader, tileRepo);
|
||||
|
||||
// Act
|
||||
var result = await service.DownloadAndStoreTilesAsync(
|
||||
TestCoordinates.TileLat, TestCoordinates.TileLon, 200, TestCoordinates.DefaultZoom);
|
||||
|
||||
// Assert
|
||||
capturedExisting.Should().BeEmpty(
|
||||
"stale-version tiles must not be passed to the downloader as 'already have it'");
|
||||
result.Should().HaveCount(1, "only the freshly-downloaded tile is in the result");
|
||||
tileRepo.Verify(r => r.InsertAsync(It.IsAny<TileEntity>()), Times.Once);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetTileAsync_KnownId_ReturnsMappedMetadata()
|
||||
{
|
||||
// Arrange
|
||||
var id = Guid.NewGuid();
|
||||
var entity = new TileEntity
|
||||
{
|
||||
Id = id,
|
||||
TileZoom = 18,
|
||||
Latitude = TestCoordinates.TileLat,
|
||||
Longitude = TestCoordinates.TileLon,
|
||||
TileSizePixels = 256,
|
||||
ImageType = "jpg",
|
||||
FilePath = "tiles/18/0/0/x.jpg",
|
||||
Version = 2026,
|
||||
};
|
||||
var tileRepo = new Mock<ITileRepository>();
|
||||
tileRepo.Setup(r => r.GetByIdAsync(id)).ReturnsAsync(entity);
|
||||
var service = BuildService(new Mock<ISatelliteDownloader>(), tileRepo);
|
||||
|
||||
// Act
|
||||
var result = await service.GetTileAsync(id);
|
||||
|
||||
// Assert
|
||||
result.Should().NotBeNull();
|
||||
result!.Id.Should().Be(id);
|
||||
result.FilePath.Should().Be("tiles/18/0/0/x.jpg");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetTileAsync_UnknownId_ReturnsNull()
|
||||
{
|
||||
// Arrange
|
||||
var tileRepo = new Mock<ITileRepository>();
|
||||
tileRepo.Setup(r => r.GetByIdAsync(It.IsAny<Guid>())).ReturnsAsync((TileEntity?)null);
|
||||
var service = BuildService(new Mock<ISatelliteDownloader>(), tileRepo);
|
||||
|
||||
// Act
|
||||
var result = await service.GetTileAsync(Guid.NewGuid());
|
||||
|
||||
// Assert
|
||||
result.Should().BeNull();
|
||||
}
|
||||
}
|
||||
|
||||
public class GoogleMapsDownloaderZoomValidationTests
|
||||
{
|
||||
private static GoogleMapsDownloaderV2 BuildDownloader()
|
||||
{
|
||||
var mapConfig = Options.Create(new MapConfig { Service = "googlemaps", ApiKey = "test-key" });
|
||||
var storageConfig = Options.Create(new StorageConfig
|
||||
{
|
||||
TilesDirectory = Path.Combine(Path.GetTempPath(), "sp-tests-tiles"),
|
||||
ReadyDirectory = Path.Combine(Path.GetTempPath(), "sp-tests-ready"),
|
||||
});
|
||||
var processingConfig = Options.Create(new ProcessingConfig());
|
||||
var httpClientFactory = new Mock<IHttpClientFactory>().Object;
|
||||
|
||||
return new GoogleMapsDownloaderV2(
|
||||
NullLogger<GoogleMapsDownloaderV2>.Instance,
|
||||
mapConfig,
|
||||
storageConfig,
|
||||
processingConfig,
|
||||
httpClientFactory);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData(25)]
|
||||
[InlineData(14)]
|
||||
[InlineData(0)]
|
||||
[InlineData(-1)]
|
||||
public async Task DownloadSingleTileAsync_RejectsZoomLevelOutsideAllowedRange_BTN02(int invalidZoom)
|
||||
{
|
||||
// Arrange
|
||||
var downloader = BuildDownloader();
|
||||
|
||||
// Act
|
||||
Func<Task> act = () => downloader.DownloadSingleTileAsync(TestCoordinates.TileLat, TestCoordinates.TileLon, invalidZoom);
|
||||
|
||||
// Assert
|
||||
await act.Should().ThrowAsync<ArgumentException>()
|
||||
.Where(ex => ex.ParamName == "zoomLevel" && ex.Message.Contains("not allowed"));
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user