azaion/satellite-provider
1
0
Fork 0
mirror of https://github.com/azaion/satellite-provider.git synced 2026-06-22 22:41:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AZ-365] Refactor C12: decompose RouteService.CreateRouteAsync

Browse Source 
Extract RouteValidator (aggregating validator), RoutePointGraphBuilder
(point interpolation + sequence numbering), GeofenceGridCalculator
(NW/SE region centers), and RouteResponseMapper (entity -> DTO; also
used by GetRouteAsync, eliminating duplicate DTO assembly).

CreateRouteAsync shrinks 184 -> 52 LOC of orchestration. RouteService.cs
shrinks 295 -> 138 LOC overall. Validation aggregates all failures into
a single ArgumentException (AC-2); single-violation messages preserved
verbatim so existing RouteServiceTests pass unchanged. 28 new unit
tests for the four helpers (112/112 unit tests, smoke green).

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
2026-05-11 02:08:21 +03:00
parent d327000fb6
commit f7ad7aa5ab
11 changed files with 936 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files
SatelliteProvider.Services.RouteManagement/GeofenceGridCalculator.cs
+46
View File
@@ -0,0 +1,46 @@
using SatelliteProvider.Common.DTO;
using SatelliteProvider.Common.Utils;
namespace SatelliteProvider.Services.RouteManagement;
public class GeofenceGridCalculator
{
public IReadOnlyList<GeoPoint> GenerateRegions(GeoPoint northWest, GeoPoint southEast, double regionSizeMeters)
{
ArgumentNullException.ThrowIfNull(northWest);
ArgumentNullException.ThrowIfNull(southEast);
if (regionSizeMeters <= 0)
{
throw new ArgumentOutOfRangeException(nameof(regionSizeMeters), "Region size must be positive");
}
var midLon = (northWest.Lon + southEast.Lon) / 2;
var midLat = (northWest.Lat + southEast.Lat) / 2;
var heightMeters = GeoUtils.CalculateDistance(
new GeoPoint(northWest.Lat, midLon),
new GeoPoint(southEast.Lat, midLon));
var widthMeters = GeoUtils.CalculateDistance(
new GeoPoint(midLat, northWest.Lon),
new GeoPoint(midLat, southEast.Lon));
var numLatSteps = Math.Max(1, (int)Math.Ceiling(heightMeters / regionSizeMeters));
var numLonSteps = Math.Max(1, (int)Math.Ceiling(widthMeters / regionSizeMeters));
var latStep = (northWest.Lat - southEast.Lat) / numLatSteps;
var lonStep = (southEast.Lon - northWest.Lon) / numLonSteps;
var regions = new List<GeoPoint>(numLatSteps * numLonSteps);
for (int latIdx = 0; latIdx < numLatSteps; latIdx++)
{
for (int lonIdx = 0; lonIdx < numLonSteps; lonIdx++)
{
var lat = northWest.Lat - (latIdx + 0.5) * latStep;
var lon = northWest.Lon + (lonIdx + 0.5) * lonStep;
regions.Add(new GeoPoint(lat, lon));
}
}
return regions;
}
}