mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-26 15:01:14 +00:00
Oleksandr Bezdieniezhnykh
7633134a8a
Extract tile_provision.proto into GrpcContracts, add integration tests and validation hardening for DeliverRouteTiles streaming. Co-authored-by: Cursor <cursoragent@cursor.com>
1023 B
1023 B
Code Review — Batch 01 Cycle 9
Tasks: AZ-1074, AZ-1075
Verdict: PASS_WITH_WARNINGS
Date: 2026-06-25
Findings
| Severity | Category | Location | Description | Suggestion |
|---|---|---|---|---|
| Low | Maintainability | SatelliteProvider.IntegrationTests/Dockerfile | linux/amd64 platform pin required on arm64 hosts for protoc stability |
Document in batch report / README troubleshooting |
| Low | Style | RouteTileDeliveryOrchestrator.cs | InvalidArgument detail strings include (Parameter 'job') suffix from ArgumentException |
Optional: strip parameter name for cleaner gRPC detail |
Spec Compliance
- AZ-1074: DeliverRouteTiles streaming, validation, InvalidArgument mapping — satisfied (unit + integration).
- AZ-1075: Happy path, invalid requests, backpressure/SHA256, REST vs gRPC overlap — satisfied (smoke integration run passed).
Security
- No new auth bypass; gRPC inherits JWT from existing API setup.
- No secrets in source.