mirror of https://github.com/azaion/satellite-provider.git synced 2026-06-21 12:01:15 +00:00

Files

T

Oleksandr Bezdieniezhnykh e9d6db077c [AZ-484] Fix multi-source tile reads: drop Dapper enum handler

Two integration-test failures uncovered after the initial commit:

1) GetTilesByRegionAsync outer ORDER BY referenced 'updated_at' but
   the inner DISTINCT ON subquery aliased it to 'UpdatedAt' (Postgres
   folds to 'updatedat'). DISTINCT ON already guarantees one row per
   (latitude, longitude, ...) so the third tiebreak was unreachable;
   removed it.

2) Dapper 2.1.35 silently bypasses SqlMapper.TypeHandler<T> for enum
   types during read deserialization (Dapper issue #259). The
   TileSourceTypeHandler worked for writes but reads fell through to
   Enum.TryParse, which cannot map 'google_maps' to GoogleMaps.

   Pivoted: TileEntity.Source is now a string (the wire value).
   TileSource enum stays as the public producer surface in
   Common.Enums; TileSourceConverter (Common.Enums) provides
   ToWireValue / FromWireValue / IsValidWireValue at the boundary.
   TileSourceTypeHandler deleted; registration removed from
   DapperEnumTypeHandlers.RegisterAll.

   tile-storage.md Inv-5 amended to document the storage choice.
   _docs/LESSONS.md L-001 records the Dapper bypass for future cycles.

Full suite passes (213 unit + integration suite incl. AZ-484
AC-1..AC-5, security SEC-01..SEC-04, AZ-356/362/357).

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-05-11 06:44:34 +03:00

3.7 KiB

Raw Blame History

Product Implementation Completeness Gate — cycle 1

Date: 2026-05-11 Cycle: 1 Tasks evaluated: AZ-484 Verdict: PASS

Per-Task Classification

AZ-484 — Multi-source tile storage schema (source + captured_at) — PASS

Evidence checked:

Promise from spec	Production evidence
Migration 013 transactional, with column adds, backfill, index swap	`SatelliteProvider.DataAccess/Migrations/013_AddTileSourceAndCapturedAt.sql` (BEGIN/COMMIT, ALTER ADD COLUMN, UPDATE backfill, ALTER SET NOT NULL, DROP INDEX, CREATE UNIQUE INDEX)
`TileSource` enum in Common.Enums	`SatelliteProvider.Common/Enums/TileSource.cs` (`{ GoogleMaps, Uav }`)
`TileEntity` exposes `Source` + `CapturedAt`	`SatelliteProvider.DataAccess/Models/TileEntity.cs`
Repository read selection is most-recent across sources, deterministic	`TileRepository.GetByTileCoordinatesAsync` + `GetTilesByRegionAsync` (DISTINCT ON with `(captured_at DESC, updated_at DESC, id DESC)` tie-break)
Per-source UPSERT semantics on insert	`TileRepository.InsertAsync` (`ON CONFLICT (latitude, longitude, tile_zoom, tile_size_meters, source) DO UPDATE`)
`UpdateAsync` includes the new fields	`TileRepository.UpdateAsync` SET clause
Google Maps download path stamps `Source` + `CapturedAt`	`TileService.BuildTileEntity`
Snake_case wire format for `TileSource`	`SatelliteProvider.Common.Enums.TileSourceConverter` (`ToWireValue` / `FromWireValue` / `IsValidWireValue`). `TileEntity.Source` stores the wire string directly because Dapper bypasses `TypeHandler<T>` for enum reads — see `_docs/LESSONS.md` L-001.
Architecture Vision amended	`_docs/02_document/architecture.md` (Architecture Vision principles + System Context)
Glossary amended	`_docs/02_document/glossary.md` (`Tile Source`, `Captured At`; Layer 1 / Layer 2 disambiguation)
Module-layout amended	`_docs/02_document/module-layout.md` (Common Public API list)
Contract `tile-storage.md` v1.0.0 frozen	`_docs/02_document/contracts/data-access/tile-storage.md` Status: `frozen`

Unresolved markers (TODO, placeholder, NotImplemented, etc.) under owned files (SatelliteProvider.Common/Enums/TileSource.cs, SatelliteProvider.Common/Enums/TileSourceConverter.cs, SatelliteProvider.DataAccess/Migrations/013_AddTileSourceAndCapturedAt.sql, SatelliteProvider.DataAccess/Models/TileEntity.cs, SatelliteProvider.DataAccess/Repositories/TileRepository.cs, SatelliteProvider.Services.TileDownloader/TileService.cs): none found.

Named runtime dependencies: AZ-484 introduces no new external dependency. It uses the existing Dapper / Npgsql / DbUp stack already integrated. TileSourceConverter is a pure helper with no DI registration required. The deleted TileSourceTypeHandler registration was removed from DapperEnumTypeHandlers.RegisterAll after the Dapper-enum-bypass discovery (see L-001).

Internal vs external: every promised capability is an internal product capability and is implemented in production code. No promise is blocked on an external prerequisite. The deferred AZ-485 (UAV upload endpoint) is explicitly out of scope for this task.

Tests exercise real implementation path:

Unit: BuildTileEntity_SetsGoogleMapsSourceAndUtcCapturedAt_AZ484_AC5 calls the real TileService.DownloadAndStoreSingleTileAsync path.
Integration (migration): the AC-1..AC-4 tests run against the real Postgres container, asserting the live schema (5-column unique index, dropped legacy 4-column index) and the SQL semantics of the repository methods.

Cycle Verdict

All product tasks (1/1) classified PASS. Proceeding to Final Test Run handoff (autodev Step 11).

Remediation Tasks Created

None.

3.7 KiB Raw Blame History