mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 13:51:14 +00:00
Oleksandr Bezdieniezhnykh
5e056b2334
Third concrete child of AZ-795 (cycle 8 batch 3). FluentValidation +
[JsonRequired] + UnmappedMemberHandling.Disallow combine to reject every
malformed payload at the API boundary with RFC 7807 ValidationProblemDetails.
Validators (SatelliteProvider.Api/Validators/, all new)
- CreateRouteRequestValidator: id non-empty, name/description length,
regionSizeMeters/zoomLevel ranges, points count [2, 500], cross-field
createTilesZip => requestMaps. Chains RoutePointValidator (per-point)
and GeofencePolygonValidator (per-polygon, guarded by When(Geofences != null)).
OverridePropertyName("geofences.polygons") on the geofences chain so
FluentValidation's default leaf-only key policy doesn't drop the parent
path on deep expressions like req.Geofences!.Polygons.
- RoutePointValidator: lat/lon ranges; OverridePropertyName("lat"/"lon")
chained AFTER InclusiveBetween (the extension is defined on
IRuleBuilderOptions<T, TProperty>, so the generic type is only
inferable after the first concrete rule) so error keys match the
wire format (`points[i].lat`) rather than the C# property name
(`points[i].latitude`).
- GeofencePolygonValidator: per-corner range checks via private nested
GeoCornerValidator; cross-field NW.Lat > SE.Lat and NW.Lon < SE.Lon
invariants emit at errors["geofences.polygons[i].northWest"].
DTOs (SatelliteProvider.Common/DTO/, [JsonRequired] additions only)
- CreateRouteRequest: id, name, regionSizeMeters, zoomLevel, points,
requestMaps, createTilesZip
- RoutePoint: Latitude, Longitude
- GeofencePolygon: NorthWest, SouthEast; Geofences: Polygons
- GeoPoint: Lat, Lon
Tests
- Unit: 26 methods total — 16 in CreateRouteRequestValidatorTests, 6 in
GeofencePolygonValidatorTests, 4 in RoutePointValidatorTests. Each
RuleFor/RuleForEach chain has at least one positive + one negative case.
- Integration: CreateRouteValidationTests.cs — 16 methods (happy + 15
failure modes) wired into smoke + full suites. Covers empty body,
missing/zero id, empty name, out-of-range regionSizeMeters/zoomLevel,
points count < 2, per-point lat/lon out-of-range, geofence invariants,
missing requestMaps, cross-field createTilesZip, unknown root field,
nested type mismatch.
- Manual probe: scripts/probe_route_validation.sh curl-exercises every
failure mode end-to-end + happy path.
Docs
- New contract _docs/02_document/contracts/api/route-creation.md v1.0.0
with nested DTO chain, invariants, per-field test cases table, and
advisories on the legacy service-layer RouteValidator + the
input/output RoutePoint vs RoutePointDto naming asymmetry.
- system-flows.md F4 sequence diagram extended with the validation-filter
branch; preconditions + error scenarios reference the new contract.
- modules/api_program.md: CreateRoute handler section added; Api/Validators
bumped to AZ-808/AZ-809/AZ-811.
- modules/common_dtos.md: DTO descriptions updated with [JsonRequired]
annotations and constraint summaries.
- tests/blackbox-tests.md BT-06/BT-N03/BT-N04/BT-N05 align with the new
wire format and named error keys.
- tests/security-tests.md SEC-04 references GlobalExceptionHandler's
JsonException branch + AZ-353 correlationId.
- _docs/03_implementation/batch_03_cycle8_report.md + reviews/batch_03_cycle8_review.md
(PASS_WITH_NOTES — F1 Low: OverridePropertyName documented inline,
F2 + F3 Info: pre-existing advisories for follow-up).
Smoke green (mode=smoke, exit 0). AZ-809 transitioned to In Testing on Jira.
Task file moved to _docs/02_tasks/done/.
Co-authored-by: Cursor <cursoragent@cursor.com>
87 lines
2.3 KiB
C#
87 lines
2.3 KiB
C#
using FluentValidation.TestHelper;
|
|
using SatelliteProvider.Api.Validators;
|
|
using SatelliteProvider.Common.DTO;
|
|
|
|
namespace SatelliteProvider.Tests.Validators;
|
|
|
|
// AZ-809: unit tests for RoutePointValidator. Lat/lon range checks live on
|
|
// `RoutePoint.Latitude` / `RoutePoint.Longitude` (C# names); the validator's
|
|
// OverridePropertyName aligns FluentValidation error keys with the wire
|
|
// format (`lat` / `lon`) so callers see what they posted.
|
|
public class RoutePointValidatorTests
|
|
{
|
|
private readonly RoutePointValidator _validator;
|
|
|
|
public RoutePointValidatorTests()
|
|
{
|
|
GlobalValidatorConfig.ApplyOnce();
|
|
_validator = new RoutePointValidator();
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-90.001)]
|
|
[InlineData(90.001)]
|
|
[InlineData(180.0)]
|
|
public void Validate_LatOutOfRange_FailsRangeRule(double lat)
|
|
{
|
|
// Arrange
|
|
var point = new RoutePoint { Latitude = lat, Longitude = 37.647063 };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(point);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("lat");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-90.0)]
|
|
[InlineData(0.0)]
|
|
[InlineData(47.461747)]
|
|
[InlineData(90.0)]
|
|
public void Validate_LatAtOrInsideBounds_Passes(double lat)
|
|
{
|
|
// Arrange
|
|
var point = new RoutePoint { Latitude = lat, Longitude = 37.647063 };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(point);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("lat");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-180.001)]
|
|
[InlineData(180.001)]
|
|
[InlineData(360.0)]
|
|
public void Validate_LonOutOfRange_FailsRangeRule(double lon)
|
|
{
|
|
// Arrange
|
|
var point = new RoutePoint { Latitude = 47.461747, Longitude = lon };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(point);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("lon");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-180.0)]
|
|
[InlineData(0.0)]
|
|
[InlineData(37.647063)]
|
|
[InlineData(180.0)]
|
|
public void Validate_LonAtOrInsideBounds_Passes(double lon)
|
|
{
|
|
// Arrange
|
|
var point = new RoutePoint { Latitude = 47.461747, Longitude = lon };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(point);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("lon");
|
|
}
|
|
}
|