mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 06:51:13 +00:00
5e056b2334
Third concrete child of AZ-795 (cycle 8 batch 3). FluentValidation +
[JsonRequired] + UnmappedMemberHandling.Disallow combine to reject every
malformed payload at the API boundary with RFC 7807 ValidationProblemDetails.
Validators (SatelliteProvider.Api/Validators/, all new)
- CreateRouteRequestValidator: id non-empty, name/description length,
regionSizeMeters/zoomLevel ranges, points count [2, 500], cross-field
createTilesZip => requestMaps. Chains RoutePointValidator (per-point)
and GeofencePolygonValidator (per-polygon, guarded by When(Geofences != null)).
OverridePropertyName("geofences.polygons") on the geofences chain so
FluentValidation's default leaf-only key policy doesn't drop the parent
path on deep expressions like req.Geofences!.Polygons.
- RoutePointValidator: lat/lon ranges; OverridePropertyName("lat"/"lon")
chained AFTER InclusiveBetween (the extension is defined on
IRuleBuilderOptions<T, TProperty>, so the generic type is only
inferable after the first concrete rule) so error keys match the
wire format (`points[i].lat`) rather than the C# property name
(`points[i].latitude`).
- GeofencePolygonValidator: per-corner range checks via private nested
GeoCornerValidator; cross-field NW.Lat > SE.Lat and NW.Lon < SE.Lon
invariants emit at errors["geofences.polygons[i].northWest"].
DTOs (SatelliteProvider.Common/DTO/, [JsonRequired] additions only)
- CreateRouteRequest: id, name, regionSizeMeters, zoomLevel, points,
requestMaps, createTilesZip
- RoutePoint: Latitude, Longitude
- GeofencePolygon: NorthWest, SouthEast; Geofences: Polygons
- GeoPoint: Lat, Lon
Tests
- Unit: 26 methods total — 16 in CreateRouteRequestValidatorTests, 6 in
GeofencePolygonValidatorTests, 4 in RoutePointValidatorTests. Each
RuleFor/RuleForEach chain has at least one positive + one negative case.
- Integration: CreateRouteValidationTests.cs — 16 methods (happy + 15
failure modes) wired into smoke + full suites. Covers empty body,
missing/zero id, empty name, out-of-range regionSizeMeters/zoomLevel,
points count < 2, per-point lat/lon out-of-range, geofence invariants,
missing requestMaps, cross-field createTilesZip, unknown root field,
nested type mismatch.
- Manual probe: scripts/probe_route_validation.sh curl-exercises every
failure mode end-to-end + happy path.
Docs
- New contract _docs/02_document/contracts/api/route-creation.md v1.0.0
with nested DTO chain, invariants, per-field test cases table, and
advisories on the legacy service-layer RouteValidator + the
input/output RoutePoint vs RoutePointDto naming asymmetry.
- system-flows.md F4 sequence diagram extended with the validation-filter
branch; preconditions + error scenarios reference the new contract.
- modules/api_program.md: CreateRoute handler section added; Api/Validators
bumped to AZ-808/AZ-809/AZ-811.
- modules/common_dtos.md: DTO descriptions updated with [JsonRequired]
annotations and constraint summaries.
- tests/blackbox-tests.md BT-06/BT-N03/BT-N04/BT-N05 align with the new
wire format and named error keys.
- tests/security-tests.md SEC-04 references GlobalExceptionHandler's
JsonException branch + AZ-353 correlationId.
- _docs/03_implementation/batch_03_cycle8_report.md + reviews/batch_03_cycle8_review.md
(PASS_WITH_NOTES — F1 Low: OverridePropertyName documented inline,
F2 + F3 Info: pre-existing advisories for follow-up).
Smoke green (mode=smoke, exit 0). AZ-809 transitioned to In Testing on Jira.
Task file moved to _docs/02_tasks/done/.
Co-authored-by: Cursor <cursoragent@cursor.com>
202 lines
8.1 KiB
C#
202 lines
8.1 KiB
C#
using SatelliteProvider.TestSupport;
|
|
|
|
namespace SatelliteProvider.IntegrationTests;
|
|
|
|
class Program
|
|
{
|
|
static async Task<int> Main(string[] args)
|
|
{
|
|
// AZ-492: perf-harness bootstrap subcommands short-circuit before any
|
|
// HTTP / DB setup so they can be invoked from scripts/run-performance-tests.sh
|
|
// on a host that only has the .NET SDK installed.
|
|
if (args.Length > 0)
|
|
{
|
|
if (args[0].Equals("--mint-only", StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
return PerfBootstrap.MintToken();
|
|
}
|
|
if (args[0].Equals("--gen-uav-fixture", StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
return PerfBootstrap.GenerateUavFixture(args);
|
|
}
|
|
}
|
|
|
|
var apiUrl = Environment.GetEnvironmentVariable("API_URL") ?? "https://api:8080";
|
|
var modeEnv = Environment.GetEnvironmentVariable("INTEGRATION_TESTS_MODE")?.Trim().ToLowerInvariant();
|
|
var modeArg = args.FirstOrDefault(a => a.Equals("--smoke", StringComparison.OrdinalIgnoreCase) || a.Equals("--full", StringComparison.OrdinalIgnoreCase));
|
|
|
|
if (modeArg != null)
|
|
{
|
|
TestRunMode.Smoke = modeArg.Equals("--smoke", StringComparison.OrdinalIgnoreCase);
|
|
}
|
|
else if (!string.IsNullOrEmpty(modeEnv))
|
|
{
|
|
TestRunMode.Smoke = modeEnv == "smoke";
|
|
}
|
|
|
|
// AZ-493: opt-out of the startup DB reset so a developer can inspect leftover state.
|
|
var keepStateEnv = Environment.GetEnvironmentVariable("INTEGRATION_KEEP_STATE")?.Trim();
|
|
var keepState = args.Any(a => a.Equals("--keep-state", StringComparison.OrdinalIgnoreCase))
|
|
|| string.Equals(keepStateEnv, "1", StringComparison.Ordinal)
|
|
|| string.Equals(keepStateEnv, "true", StringComparison.OrdinalIgnoreCase);
|
|
|
|
var connectionString = Environment.GetEnvironmentVariable("DB_CONNECTION_STRING")
|
|
?? "Host=postgres;Port=5432;Database=satelliteprovider;Username=postgres;Password=postgres";
|
|
|
|
string jwtSecret;
|
|
string jwtIssuer;
|
|
string jwtAudience;
|
|
try
|
|
{
|
|
jwtSecret = JwtTestHelpers.ResolveSecretOrThrow();
|
|
jwtIssuer = JwtTestHelpers.ResolveIssuerOrThrow();
|
|
jwtAudience = JwtTestHelpers.ResolveAudienceOrThrow();
|
|
}
|
|
catch (InvalidOperationException ex)
|
|
{
|
|
Console.WriteLine("❌ Integration tests cannot start: JWT configuration is incomplete.");
|
|
Console.WriteLine($" {ex.Message}");
|
|
return 1;
|
|
}
|
|
|
|
Console.WriteLine("Starting Integration Tests");
|
|
Console.WriteLine("=========================");
|
|
Console.WriteLine($"API URL : {apiUrl}");
|
|
Console.WriteLine($"Mode : {(TestRunMode.Smoke ? "smoke (fast subset, tightened timeouts)" : "full")}");
|
|
Console.WriteLine($"State : {(keepState ? "keep (DB reset skipped)" : "reset (clean DB at startup, AZ-493)")}");
|
|
Console.WriteLine($"Auth : JWT_SECRET resolved ({System.Text.Encoding.UTF8.GetByteCount(jwtSecret)} bytes); iss={jwtIssuer}; aud={jwtAudience}");
|
|
Console.WriteLine();
|
|
|
|
using var httpClient = new HttpClient
|
|
{
|
|
BaseAddress = new Uri(apiUrl),
|
|
Timeout = TimeSpan.FromMinutes(15)
|
|
};
|
|
|
|
var defaultToken = JwtTestHelpers.MintAuthenticated(jwtSecret);
|
|
JwtTestHelpers.AttachDefaultAuthorization(httpClient, defaultToken);
|
|
|
|
try
|
|
{
|
|
Console.WriteLine("Waiting for API to be ready...");
|
|
await WaitForApiReady(httpClient);
|
|
Console.WriteLine("✓ API is ready");
|
|
|
|
if (keepState)
|
|
{
|
|
Console.WriteLine("⚠ --keep-state / INTEGRATION_KEEP_STATE set; skipping DB reset (AZ-493)");
|
|
}
|
|
else
|
|
{
|
|
try
|
|
{
|
|
await new IntegrationTestDatabaseReset(connectionString).EnsureCleanStateAsync();
|
|
}
|
|
catch (InvalidOperationException ex)
|
|
{
|
|
Console.WriteLine($"❌ DB reset refused: {ex.Message}");
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
Console.WriteLine();
|
|
|
|
await JwtIntegrationTests.RunAll(apiUrl, jwtSecret);
|
|
await UavUploadTests.RunAll(apiUrl, jwtSecret);
|
|
await Http2MultiplexingTests.RunAll(apiUrl, jwtSecret);
|
|
|
|
if (TestRunMode.Smoke)
|
|
{
|
|
await RunSmokeSuite(httpClient, connectionString);
|
|
}
|
|
else
|
|
{
|
|
await RunFullSuite(httpClient, connectionString);
|
|
}
|
|
|
|
Console.WriteLine();
|
|
Console.WriteLine("=========================");
|
|
Console.WriteLine("All tests completed successfully!");
|
|
return 0;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Console.WriteLine();
|
|
Console.WriteLine("❌ Integration tests failed");
|
|
Console.WriteLine($"Error: {ex.Message}");
|
|
Console.WriteLine($"Stack trace: {ex.StackTrace}");
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
static async Task RunSmokeSuite(HttpClient httpClient, string connectionString)
|
|
{
|
|
await TileTests.RunGetTileByLatLonTest(httpClient);
|
|
await RegionTests.RunRegionProcessingTest_200m_Zoom18(httpClient);
|
|
await BasicRouteTests.RunSimpleRouteTest(httpClient);
|
|
await ExtendedRouteTests.RunRouteWithTilesZipTest(httpClient);
|
|
await SecurityTests.RunAll(httpClient);
|
|
await StubAndErrorContractTests.RunAll(httpClient);
|
|
await IdempotentPostTests.RunAll(httpClient);
|
|
await TileInventoryTests.RunAll(httpClient);
|
|
await TileInventoryValidationTests.RunAll(httpClient);
|
|
await RegionFieldRenameTests.RunAll(httpClient);
|
|
await RegionRequestValidationTests.RunAll(httpClient);
|
|
await GetTileByLatLonValidationTests.RunAll(httpClient);
|
|
await CreateRouteValidationTests.RunAll(httpClient);
|
|
await LeafletPathIndexOnlyTests.RunAll(connectionString);
|
|
await MigrationTests.RunAll();
|
|
}
|
|
|
|
static async Task RunFullSuite(HttpClient httpClient, string connectionString)
|
|
{
|
|
await TileTests.RunGetTileByLatLonTest(httpClient);
|
|
|
|
await RegionTests.RunRegionProcessingTest_200m_Zoom18(httpClient);
|
|
await RegionTests.RunRegionProcessingTest_400m_Zoom17(httpClient);
|
|
await RegionTests.RunRegionProcessingTest_500m_Zoom18(httpClient);
|
|
|
|
await BasicRouteTests.RunSimpleRouteTest(httpClient);
|
|
await BasicRouteTests.RunRouteWithRegionProcessingAndStitching(httpClient);
|
|
await ExtendedRouteTests.RunRouteWithTilesZipTest(httpClient);
|
|
await ComplexRouteTests.RunComplexRouteWithStitching(httpClient);
|
|
await ComplexRouteTests.RunComplexRouteWithStitchingAndGeofences(httpClient);
|
|
await ExtendedRouteTests.RunExtendedRouteEast(httpClient);
|
|
|
|
await SecurityTests.RunAll(httpClient);
|
|
await StubAndErrorContractTests.RunAll(httpClient);
|
|
await IdempotentPostTests.RunAll(httpClient);
|
|
await TileInventoryTests.RunAll(httpClient);
|
|
await TileInventoryValidationTests.RunAll(httpClient);
|
|
await RegionFieldRenameTests.RunAll(httpClient);
|
|
await RegionRequestValidationTests.RunAll(httpClient);
|
|
await GetTileByLatLonValidationTests.RunAll(httpClient);
|
|
await CreateRouteValidationTests.RunAll(httpClient);
|
|
await LeafletPathIndexOnlyTests.RunAll(connectionString);
|
|
await MigrationTests.RunAll();
|
|
}
|
|
|
|
static async Task WaitForApiReady(HttpClient httpClient, int maxRetries = 30)
|
|
{
|
|
for (int i = 0; i < maxRetries; i++)
|
|
{
|
|
try
|
|
{
|
|
var response = await httpClient.GetAsync("/");
|
|
if (response.IsSuccessStatusCode || response.StatusCode == System.Net.HttpStatusCode.NotFound)
|
|
{
|
|
return;
|
|
}
|
|
}
|
|
catch
|
|
{
|
|
}
|
|
|
|
Console.WriteLine($" Attempt {i + 1}/{maxRetries} - waiting 2 seconds...");
|
|
await Task.Delay(2000);
|
|
}
|
|
|
|
throw new Exception("API did not become ready in time");
|
|
}
|
|
}
|