Files
satellite-provider/SatelliteProvider.Tests/Validators/GetTileByLatLonQueryValidatorTests.cs
T
Oleksandr Bezdieniezhnykh 34ee1e0b83 [AZ-808] [AZ-811] Strict validation on region POST + lat/lon GET
AZ-808: FluentValidation for POST /api/satellite/request
- RegionRequestValidator: id non-empty, lat/lon/sizeMeters/zoomLevel ranges
- RequestRegionRequest: [JsonRequired] on every property, no implicit defaults
- Wired via .WithValidation<RequestRegionRequest>() in MapPost chain
- Unit + integration tests + curl probe script
- New contract: contracts/api/region-request.md v1.0.0

AZ-811: FluentValidation + envelope filter for GET /api/satellite/tiles/latlon
- GetTileByLatLonQuery: nullable record (double?/int?) so the minimal-API
  binder never short-circuits with BadHttpRequestException before filters
- GetTileByLatLonQueryValidator: Cascade(Stop) + NotNull + InclusiveBetween
  per param; missing surfaces as `\`<name>\` is required.`
- RejectUnknownQueryParamsEndpointFilter: reusable IEndpointFilter that
  rejects any query key outside the allowed set with errors[<key>] map;
  catches legacy `?Latitude=` typos and hostile probes (`?debug=1&admin=1`)
- Handler: [AsParameters] GetTileByLatLonQuery + .Value deref post-validator
- Unit (validator + filter) + integration tests + curl probe script
- New contract: contracts/api/tile-latlon.md v1.0.0

Shared hygiene
- Promote AssertErrorsContainsMention from per-test-file private helpers to
  ProblemDetailsAssertions (closes batch-1 Low-severity DRY warning)
- Sync Swagger param descriptions, README, blackbox/security/perf scripts,
  uuidv5 doc with the new lat/lon/zoom query-param names

Docs
- system-flows.md F1/F2 reference the new contracts + validation layers
- modules/api_program.md adds Api/Validators + Api/DTOs sections
- _autodev_state.md: batch 2 of 4 complete; next batch = AZ-809

All smoke tests green (mode=smoke, exit 0). AZ-808 + AZ-811 transitioned
to In Testing on Jira.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-22 16:29:41 +03:00

160 lines
4.3 KiB
C#

using FluentValidation.TestHelper;
using SatelliteProvider.Api.DTOs;
using SatelliteProvider.Api.Validators;
namespace SatelliteProvider.Tests.Validators;
// AZ-811: unit tests for GetTileByLatLonQueryValidator. One Theory per RuleFor
// covering boundary + out-of-range. Unknown-query-param rejection is tested
// at the integration layer (GetTileByLatLonValidationTests) — there's no
// pure-unit equivalent because the filter runs against HttpContext.Request.Query.
public class GetTileByLatLonQueryValidatorTests
{
private readonly GetTileByLatLonQueryValidator _validator;
public GetTileByLatLonQueryValidatorTests()
{
GlobalValidatorConfig.ApplyOnce();
_validator = new GetTileByLatLonQueryValidator();
}
[Theory]
[InlineData(-90.001)]
[InlineData(90.001)]
[InlineData(180.0)]
public void Validate_LatOutOfRange_FailsRangeRule(double lat)
{
// Arrange
var query = new GetTileByLatLonQuery(lat, 37.647063, 18);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldHaveValidationErrorFor("lat");
}
[Fact]
public void Validate_LatNull_FailsNotNullRule()
{
// Arrange
var query = new GetTileByLatLonQuery(null, 37.647063, 18);
// Act
var result = _validator.TestValidate(query);
// Assert — CascadeMode.Stop ensures NotNull short-circuits the range
// rule, so the caller sees only `"\`lat\` is required."` not also the
// range error against a null sentinel.
result.ShouldHaveValidationErrorFor("lat").WithErrorMessage("`lat` is required.");
}
[Theory]
[InlineData(-90.0)]
[InlineData(0.0)]
[InlineData(47.461747)]
[InlineData(90.0)]
public void Validate_LatAtOrInsideBounds_Passes(double lat)
{
// Arrange
var query = new GetTileByLatLonQuery(lat, 37.647063, 18);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldNotHaveValidationErrorFor("lat");
}
[Theory]
[InlineData(-180.001)]
[InlineData(180.001)]
[InlineData(360.0)]
public void Validate_LonOutOfRange_FailsRangeRule(double lon)
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, lon, 18);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldHaveValidationErrorFor("lon");
}
[Fact]
public void Validate_LonNull_FailsNotNullRule()
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, null, 18);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldHaveValidationErrorFor("lon").WithErrorMessage("`lon` is required.");
}
[Theory]
[InlineData(-180.0)]
[InlineData(0.0)]
[InlineData(37.647063)]
[InlineData(180.0)]
public void Validate_LonAtOrInsideBounds_Passes(double lon)
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, lon, 18);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldNotHaveValidationErrorFor("lon");
}
[Theory]
[InlineData(-1)]
[InlineData(23)]
[InlineData(100)]
public void Validate_ZoomOutOfRange_FailsRangeRule(int zoom)
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, 37.647063, zoom);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldHaveValidationErrorFor("zoom");
}
[Fact]
public void Validate_ZoomNull_FailsNotNullRule()
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, 37.647063, null);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldHaveValidationErrorFor("zoom").WithErrorMessage("`zoom` is required.");
}
[Theory]
[InlineData(0)]
[InlineData(18)]
[InlineData(22)]
public void Validate_ZoomAtOrInsideBounds_Passes(int zoom)
{
// Arrange
var query = new GetTileByLatLonQuery(47.461747, 37.647063, zoom);
// Act
var result = _validator.TestValidate(query);
// Assert
result.ShouldNotHaveValidationErrorFor("zoom");
}
}