mirror of
https://github.com/azaion/ui.git
synced 2026-06-21 08:01:10 +00:00
[AZ-457] [AZ-459] [AZ-465] [AZ-481] Batch 2 - auth/enum/i18n/CI tests
Implements 22 blackbox test scenarios across the four batch-2 tasks:
AZ-457 - Auth & token handling (11 scenarios, fast + e2e):
- src/api/client.test.ts: FT-P-02, NFT-SEC-04, NFT-PERF-02, NFT-RES-01,
NFT-RES-08 (apiClient surface)
- src/auth/AuthContext.test.tsx: FT-P-01 (it.fails - Step 4 drift),
FT-P-03, NFT-SEC-01, NFT-SEC-02
- src/auth/ProtectedRoute.test.tsx: FT-N-04, NFT-RES-08 (router half)
- e2e/tests/auth.e2e.ts: FT-P-02 e2e, NFT-SEC-01/02/03 (cookie attrs
via Playwright context.cookies(), gated by suite stack)
AZ-459 - Wire-contract enums (4 scenarios):
- tests/wire_contract.test.ts: FT-P-04 (AnnotationStatus, it.fails),
FT-P-05 (MediaStatus + Affiliation it.fails; CombatReadiness skip
per verification_pending), FT-P-06 (AnnotationSource control +
spec value-set membership), FT-N-15 (typed-enum shape + skip for
value-set verification)
- e2e/tests/wire_contract.e2e.ts: FT-P-06 against real annotations/
service, drift-gated via AZAION_RUN_DRIFT_E2E
- scripts/run-tests.sh STC-FN15: ripgrep static for MediaType
magic-literal hygiene
AZ-465 - i18n (4 scenarios, all static + quarantined fast):
- scripts/check-i18n-coverage.mjs: FT-P-22 (en vs ua key parity) +
FT-P-23 (no raw user strings outside t() in src/**/*.tsx); refined
JSX text-node regex with negative lookbehind to drop TS generics
+ arrow-function false positives
- tests/i18n-allowlist.json: snapshot of current pre-existing raw
strings (CI gates growth per AZ-465 Constraints)
- tests/i18n.test.tsx: FT-P-24 + FT-P-25 it.skip (QUARANTINE - i18n
detector + persistence not wired today; control tests assert the
gap so the skip flips to a real test once Step 4 lands)
AZ-481 - CI image labels (3 scenarios, static against
.woodpecker/build-arm.yml):
- scripts/check-ci-image-labels.mjs: NFT-RES-LIM-11 (tag scheme
${CI_COMMIT_BRANCH}-arm), NFT-RES-LIM-12 (revision/created/source
PASS, image.title reported as DRIFT - foundation/CI-CD owns the
fix), NFT-RES-LIM-13 (revision = $CI_COMMIT_SHA)
Cross-cutting:
- scripts/run-tests.sh: src_grep now excludes *.test.{ts,tsx} +
*.spec.{ts,tsx} so production-source static checks (STC-SEC4,
STC-FN15, etc.) don't false-positive on test prose
- tsconfig.json: exclude src/**/*.{test,spec}.{ts,tsx} so production
tsc -b doesn't see jest-dom matchers
- _docs/03_implementation/batch_02_report.md: full per-task AC
coverage matrix + drift inventory + verification run
- _docs/_autodev_state.md: 22 tasks remain after batch 2
Verification (host):
fast : 7 files, 38 passed | 4 skipped (quarantined)
static : 19/19 checks PASS (was 13 in batch 1; +6 from batch 2)
e2e : not run on host (Risk 4 - requires suite docker stack)
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Oleksandr Bezdieniezhnykh
@@ -0,0 +1,75 @@
|
||||
{
|
||||
"$schema_note": "AZ-465 FT-P-23 allow-list. Grouped by repo-relative path; '*' is the global allow-list (brand names, acronyms, units). Constraint per AZ-465: this file MUST NOT grow without a code-review reason. Pre-populated entries reflect the codebase state at the time AZ-465 landed; tightening the list (extracting a string into an i18n key, replacing with a t() call, then removing the entry) is Phase B i18n-migration work tracked under epic AZ-455 follow-ups.",
|
||||
"*": [
|
||||
"AZAION",
|
||||
"OSM",
|
||||
"TCP",
|
||||
"UDP",
|
||||
"Esc",
|
||||
"OK"
|
||||
],
|
||||
"src/components/Header.tsx": [
|
||||
"No flights",
|
||||
"Filter..."
|
||||
],
|
||||
"src/components/HelpModal.tsx": [
|
||||
"How to Annotate",
|
||||
"Keyboard Shortcuts",
|
||||
"Space",
|
||||
"Play / Pause",
|
||||
"Frame step",
|
||||
"Ctrl + \u2190 \u2192",
|
||||
"5 second skip",
|
||||
"Enter",
|
||||
"Save annotation",
|
||||
"Delete",
|
||||
"Delete selected",
|
||||
"Delete all detections",
|
||||
"Select detection class",
|
||||
"Mute / Unmute",
|
||||
"Ctrl + Scroll",
|
||||
"Zoom canvas",
|
||||
"Close dialog / editor",
|
||||
"Validate (Dataset)",
|
||||
"PageUp/Down",
|
||||
"Navigate media / pages"
|
||||
],
|
||||
"src/features/admin/AdminPage.tsx": [
|
||||
"Name",
|
||||
"Color",
|
||||
"Frame Period Recognition",
|
||||
"Frame Recognition Seconds",
|
||||
"Probability Threshold",
|
||||
"Device Address",
|
||||
"Port",
|
||||
"Protocol",
|
||||
"Email",
|
||||
"Role",
|
||||
"Status",
|
||||
"Annotator",
|
||||
"Admin",
|
||||
"Viewer",
|
||||
"Password"
|
||||
],
|
||||
"src/features/annotations/AnnotationsSidebar.tsx": [
|
||||
"Download annotation"
|
||||
],
|
||||
"src/features/annotations/VideoPlayer.tsx": [
|
||||
"Previous frame",
|
||||
"Next frame",
|
||||
"Stop"
|
||||
],
|
||||
"src/features/dataset/DatasetPage.tsx": [
|
||||
"Prev",
|
||||
"Next"
|
||||
],
|
||||
"src/features/flights/FlightListSidebar.tsx": [
|
||||
"Flight name"
|
||||
],
|
||||
"src/features/flights/FlightsPage.tsx": [
|
||||
"Status:",
|
||||
"Waiting for GPS signal...",
|
||||
"Expand",
|
||||
"Collapse"
|
||||
]
|
||||
}
|
||||
@@ -0,0 +1,67 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import i18n from '../src/i18n/i18n'
|
||||
|
||||
// AZ-465 — i18n detector + persistence (fast counterparts).
|
||||
//
|
||||
// FT-P-24 (row 47) — i18n detector path used at first boot
|
||||
// Profile: fast — `quarantined` per blackbox-tests.md
|
||||
// until the navigator.language detector is added in
|
||||
// Step 4. Today src/i18n/i18n.ts hardcodes `lng: 'en'`
|
||||
// so the test would assert the detector branch ran when
|
||||
// no detector exists.
|
||||
// FT-P-25 (row 48) — i18n persistence across reload
|
||||
// Profile: e2e — `quarantined` per spec until detector
|
||||
// + persistence land. Fast counterpart asserts the
|
||||
// i18n instance carries no persisted-language detector
|
||||
// so persistence can't have shipped yet.
|
||||
//
|
||||
// Both tests write the QUARANTINE marker (Vitest's `.skip` reporter line +
|
||||
// inline reason). When the detector + persistence feature lands, the marker
|
||||
// flips: removing `.skip` reveals the assertion, which then drives the
|
||||
// production feature green.
|
||||
//
|
||||
// Black-box discipline: import `i18n` (the `00_foundation` public API) only;
|
||||
// no React-component internals.
|
||||
|
||||
describe('AZ-465 / src/i18n/i18n.ts — detector + persistence (quarantined)', () => {
|
||||
describe('FT-P-24 (row 47) — detector path on first boot', () => {
|
||||
it.skip('first boot reads navigator.language; no hardcoded `lng: "en"` (QUARANTINE: detector pending Step 4)', () => {
|
||||
// Arrange — when the feature lands the test should:
|
||||
// 1. Mount the SPA in jsdom with `Object.defineProperty(navigator, 'language', { value: 'uk' })`.
|
||||
// 2. Reload the i18n instance.
|
||||
// 3. Assert i18n.language === 'uk' or starts with 'uk'.
|
||||
// 4. Assert that src/i18n/i18n.ts source no longer contains `lng: 'en'`
|
||||
// (covered by a static check FT-P-24 partial).
|
||||
//
|
||||
// Today the production code initialises with `lng: 'en'` so the
|
||||
// detector branch never fires. Skipping per spec.
|
||||
expect(true).toBe(false)
|
||||
})
|
||||
|
||||
it('control: today the i18n instance defaults to en (drives the QUARANTINE flip)', () => {
|
||||
// Arrange + Assert
|
||||
expect(i18n.language).toBe('en')
|
||||
})
|
||||
})
|
||||
|
||||
describe('FT-P-25 (row 48) — persistence across reload', () => {
|
||||
it.skip('toggle to uk, reload, language persists (QUARANTINE: persistence pending Step 4)', () => {
|
||||
// Arrange — when the feature lands the test should:
|
||||
// 1. Switch language to uk via i18n.changeLanguage('uk').
|
||||
// 2. Persist (i18next-browser-languagedetector with localStorage).
|
||||
// 3. Re-create the i18n instance and assert .language === 'uk'.
|
||||
//
|
||||
// Today no language-detector or storage adapter is configured.
|
||||
expect(true).toBe(false)
|
||||
})
|
||||
|
||||
it('control: i18n config has no persistence adapter today', () => {
|
||||
// Arrange + Assert — i18next options exposes the language detector
|
||||
// chain via `services.languageDetector`. With no detector configured,
|
||||
// services.languageDetector is undefined — confirming persistence
|
||||
// hasn't shipped yet.
|
||||
const detector = (i18n as unknown as { services: { languageDetector?: unknown } }).services.languageDetector
|
||||
expect(detector).toBeUndefined()
|
||||
})
|
||||
})
|
||||
})
|
||||
@@ -0,0 +1,218 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import {
|
||||
AnnotationSource,
|
||||
AnnotationStatus,
|
||||
Affiliation,
|
||||
CombatReadiness,
|
||||
MediaStatus,
|
||||
MediaType,
|
||||
} from '../src/types'
|
||||
import { loadEnumSnapshot } from './fixtures/enum_spec_snapshot'
|
||||
|
||||
// AZ-459 — Wire-contract enum compliance.
|
||||
// FT-P-04 / row 14, 18 — AnnotationStatus on the wire matches spec set
|
||||
// FT-P-05 / rows 15-17 — MediaStatus / Affiliation / CombatReadiness match
|
||||
// FT-P-06 / rows 18-19 — detection wire payload uses spec enum values
|
||||
// (e2e captures the actual outbound POST; this fast
|
||||
// test asserts the typed enum constants in src/types
|
||||
// agree with the snapshot, which IS the wire format
|
||||
// per src/api/client.ts JSON.stringify path)
|
||||
// FT-N-15 / rows 20-21 — MediaType magic-literal hygiene; static counterpart
|
||||
// lives in scripts/run-tests.sh
|
||||
//
|
||||
// Drift-failure semantics (AC-2): when the UI's enum value differs from the
|
||||
// spec snapshot, the test surfaces the divergence loudly. Today the UI drifts
|
||||
// on AnnotationStatus / MediaStatus / Affiliation. We use Vitest's it.fails()
|
||||
// for those documented drifts so the runner reports them as known-failing
|
||||
// (= today's PASS) and flips to FAIL the moment the production enum is fixed
|
||||
// (= tomorrow's signal to remove the wrapper). For verification_pending
|
||||
// enums (CombatReadiness, MediaType per the snapshot), we skip with a clear
|
||||
// QUARANTINE marker that names the resolution path.
|
||||
//
|
||||
// Black-box discipline (P9 / AC-2 of the task spec): comparing the spec
|
||||
// snapshot to typed src/types enum SHAPES is allowed because those enums
|
||||
// ARE the wire format per src/api/client.ts. It is NOT allowed to compare
|
||||
// the snapshot to itself (a tautology) or to derive expected values from
|
||||
// the UI rather than the contract.
|
||||
|
||||
const snapshot = loadEnumSnapshot()
|
||||
|
||||
interface DriftReport {
|
||||
enumName: string
|
||||
observed: Record<string, number>
|
||||
expected: Record<string, number>
|
||||
missingFromUi: string[]
|
||||
extraOnUi: string[]
|
||||
numericMismatches: Array<{ name: string; observed: number; expected: number }>
|
||||
}
|
||||
|
||||
function compareEnum(
|
||||
enumName: string,
|
||||
uiEnum: Record<string, number | string>,
|
||||
expected: Record<string, number>,
|
||||
): DriftReport {
|
||||
// Filter out reverse-mapped numeric keys that TypeScript synthesises for
|
||||
// numeric enums — keep only string-keyed entries with numeric values.
|
||||
const observed: Record<string, number> = {}
|
||||
for (const [k, v] of Object.entries(uiEnum)) {
|
||||
if (typeof v === 'number') observed[k] = v
|
||||
}
|
||||
const obsKeys = new Set(Object.keys(observed))
|
||||
const expKeys = new Set(Object.keys(expected))
|
||||
const missingFromUi = [...expKeys].filter((k) => !obsKeys.has(k))
|
||||
const extraOnUi = [...obsKeys].filter((k) => !expKeys.has(k))
|
||||
const numericMismatches: Array<{ name: string; observed: number; expected: number }> = []
|
||||
for (const k of obsKeys) {
|
||||
if (k in expected && observed[k] !== expected[k]) {
|
||||
numericMismatches.push({ name: k, observed: observed[k], expected: expected[k] })
|
||||
}
|
||||
}
|
||||
return { enumName, observed, expected, missingFromUi, extraOnUi, numericMismatches }
|
||||
}
|
||||
|
||||
function describeDrift(d: DriftReport): string {
|
||||
const parts: string[] = [`enum ${d.enumName} drift:`]
|
||||
if (d.missingFromUi.length) parts.push(`missing from UI: ${d.missingFromUi.join(', ')}`)
|
||||
if (d.extraOnUi.length) parts.push(`extra on UI: ${d.extraOnUi.join(', ')}`)
|
||||
for (const m of d.numericMismatches) parts.push(`${m.name} = ${m.observed} (UI) vs ${m.expected} (spec)`)
|
||||
return parts.join(' | ')
|
||||
}
|
||||
|
||||
describe('AZ-459 / wire-contract enum compliance', () => {
|
||||
describe('FT-P-04 (rows 14, 18) — AnnotationStatus matches spec', () => {
|
||||
// Drift documented: src/types says Edited=1, spec says Edited=20. The
|
||||
// it.fails wrapper makes this test pass today (drift exists; assertion
|
||||
// throws as required by AC-2) and fails the day Step 4 lifts the drift
|
||||
// (assertion succeeds, alerting the author to remove the wrapper).
|
||||
it.fails('UI matches spec exactly (currently DRIFTED — Step 4 fix pending; see ui_drift_summary.AnnotationStatus)', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('AnnotationStatus', AnnotationStatus, snapshot.enums.AnnotationStatus.values)
|
||||
|
||||
// Assert (will throw today because of documented drift)
|
||||
expect(
|
||||
drift.numericMismatches.length === 0 && drift.missingFromUi.length === 0 && drift.extraOnUi.length === 0,
|
||||
describeDrift(drift),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
// Regression detector: the drift IS what the snapshot's ui_drift_summary
|
||||
// says it is. If the UI's drift shape changes (e.g. someone renames Edited
|
||||
// to EditPending), this test fails so the snapshot's documentation can be
|
||||
// updated alongside the code.
|
||||
it('current UI drift matches the documented ui_drift_summary entry', () => {
|
||||
// Arrange
|
||||
const documentedDrift = (snapshot.ui_drift_summary as { AnnotationStatus?: { ui_values?: Record<string, number> } }).AnnotationStatus?.ui_values ?? null
|
||||
|
||||
// Assert
|
||||
expect(documentedDrift).not.toBeNull()
|
||||
const observed: Record<string, number> = {}
|
||||
for (const [k, v] of Object.entries(AnnotationStatus)) {
|
||||
if (typeof v === 'number') observed[k] = v
|
||||
}
|
||||
expect(observed).toEqual(documentedDrift)
|
||||
})
|
||||
})
|
||||
|
||||
describe('FT-P-05 (rows 15-17) — MediaStatus / Affiliation / CombatReadiness match spec', () => {
|
||||
it.fails('MediaStatus UI matches spec exactly (currently DRIFTED — Step 4 fix pending)', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('MediaStatus', MediaStatus, snapshot.enums.MediaStatus.values)
|
||||
// Assert (today drifted)
|
||||
expect(
|
||||
drift.numericMismatches.length === 0 && drift.missingFromUi.length === 0 && drift.extraOnUi.length === 0,
|
||||
describeDrift(drift),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
it.fails('Affiliation UI matches spec exactly (currently DRIFTED — Step 4 fix pending)', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('Affiliation', Affiliation, snapshot.enums.Affiliation.values)
|
||||
// Assert (today drifted)
|
||||
expect(
|
||||
drift.numericMismatches.length === 0 && drift.missingFromUi.length === 0 && drift.extraOnUi.length === 0,
|
||||
describeDrift(drift),
|
||||
).toBe(true)
|
||||
})
|
||||
|
||||
// QUARANTINE — verification_pending: true per snapshot. Numeric values are
|
||||
// inferred sequentially; Step 4 .NET-service inspection must confirm
|
||||
// before this test ungates. Recorded as a CSV `Result: QUARANTINE` row in
|
||||
// scripts/run-tests.sh static profile (FT-P-05.CR partial).
|
||||
it.skip('CombatReadiness UI matches spec — QUARANTINE: snapshot.verification_pending=true; lifted by Step 4 .NET inspection', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('CombatReadiness', CombatReadiness, snapshot.enums.CombatReadiness.values)
|
||||
// Assert (held until snapshot.verification_pending flips to false)
|
||||
expect(drift.numericMismatches.length === 0, describeDrift(drift)).toBe(true)
|
||||
})
|
||||
|
||||
it('snapshot still flags CombatReadiness verification_pending (alerts when Step 4 lifts the flag)', () => {
|
||||
// Arrange + Assert
|
||||
expect(snapshot.enums.CombatReadiness.verification_pending).toBe(true)
|
||||
})
|
||||
})
|
||||
|
||||
describe('FT-P-06 (rows 18, 19) — detection wire payload uses spec enum values', () => {
|
||||
// Affiliation and CombatReadiness ride on every detection POST body.
|
||||
// The fast-profile half asserts the typed enum constants ship the values
|
||||
// that the wire would carry; the e2e half (e2e/tests/wire_contract.e2e.ts)
|
||||
// captures the actual outbound POST.
|
||||
it('AnnotationSource matches spec exactly (no drift; control case)', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('AnnotationSource', AnnotationSource, snapshot.enums.AnnotationSource.values)
|
||||
// Assert
|
||||
expect(drift.numericMismatches, describeDrift(drift)).toEqual([])
|
||||
expect(drift.missingFromUi).toEqual([])
|
||||
expect(drift.extraOnUi).toEqual([])
|
||||
})
|
||||
|
||||
it('the value sets shipped by the wire payload are members of the spec set (not just any number)', () => {
|
||||
// Arrange
|
||||
const annotationStatusSpecSet = new Set(Object.values(snapshot.enums.AnnotationStatus.values))
|
||||
const annotationSourceSpecSet = new Set(Object.values(snapshot.enums.AnnotationSource.values))
|
||||
const affiliationSpecSet = new Set(Object.values(snapshot.enums.Affiliation.values))
|
||||
|
||||
// Assert — every UI annotation-source value is in the spec set.
|
||||
for (const v of Object.values(AnnotationSource).filter((x): x is number => typeof x === 'number')) {
|
||||
expect(annotationSourceSpecSet.has(v)).toBe(true)
|
||||
}
|
||||
// For drifted enums, the test simply documents that the UI value is NOT
|
||||
// currently in the spec set. We do NOT assert membership (it would
|
||||
// tautologically pass today's drift); instead we document the
|
||||
// membership-set the test will gate on once Step 4 lifts the drift.
|
||||
// The drift-itself test above is the authoritative gate.
|
||||
void annotationStatusSpecSet
|
||||
void affiliationSpecSet
|
||||
})
|
||||
})
|
||||
|
||||
describe('FT-N-15 (rows 20-21) — MediaType magic-literal hygiene (fast counterpart)', () => {
|
||||
// The static profile counterpart in scripts/run-tests.sh runs the regex
|
||||
// sweep across src/. The fast counterpart asserts the typed enum's
|
||||
// SHAPE: every member is a number (not a string), so `mediaType === '1'`
|
||||
// would be a type-level error — strict TS already catches it. We pin the
|
||||
// shape so a future refactor cannot flip the enum to string values without
|
||||
// a deliberate decision.
|
||||
it('MediaType members are numeric (typed enum, not magic strings)', () => {
|
||||
// Arrange
|
||||
const numericMembers = Object.values(MediaType).filter((v): v is number => typeof v === 'number')
|
||||
const stringMembers = Object.values(MediaType).filter((v): v is string => typeof v === 'string')
|
||||
|
||||
// Assert — all values are numeric reverse-maps; only the string keys are textual.
|
||||
expect(numericMembers.length).toBeGreaterThan(0)
|
||||
// The string side of the reverse map equals the named members.
|
||||
expect(stringMembers.sort()).toEqual(['Image', 'None', 'Video'])
|
||||
})
|
||||
|
||||
it.skip('MediaType numeric assignment matches spec — QUARANTINE: snapshot.verification_pending=true (Step 4 .NET inspection pending)', () => {
|
||||
// Arrange
|
||||
const drift = compareEnum('MediaType', MediaType, snapshot.enums.MediaType.values)
|
||||
// Assert (held)
|
||||
expect(drift.numericMismatches, describeDrift(drift)).toEqual([])
|
||||
})
|
||||
|
||||
it('snapshot still flags MediaType verification_pending (alerts when Step 4 lifts)', () => {
|
||||
// Arrange + Assert
|
||||
expect(snapshot.enums.MediaType.verification_pending).toBe(true)
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user