azaion/ui

mirror of https://github.com/azaion/ui.git synced 2026-06-21 22:01:11 +00:00

Files

T

Oleksandr Bezdieniezhnykh ab22223580 [AZ-457] [AZ-459] [AZ-465] [AZ-481] Batch 2 - auth/enum/i18n/CI tests

Implements 22 blackbox test scenarios across the four batch-2 tasks:

AZ-457 - Auth & token handling (11 scenarios, fast + e2e):
- src/api/client.test.ts: FT-P-02, NFT-SEC-04, NFT-PERF-02, NFT-RES-01,
  NFT-RES-08 (apiClient surface)
- src/auth/AuthContext.test.tsx: FT-P-01 (it.fails - Step 4 drift),
  FT-P-03, NFT-SEC-01, NFT-SEC-02
- src/auth/ProtectedRoute.test.tsx: FT-N-04, NFT-RES-08 (router half)
- e2e/tests/auth.e2e.ts: FT-P-02 e2e, NFT-SEC-01/02/03 (cookie attrs
  via Playwright context.cookies(), gated by suite stack)

AZ-459 - Wire-contract enums (4 scenarios):
- tests/wire_contract.test.ts: FT-P-04 (AnnotationStatus, it.fails),
  FT-P-05 (MediaStatus + Affiliation it.fails; CombatReadiness skip
  per verification_pending), FT-P-06 (AnnotationSource control +
  spec value-set membership), FT-N-15 (typed-enum shape + skip for
  value-set verification)
- e2e/tests/wire_contract.e2e.ts: FT-P-06 against real annotations/
  service, drift-gated via AZAION_RUN_DRIFT_E2E
- scripts/run-tests.sh STC-FN15: ripgrep static for MediaType
  magic-literal hygiene

AZ-465 - i18n (4 scenarios, all static + quarantined fast):
- scripts/check-i18n-coverage.mjs: FT-P-22 (en vs ua key parity) +
  FT-P-23 (no raw user strings outside t() in src/**/*.tsx); refined
  JSX text-node regex with negative lookbehind to drop TS generics
  + arrow-function false positives
- tests/i18n-allowlist.json: snapshot of current pre-existing raw
  strings (CI gates growth per AZ-465 Constraints)
- tests/i18n.test.tsx: FT-P-24 + FT-P-25 it.skip (QUARANTINE - i18n
  detector + persistence not wired today; control tests assert the
  gap so the skip flips to a real test once Step 4 lands)

AZ-481 - CI image labels (3 scenarios, static against
  .woodpecker/build-arm.yml):
- scripts/check-ci-image-labels.mjs: NFT-RES-LIM-11 (tag scheme
  ${CI_COMMIT_BRANCH}-arm), NFT-RES-LIM-12 (revision/created/source
  PASS, image.title reported as DRIFT - foundation/CI-CD owns the
  fix), NFT-RES-LIM-13 (revision = $CI_COMMIT_SHA)

Cross-cutting:
- scripts/run-tests.sh: src_grep now excludes *.test.{ts,tsx} +
  *.spec.{ts,tsx} so production-source static checks (STC-SEC4,
  STC-FN15, etc.) don't false-positive on test prose
- tsconfig.json: exclude src/**/*.{test,spec}.{ts,tsx} so production
  tsc -b doesn't see jest-dom matchers
- _docs/03_implementation/batch_02_report.md: full per-task AC
  coverage matrix + drift inventory + verification run
- _docs/_autodev_state.md: 22 tasks remain after batch 2

Verification (host):
  fast    : 7 files, 38 passed | 4 skipped (quarantined)
  static  : 19/19 checks PASS (was 13 in batch 1; +6 from batch 2)
  e2e     : not run on host (Risk 4 - requires suite docker stack)

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-05-11 03:27:55 +03:00

2.9 KiB

Raw Permalink Blame History

Test — i18n Coverage & Persistence

Task: AZ-465_test_i18n Name: i18n key parity + t() coverage + detector + persistence Description: Implement the 4 blackbox tests that pin the i18n contract: en↔ua key parity (static), t() coverage (no raw user-visible strings), boot-time language detector, and persistence across reload. Complexity: 3 points Dependencies: AZ-456_test_infrastructure Component: 03_shared-ui + 10_app-shell (i18n) (Blackbox Tests) Tracker: AZ-465 Epic: AZ-455

Problem

A missing translation key or a hardcoded user-visible string only surfaces when a user switches language — by which point it's a customer-visible defect. Static checks + a behavioral test for detect/persist catch these at commit time.

Outcome

4 scenarios pass per the contract.
The "no raw strings" check is enforceable in CI and produces a clear allow-list mechanism for legitimate non-i18n text (e.g. brand names).

Scope

Included

Scenario	Profile	Source file	results_report row
FT-P-22 — i18n key parity en ↔ ua	static	blackbox-tests.md	45
FT-P-23 — no raw user-visible strings outside `t(...)`	static	blackbox-tests.md	46
FT-P-24 — i18n detector path used at first boot	fast + e2e	blackbox-tests.md	47
FT-P-25 — i18n persistence across reload	fast + e2e	blackbox-tests.md	48

Excluded

Adding a third language (project is en + ua per scope).
RTL support (not required by any AC).

Acceptance Criteria

AC-1: Key parity Static check: keys(en.json) == keys(ua.json) (set equality). Test FAILS on any drift.

AC-2: t() coverage Static check via ripgrep + AST walker: every JSX text node and string-literal aria-* / title / placeholder either lives in an i18n key, is in the allow-list (brand names, version strings), or fails the check.

AC-3: Detector path First boot with no persisted language preference: SPA reads navigator.language and renders the matching bundle.

AC-4: Persistence After user switches to UA and reloads, the UA bundle is rendered without explicit user action.

System Under Test Boundary

System under test: src/i18n/i18n.ts + every React component rendering user-visible text.
Allowed stubs: none beyond the standard test renderer.
Disallowed: reading the i18n state directly — the test asserts the rendered DOM text.
Expected observables per rows 45-48.

Constraints

Allow-list file lives at tests/i18n-allowlist.json; CI enforces it must not grow without a code-review reason.

Risks & Mitigation

Risk 1 — AST walker false positives

Risk: the t() coverage walker may misclassify dynamic strings (e.g. t(\key_${id}`)`) or ternaries.
Mitigation: explicit allow-list per file, plus a comment marker // i18n-ok: <reason> honored by the walker.

2.9 KiB Raw Permalink Blame History