mirror of
https://github.com/azaion/ui.git
synced 2026-06-21 08:01:10 +00:00
70fb452805
Replace the broken `GET /api/admin/auth/refresh` (no `credentials:'include'`) mount-time bootstrap with `POST /api/admin/auth/refresh` (with credentials) chained to `GET /api/admin/users/me`. Returning users with a valid HttpOnly refresh cookie no longer flash through `/login`. Closes Finding B3 / Vision P3. - Add module-scoped `bootstrapInflight` guard (StrictMode double-mount safety) + test-only reset hook exported via the `src/auth` barrel; `tests/setup.ts` resets it in `afterEach` to prevent pending-promise leakage between tests. - Defensive `hasPermission` against legacy `/users/me` payloads omitting `permissions`; default MSW handler now seeds `permissions` explicitly. - Add `endpoints.admin.usersMe()` builder (STC-ARCH-02 forbids the literal). - Bulk-swap 15 test files from `http.get` -> `http.post` for the refresh override so intentional bootstrap-fail tests still fail correctly. - Update auth component description; mark B3 closed. - Code review verdict PASS; static + fast suites green (231 / 13 skipped). Batch report: _docs/03_implementation/batch_13_cycle3_report.md Co-authored-by: Cursor <cursoragent@cursor.com>
86 lines
3.0 KiB
TypeScript
86 lines
3.0 KiB
TypeScript
import { http } from 'msw'
|
|
import { jsonResponse, noContent, paginate } from '../helpers'
|
|
import { seedUsers, opAlice, seedPermissions } from '../../fixtures/seed_users'
|
|
import { seedClasses } from '../../fixtures/seed_classes'
|
|
|
|
// Default `/api/admin/*` handlers — auth round-trip, users, classes-write,
|
|
// system settings. Tests override per-scenario via `server.use(...)`.
|
|
|
|
const SEED_BEARER = 'test-bearer-default'
|
|
|
|
export const adminHandlers = [
|
|
http.post('/api/admin/auth/login', async ({ request }) => {
|
|
const body = (await request.json().catch(() => ({}))) as { email?: string; password?: string }
|
|
const user = seedUsers.find((u) => u.email === body.email) ?? opAlice
|
|
return new Response(JSON.stringify({ token: SEED_BEARER, user }), {
|
|
status: 200,
|
|
headers: {
|
|
'Content-Type': 'application/json',
|
|
// AC-03 contract — refresh cookie is HttpOnly + Secure + SameSite=Strict.
|
|
'Set-Cookie': 'refreshToken=test-refresh; HttpOnly; Secure; SameSite=Strict; Path=/api/admin/auth',
|
|
},
|
|
})
|
|
}),
|
|
|
|
http.post('/api/admin/auth/refresh', () => {
|
|
return jsonResponse({ token: SEED_BEARER })
|
|
}),
|
|
|
|
http.post('/api/admin/auth/logout', () => noContent()),
|
|
|
|
// AZ-510 chains GET /users/me after POST refresh during AuthProvider
|
|
// bootstrap. The default user shape includes `permissions` so production
|
|
// code paths (e.g., hasPermission, RBAC route gates) get a realistic
|
|
// payload without each test having to override.
|
|
http.get('/api/admin/users/me', () =>
|
|
jsonResponse({ ...opAlice, permissions: seedPermissions[opAlice.id] ?? [] }),
|
|
),
|
|
|
|
http.get('/api/admin/users', () => jsonResponse(paginate(seedUsers))),
|
|
|
|
http.get('/api/admin/users/:id', ({ params }) => {
|
|
const user = seedUsers.find((u) => u.id === params.id)
|
|
if (!user) return new Response(null, { status: 404 })
|
|
return jsonResponse(user)
|
|
}),
|
|
|
|
http.get('/api/admin/classes', () => jsonResponse(seedClasses)),
|
|
|
|
http.post('/api/admin/classes', async ({ request }) => {
|
|
const body = await request.json()
|
|
return jsonResponse(body, { status: 201 })
|
|
}),
|
|
|
|
http.put('/api/admin/classes/:id', async ({ request }) => {
|
|
const body = await request.json()
|
|
return jsonResponse(body)
|
|
}),
|
|
|
|
http.delete('/api/admin/classes/:id', () => noContent()),
|
|
|
|
http.get('/api/admin/settings', () =>
|
|
jsonResponse({
|
|
id: 'sys-settings-1',
|
|
name: 'Test System',
|
|
militaryUnit: null,
|
|
defaultCameraWidth: 1920,
|
|
defaultCameraFoV: 60,
|
|
thumbnailWidth: 256,
|
|
thumbnailHeight: 256,
|
|
thumbnailBorder: 2,
|
|
generateAnnotatedImage: true,
|
|
silentDetection: false,
|
|
}),
|
|
),
|
|
|
|
http.put('/api/admin/settings', async ({ request }) => {
|
|
const body = await request.json()
|
|
return jsonResponse(body)
|
|
}),
|
|
|
|
// Test-only suite endpoint — gated behind a non-production build flag in the
|
|
// real `admin/` service. The fast-profile MSW just returns 204 so isolation
|
|
// helpers can call it uniformly with the e2e profile.
|
|
http.post('/api/admin/test-only/reset', () => noContent()),
|
|
]
|