Oleksandr Bezdieniezhnykh fbeeab60b3 [AZ-337] [AZ-338] [AZ-508] Cumulative review batches 46-48 ...

Verdict: PASS_WITH_WARNINGS. Per-batch reviews already validated
each task's ACs; this cumulative review focuses on cross-batch
drift and surfaces 1 Medium + 2 Low maintainability findings:

- F1 (Medium): `_iso_ts_from_clock` Clock-injected helper duplicated
  across 4 files (c2_vpr/net_vlad + ultra_vpr + _faiss_bridge,
  c12_operator_orchestrator/operator_reloc_service). B46 + B47
  carry inline comments anticipating AZ-508 would consolidate this,
  but AZ-508 (Batch 48) scoped itself narrower (stdlib-only,
  Excluded the Clock-injected variant). Recommend a 2-point follow-up
  PBI adding `iso_ts_from_clock(clock)` to helpers/iso_timestamps.py
  before AZ-339 / AZ-340 / AZ-358 / AZ-389 add more copies.

- F2 (Low): `_assert_engine_output_dim` near-duplicated between
  NetVLAD and UltraVPR. Defer consolidation until 5 c2_vpr strategies
  are in flight (after AZ-339 / AZ-340).

- F3 (Low): Clock-driven helper outputs `+00:00`; canonical FDR `ts`
  is `Z`. Fold into F1 follow-up PBI.

No Critical or High findings; auto-chain to next batch allowed.

Co-authored-by: Cursor <cursoragent@cursor.com>

2026-05-13 23:26:58 +03:00

..

reviews

[AZ-508] Consolidate _iso_ts_now into helpers/iso_timestamps

2026-05-13 23:23:22 +03:00

AZ-332_implementation_plan.md

chore: pre-batch-23 carry-over (state + AZ-332 plan)

2026-05-12 09:18:20 +03:00

batch_01_cycle1_report.md

[AZ-263] Bootstrap: repo skeleton + Docker + CI + Alembic + Tier-1 tests

2026-05-11 01:00:28 +03:00

batch_02_cycle1_report.md

[AZ-266] [AZ-269] [AZ-277] [AZ-280] Cross-cutting log/config + SE3/SHA256 helpers

2026-05-11 01:33:42 +03:00

batch_03_cycle1_report.md

[AZ-270] [AZ-272] [AZ-279] [AZ-281] [AZ-283] Compose root + FDR schema + 3 Layer-1 helpers

2026-05-11 02:03:36 +03:00

batch_04_cycle1_report.md

[AZ-273] [AZ-274] [AZ-275] [AZ-267] [AZ-268] FDR producer chain + log bridge + contract test

2026-05-11 03:00:49 +03:00

batch_05_cycle1_report.md

[AZ-271] [AZ-276] [AZ-278] [AZ-282] Finish cross-cutting helpers + relax opencv pin

2026-05-11 03:23:33 +03:00

batch_06_cycle1_report.md

[AZ-291] [AZ-292] [AZ-293] C13 FDR writer chain (batch 6)

2026-05-11 03:38:58 +03:00

batch_07_cycle1_report.md

[AZ-294] [AZ-295] [AZ-296] Finish C13: tile snapshot + record-kind policy + takeoff abort

2026-05-11 03:52:07 +03:00

batch_08_cycle1_report.md

[AZ-390] [AZ-392] C8 FC/GCS adapter foundation + covariance projector

2026-05-11 04:17:59 +03:00

batch_09_cycle1_report.md

[AZ-391] C8 inbound: MAVLink + MSP2 decoders + rings + bus + warm-start

2026-05-11 04:28:14 +03:00

batch_10_cycle1_report.md

[AZ-393] [AZ-394] [AZ-395] C8 outbound chain + AP MAVLink2 signing

2026-05-11 04:47:44 +03:00

batch_11_cycle1_report.md

[AZ-396] [AZ-397] Batch 11: C8 source-set switch + QGC telemetry adapter

2026-05-11 05:06:56 +03:00

batch_12_cycle1_report.md

[AZ-381] C5 StateEstimator protocol + factory + C8 DTO reshape

2026-05-11 05:35:20 +03:00

batch_13_cycle1_report.md

[AZ-382] C5 GtsamIsam2StateEstimator skeleton + real iSAM2 handle bodies

2026-05-11 05:51:23 +03:00

batch_14_cycle1_report.md

[AZ-383] C5 add_vio/add_pose_anchor/add_fc_imu factor adds

2026-05-11 06:07:45 +03:00

batch_15_cycle1_report.md

[AZ-384] C5 marginals + current_estimate/smoothed_history/health_snapshot

2026-05-11 06:20:01 +03:00

batch_16_cycle1_report.md

[AZ-388] C5 AC-5.2 no-estimate fallback detector + signal emission

2026-05-11 06:53:22 +03:00

batch_17_cycle1_report.md

[AZ-385] C5 SourceLabelStateMachine + spoof-promotion gate

2026-05-11 07:06:38 +03:00

batch_18_cycle1_report.md

[AZ-387] C5 smoothed-history → FDR side-channel

2026-05-11 07:13:44 +03:00

batch_19_cycle1_report.md

[AZ-386] C5 ESKF baseline: 16-state error-state KF (NumPy)

2026-05-11 10:12:30 +03:00

batch_20_cycle1_report.md

[AZ-355] C4 PoseEstimator Protocol + factory + DTOs + composition

2026-05-11 10:32:14 +03:00

batch_21_cycle1_report.md

[AZ-489] C12 FlightsApiClient + offline JSON loader + bbox helper

2026-05-12 01:28:49 +03:00

batch_22_cycle1_report.md

[AZ-490] C5 set_takeoff_origin entrypoint + bounded-delta GPS gate

2026-05-12 02:53:58 +03:00

batch_23_cycle1_report.md

[AZ-332] C1 OKVIS2 Strategy: facade + binding skeleton

2026-05-12 09:56:45 +03:00

batch_24_cycle1_report.md

[AZ-300] Implement PytorchFp16Runtime — C7 simple-baseline strategy

2026-05-12 10:13:21 +03:00

batch_25_cycle1_report.md

[AZ-301] Implement EngineGate — D-C10-3 + D-C10-7 takeoff validator

2026-05-12 10:20:21 +03:00

batch_26_cycle1_report.md

[AZ-302] C7 ThermalStatePublisher — jtop/NVML 1 Hz background poller

2026-05-12 10:33:37 +03:00

batch_27_cycle1_report.md

[AZ-304] C6 Postgres schema: additive 0002 migration + UUIDv5

2026-05-12 17:05:41 +03:00

batch_28_cycle1_report.md

[AZ-305] c6 PostgresFilesystemStore: TileStore + TileMetadataStore impl

2026-05-12 18:01:50 +03:00

batch_29_cycle1_report.md

[AZ-307] c6 FreshnessGate: active-conflict reject + stable-rear downgrade

2026-05-12 19:29:11 +03:00

batch_30_cycle1_report.md

[AZ-308] c6 CacheBudgetEnforcer: 10 GB hard cap + LRU sweep

2026-05-12 20:37:41 +03:00

batch_31_cycle1_report.md

[AZ-298] C7 TensorrtRuntime: TRT 10.3 + INT8 calib trust + GPU budget

2026-05-12 23:11:49 +03:00

batch_32_cycle1_report.md

[AZ-299] C7 OnnxTrtEpRuntime: ORT + TRT EP fallback strategy

2026-05-12 23:55:50 +03:00

batch_33_cycle1_report.md

[AZ-321] C10 EngineCompiler: hardware-tied TRT compile + cache reuse

2026-05-13 00:09:53 +03:00

batch_34_cycle1_report.md

chore: backfill batch_34_cycle1_report from commit e2bebef

2026-05-13 03:09:40 +03:00

batch_35_cycle1_report.md

[AZ-306] C6 FaissDescriptorIndex (faiss-cpu, HNSW32)

2026-05-13 04:01:37 +03:00

batch_36_cycle1_report.md

[AZ-322] C10 DescriptorBatcher (faiss-cpu, OOM halve-retry)

2026-05-13 04:20:47 +03:00

batch_37_cycle1_report.md

[AZ-325] C10 CacheProvisioner orchestrator

2026-05-13 05:00:16 +03:00

batch_38_cycle1_report.md

[AZ-317] [AZ-318] C11 upload-side: flight-state gate + per-flight key

2026-05-13 05:48:52 +03:00

batch_39_cycle1_report.md

[AZ-319] C11 HttpTileUploader (post-landing upload path)

2026-05-13 06:13:36 +03:00

batch_40_cycle1_report.md

[AZ-316] Implement C11 HttpTileDownloader (batch 40)

2026-05-13 07:01:14 +03:00

batch_41_cycle1_report.md

[AZ-320] Add C11 IdempotentRetryTileUploader decorator

2026-05-13 08:48:53 +03:00

batch_42_cycle1_report.md

[AZ-326] [AZ-327] C12 operator-tool CLI + companion SSH bringup

2026-05-13 09:34:14 +03:00

batch_43_cycle1_report.md

[AZ-328] C12 BuildCacheOrchestrator + remote C10 invoker (Batch 43)

2026-05-13 11:03:46 +03:00

batch_44_cycle1_report.md

[AZ-329] [AZ-330] [AZ-523] [AZ-524] Batch 44 atomic refactor

2026-05-13 19:42:46 +03:00

batch_44_implementation_plan.md

[Batch 44 prep] Add batch 44 implementation plan

2026-05-13 18:06:02 +03:00

batch_45_cycle1_report.md

[AZ-341] Archive AZ-341 + batch 45 report

2026-05-13 21:47:07 +03:00

batch_46_cycle1_report.md

[AZ-338] Archive task spec + batch 46 report + state bump

2026-05-13 22:31:56 +03:00

batch_47_cycle1_report.md

[AZ-337] Archive task spec + batch 47 report + state bump

2026-05-13 22:44:22 +03:00

batch_48_cycle1_report.md

[AZ-508] Consolidate _iso_ts_now into helpers/iso_timestamps

2026-05-13 23:23:22 +03:00

cumulative_review_batches_01-22_cycle1_report.md

[AZ-381] Fix ISam2GraphHandleImpl missing get_pose_key + comments

2026-05-12 03:55:41 +03:00

cumulative_review_batches_23-27_cycle1_report.md

[AZ-300] [AZ-301] [AZ-302] [AZ-304] docs: sync module-layout for c6+c7

2026-05-12 17:12:30 +03:00

cumulative_review_batches_28-30_cycle1_report.md

chore: record cumulative review batches 28-30 + state

2026-05-12 21:47:40 +03:00

cumulative_review_batches_31-33_cycle1_report.md

chore: record cumulative review batches 31-33 + state

2026-05-13 00:12:30 +03:00

cumulative_review_batches_34-36_cycle1_report.md

chore: record cumulative review batches 34-36 + state

2026-05-13 04:29:26 +03:00

cumulative_review_batches_37-39_cycle1_report.md

chore: cumulative review batches 37-39 (PASS_WITH_WARNINGS)

2026-05-13 06:40:09 +03:00

cumulative_review_batches_40-42_cycle1_report.md

chore: cumulative review batches 40-42 (PASS_WITH_WARNINGS)

2026-05-13 09:40:27 +03:00

cumulative_review_batches_43-45_cycle1_report.md

[AZ-341] [AZ-329] [AZ-330] [AZ-328] Cumulative review batches 43-45

2026-05-13 21:50:32 +03:00

cumulative_review_batches_46-48_cycle1_report.md

[AZ-337] [AZ-338] [AZ-508] Cumulative review batches 46-48

2026-05-13 23:26:58 +03:00