mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 08:41:13 +00:00
Oleksandr Bezdieniezhnykh
34ee1e0b83
AZ-808: FluentValidation for POST /api/satellite/request - RegionRequestValidator: id non-empty, lat/lon/sizeMeters/zoomLevel ranges - RequestRegionRequest: [JsonRequired] on every property, no implicit defaults - Wired via .WithValidation<RequestRegionRequest>() in MapPost chain - Unit + integration tests + curl probe script - New contract: contracts/api/region-request.md v1.0.0 AZ-811: FluentValidation + envelope filter for GET /api/satellite/tiles/latlon - GetTileByLatLonQuery: nullable record (double?/int?) so the minimal-API binder never short-circuits with BadHttpRequestException before filters - GetTileByLatLonQueryValidator: Cascade(Stop) + NotNull + InclusiveBetween per param; missing surfaces as `\`<name>\` is required.` - RejectUnknownQueryParamsEndpointFilter: reusable IEndpointFilter that rejects any query key outside the allowed set with errors[<key>] map; catches legacy `?Latitude=` typos and hostile probes (`?debug=1&admin=1`) - Handler: [AsParameters] GetTileByLatLonQuery + .Value deref post-validator - Unit (validator + filter) + integration tests + curl probe script - New contract: contracts/api/tile-latlon.md v1.0.0 Shared hygiene - Promote AssertErrorsContainsMention from per-test-file private helpers to ProblemDetailsAssertions (closes batch-1 Low-severity DRY warning) - Sync Swagger param descriptions, README, blackbox/security/perf scripts, uuidv5 doc with the new lat/lon/zoom query-param names Docs - system-flows.md F1/F2 reference the new contracts + validation layers - modules/api_program.md adds Api/Validators + Api/DTOs sections - _autodev_state.md: batch 2 of 4 complete; next batch = AZ-809 All smoke tests green (mode=smoke, exit 0). AZ-808 + AZ-811 transitioned to In Testing on Jira. Co-authored-by: Cursor <cursoragent@cursor.com>
51 lines
2.0 KiB
C#
51 lines
2.0 KiB
C#
using FluentValidation;
|
|
using SatelliteProvider.Common.DTO;
|
|
|
|
namespace SatelliteProvider.Api.Validators;
|
|
|
|
// AZ-808: FluentValidation rules for POST /api/satellite/request.
|
|
// Wired through ValidationEndpointFilter<RequestRegionRequest> at endpoint
|
|
// registration time (.WithValidation<RequestRegionRequest>() in Program.cs).
|
|
// Failures are converted to RFC 7807 ValidationProblemDetails per
|
|
// _docs/02_document/contracts/api/error-shape.md v1.0.0.
|
|
//
|
|
// Required-field detection is handled at the deserializer level via
|
|
// [JsonRequired] on RequestRegionRequest properties plus
|
|
// JsonSerializerOptions.UnmappedMemberHandling.Disallow (AZ-795). This
|
|
// validator covers the post-deserialization business rules: non-zero Id,
|
|
// lat/lon/sizeMeters/zoomLevel range constraints.
|
|
public sealed class RegionRequestValidator : AbstractValidator<RequestRegionRequest>
|
|
{
|
|
private const double MinLat = -90.0;
|
|
private const double MaxLat = 90.0;
|
|
private const double MinLon = -180.0;
|
|
private const double MaxLon = 180.0;
|
|
private const double MinSizeMeters = 100.0;
|
|
private const double MaxSizeMeters = 10000.0;
|
|
private const int MinZoom = 0;
|
|
private const int MaxZoom = 22;
|
|
|
|
public RegionRequestValidator()
|
|
{
|
|
RuleFor(req => req.Id)
|
|
.NotEmpty()
|
|
.WithMessage("`id` must be a non-zero GUID (the caller's idempotency key).");
|
|
|
|
RuleFor(req => req.Lat)
|
|
.InclusiveBetween(MinLat, MaxLat)
|
|
.WithMessage($"`lat` must be between {MinLat} and {MaxLat}.");
|
|
|
|
RuleFor(req => req.Lon)
|
|
.InclusiveBetween(MinLon, MaxLon)
|
|
.WithMessage($"`lon` must be between {MinLon} and {MaxLon}.");
|
|
|
|
RuleFor(req => req.SizeMeters)
|
|
.InclusiveBetween(MinSizeMeters, MaxSizeMeters)
|
|
.WithMessage($"`sizeMeters` must be between {MinSizeMeters} and {MaxSizeMeters} meters.");
|
|
|
|
RuleFor(req => req.ZoomLevel)
|
|
.InclusiveBetween(MinZoom, MaxZoom)
|
|
.WithMessage($"`zoomLevel` must be between {MinZoom} and {MaxZoom} (slippy-map range).");
|
|
}
|
|
}
|