mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 13:11:15 +00:00
745f4840e6
AZ-493 (2 SP): replace the cycle-2 wallclock-seeded _coordinateCounter workaround with a proper Postgres state-reset hook that runs at integration test runner startup, eliminating the per-source-unique-index collision risk that the persistent docker-compose Postgres volume introduced post-AZ-484. The reset is split into two surfaces: * SatelliteProvider.TestSupport.IntegrationTestResetGuard - pure static class, I/O-free, unit-tested. Two independent guards: (a) ASPNETCORE_ENVIRONMENT must equal "Testing", (b) DB_CONNECTION_STRING Host must be in the allowed-host list (postgres, localhost, 127.0.0.1). Failure of either guard surfaces a structured operator-friendly InvalidOperationException. * SatelliteProvider.IntegrationTests.IntegrationTestDatabaseReset - instance class owning the Npgsql side effects. Calls the guard then runs TRUNCATE TABLE route_regions, route_points, routes, regions, tiles RESTART IDENTITY CASCADE inside a single Npgsql transaction. Spec-vs-reality: the task spec prescribed "DB name contains _test" as Guard 2; the actual compose file uses Database=satelliteprovider and DB rename is gated on user confirmation per coderule.mdc. Substituted a Host allowlist as the equivalent guard (intent identical: reject remote / production hosts). Recorded as Low/Spec-Gap in the review. Program.cs adds --keep-state CLI flag and INTEGRATION_KEEP_STATE env var (1/true) opt-outs so a developer can inspect leftover state when debugging. Startup banner shows which path executed. docker-compose.tests.yml gets ASPNETCORE_ENVIRONMENT=Testing + passthrough for INTEGRATION_KEEP_STATE. scripts/run-tests.sh wires the --keep-state flag through to compose. UavUploadTests._coordinateCounter wallclock seed is retained as defense-in-depth (per the task spec's implementer choice). The reset is the primary isolation path; the seed is the belt-and-suspenders fallback for --keep-state runs. 8 new unit tests in SatelliteProvider.Tests/TestSupport/ IntegrationTestResetGuardTests.cs cover Production/Staging/missing-env throw, allowed-host case-insensitivity, disallowed-host rejection with representative prod hostnames, and the AllowedHosts contract. tests_integration.md gains a Reliability section that documents the hook, the two guards, the truncate order, and the three opt-out forms. module-layout.md TestSupport entry extended with the new pure guard and the explicit "Npgsql stays in IntegrationTests" boundary. Test-suite gate (AC-6) deferred to Step 16 Final Test Run per implement skill convention. Per-batch review verdict: PASS_WITH_WARNINGS with 1 Low (spec-vs-reality on Guard 2, non-blocking). Co-authored-by: Cursor <cursoragent@cursor.com>
38 lines
1.7 KiB
C#
38 lines
1.7 KiB
C#
namespace SatelliteProvider.TestSupport;
|
|
|
|
public static class IntegrationTestResetGuard
|
|
{
|
|
public const string EnvironmentEnvVar = "ASPNETCORE_ENVIRONMENT";
|
|
public const string TestingEnvironment = "Testing";
|
|
|
|
public static readonly IReadOnlyList<string> AllowedHosts =
|
|
new[] { "postgres", "localhost", "127.0.0.1" };
|
|
|
|
public static void EnsureGuardPassesOrThrow(string? environment, string? host)
|
|
{
|
|
if (!string.Equals(environment, TestingEnvironment, StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
throw new InvalidOperationException(
|
|
$"Integration test DB reset refused: {EnvironmentEnvVar} is '{environment ?? "(not set)"}', " +
|
|
$"expected '{TestingEnvironment}'. This guard prevents accidental truncate against a non-test " +
|
|
"database (production, staging, or developer-loop DB).");
|
|
}
|
|
|
|
if (string.IsNullOrWhiteSpace(host))
|
|
{
|
|
throw new InvalidOperationException(
|
|
"Integration test DB reset refused: connection string has no Host. " +
|
|
"Ensure DB_CONNECTION_STRING is set with Host=postgres (docker-compose) or Host=localhost (developer machine).");
|
|
}
|
|
|
|
var hostMatch = AllowedHosts.Any(allowed => string.Equals(allowed, host, StringComparison.OrdinalIgnoreCase));
|
|
if (!hostMatch)
|
|
{
|
|
throw new InvalidOperationException(
|
|
$"Integration test DB reset refused: Host '{host}' is not in the allowed-host list " +
|
|
$"({string.Join(", ", AllowedHosts)}). This guard prevents accidental truncate against a remote " +
|
|
"database whose hostname suggests production or staging.");
|
|
}
|
|
}
|
|
}
|