mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 19:21:14 +00:00
Oleksandr Bezdieniezhnykh
34ee1e0b83
AZ-808: FluentValidation for POST /api/satellite/request - RegionRequestValidator: id non-empty, lat/lon/sizeMeters/zoomLevel ranges - RequestRegionRequest: [JsonRequired] on every property, no implicit defaults - Wired via .WithValidation<RequestRegionRequest>() in MapPost chain - Unit + integration tests + curl probe script - New contract: contracts/api/region-request.md v1.0.0 AZ-811: FluentValidation + envelope filter for GET /api/satellite/tiles/latlon - GetTileByLatLonQuery: nullable record (double?/int?) so the minimal-API binder never short-circuits with BadHttpRequestException before filters - GetTileByLatLonQueryValidator: Cascade(Stop) + NotNull + InclusiveBetween per param; missing surfaces as `\`<name>\` is required.` - RejectUnknownQueryParamsEndpointFilter: reusable IEndpointFilter that rejects any query key outside the allowed set with errors[<key>] map; catches legacy `?Latitude=` typos and hostile probes (`?debug=1&admin=1`) - Handler: [AsParameters] GetTileByLatLonQuery + .Value deref post-validator - Unit (validator + filter) + integration tests + curl probe script - New contract: contracts/api/tile-latlon.md v1.0.0 Shared hygiene - Promote AssertErrorsContainsMention from per-test-file private helpers to ProblemDetailsAssertions (closes batch-1 Low-severity DRY warning) - Sync Swagger param descriptions, README, blackbox/security/perf scripts, uuidv5 doc with the new lat/lon/zoom query-param names Docs - system-flows.md F1/F2 reference the new contracts + validation layers - modules/api_program.md adds Api/Validators + Api/DTOs sections - _autodev_state.md: batch 2 of 4 complete; next batch = AZ-809 All smoke tests green (mode=smoke, exit 0). AZ-808 + AZ-811 transitioned to In Testing on Jira. Co-authored-by: Cursor <cursoragent@cursor.com>
46 lines
2.0 KiB
C#
46 lines
2.0 KiB
C#
using FluentValidation;
|
|
using SatelliteProvider.Api.DTOs;
|
|
|
|
namespace SatelliteProvider.Api.Validators;
|
|
|
|
// AZ-811: FluentValidation rules for the query-string surface of
|
|
// GET /api/satellite/tiles/latlon. Wired through
|
|
// ValidationEndpointFilter<GetTileByLatLonQuery> at endpoint registration
|
|
// time (.WithValidation<GetTileByLatLonQuery>() in Program.cs).
|
|
//
|
|
// Each rule maps 1:1 to a query parameter; errors[] keys are camelCase per
|
|
// GlobalValidatorConfig (matching the wire-format param names `lat`, `lon`,
|
|
// `zoom`). Required-field detection is `NotNull()` on the nullable-bound
|
|
// DTO (see GetTileByLatLonQuery for why properties are nullable). Each rule
|
|
// uses CascadeMode.Stop so a missing param surfaces ONLY as
|
|
// "`lat` is required" — not also "`lat` must be between -90 and 90" with a
|
|
// null value. Unknown query parameters are caught upstream by
|
|
// RejectUnknownQueryParamsEndpointFilter.
|
|
public sealed class GetTileByLatLonQueryValidator : AbstractValidator<GetTileByLatLonQuery>
|
|
{
|
|
private const double MinLat = -90.0;
|
|
private const double MaxLat = 90.0;
|
|
private const double MinLon = -180.0;
|
|
private const double MaxLon = 180.0;
|
|
private const int MinZoom = 0;
|
|
private const int MaxZoom = 22;
|
|
|
|
public GetTileByLatLonQueryValidator()
|
|
{
|
|
RuleFor(q => q.Lat)
|
|
.Cascade(CascadeMode.Stop)
|
|
.NotNull().WithMessage("`lat` is required.")
|
|
.InclusiveBetween(MinLat, MaxLat).WithMessage($"`lat` must be between {MinLat} and {MaxLat}.");
|
|
|
|
RuleFor(q => q.Lon)
|
|
.Cascade(CascadeMode.Stop)
|
|
.NotNull().WithMessage("`lon` is required.")
|
|
.InclusiveBetween(MinLon, MaxLon).WithMessage($"`lon` must be between {MinLon} and {MaxLon}.");
|
|
|
|
RuleFor(q => q.Zoom)
|
|
.Cascade(CascadeMode.Stop)
|
|
.NotNull().WithMessage("`zoom` is required.")
|
|
.InclusiveBetween(MinZoom, MaxZoom).WithMessage($"`zoom` must be between {MinZoom} and {MaxZoom} (slippy-map range).");
|
|
}
|
|
}
|