mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 19:11:14 +00:00
Oleksandr Bezdieniezhnykh
34ee1e0b83
AZ-808: FluentValidation for POST /api/satellite/request - RegionRequestValidator: id non-empty, lat/lon/sizeMeters/zoomLevel ranges - RequestRegionRequest: [JsonRequired] on every property, no implicit defaults - Wired via .WithValidation<RequestRegionRequest>() in MapPost chain - Unit + integration tests + curl probe script - New contract: contracts/api/region-request.md v1.0.0 AZ-811: FluentValidation + envelope filter for GET /api/satellite/tiles/latlon - GetTileByLatLonQuery: nullable record (double?/int?) so the minimal-API binder never short-circuits with BadHttpRequestException before filters - GetTileByLatLonQueryValidator: Cascade(Stop) + NotNull + InclusiveBetween per param; missing surfaces as `\`<name>\` is required.` - RejectUnknownQueryParamsEndpointFilter: reusable IEndpointFilter that rejects any query key outside the allowed set with errors[<key>] map; catches legacy `?Latitude=` typos and hostile probes (`?debug=1&admin=1`) - Handler: [AsParameters] GetTileByLatLonQuery + .Value deref post-validator - Unit (validator + filter) + integration tests + curl probe script - New contract: contracts/api/tile-latlon.md v1.0.0 Shared hygiene - Promote AssertErrorsContainsMention from per-test-file private helpers to ProblemDetailsAssertions (closes batch-1 Low-severity DRY warning) - Sync Swagger param descriptions, README, blackbox/security/perf scripts, uuidv5 doc with the new lat/lon/zoom query-param names Docs - system-flows.md F1/F2 reference the new contracts + validation layers - modules/api_program.md adds Api/Validators + Api/DTOs sections - _autodev_state.md: batch 2 of 4 complete; next batch = AZ-809 All smoke tests green (mode=smoke, exit 0). AZ-808 + AZ-811 transitioned to In Testing on Jira. Co-authored-by: Cursor <cursoragent@cursor.com>
40 lines
1.4 KiB
C#
40 lines
1.4 KiB
C#
using System.Text.Json.Serialization;
|
|
|
|
namespace SatelliteProvider.Common.DTO;
|
|
|
|
// AZ-812 (cycle 8): wire-format renamed Latitude/Longitude → Lat/Lon (OSM
|
|
// convention) and added [JsonPropertyName("lat"/"lon")] so the wire is
|
|
// unambiguous under JsonSerializerOptions.UnmappedMemberHandling.Disallow
|
|
// (AZ-795 cycle 7).
|
|
//
|
|
// AZ-808 (cycle 8): switched [Required] → [JsonRequired] on every property.
|
|
// [Required] is DataAnnotations and is NOT enforced by System.Text.Json — the
|
|
// 2026-05-22 black-box probe confirmed it: omitting `id` returned HTTP 200
|
|
// with id=Guid.Empty (silent coercion). [JsonRequired] is enforced by the
|
|
// STJ deserializer and fails with BadHttpRequestException(JsonException),
|
|
// which the GlobalExceptionHandler converts to RFC 7807 ValidationProblemDetails.
|
|
// Removed the in-property defaults (= 18 for ZoomLevel, = false for StitchTiles)
|
|
// because [JsonRequired] forces the caller to declare intent.
|
|
public record RequestRegionRequest
|
|
{
|
|
[JsonRequired]
|
|
public Guid Id { get; set; }
|
|
|
|
[JsonRequired]
|
|
[JsonPropertyName("lat")]
|
|
public double Lat { get; set; }
|
|
|
|
[JsonRequired]
|
|
[JsonPropertyName("lon")]
|
|
public double Lon { get; set; }
|
|
|
|
[JsonRequired]
|
|
public double SizeMeters { get; set; }
|
|
|
|
[JsonRequired]
|
|
public int ZoomLevel { get; set; }
|
|
|
|
[JsonRequired]
|
|
public bool StitchTiles { get; set; }
|
|
}
|