mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 21:31:14 +00:00
34ee1e0b83
AZ-808: FluentValidation for POST /api/satellite/request - RegionRequestValidator: id non-empty, lat/lon/sizeMeters/zoomLevel ranges - RequestRegionRequest: [JsonRequired] on every property, no implicit defaults - Wired via .WithValidation<RequestRegionRequest>() in MapPost chain - Unit + integration tests + curl probe script - New contract: contracts/api/region-request.md v1.0.0 AZ-811: FluentValidation + envelope filter for GET /api/satellite/tiles/latlon - GetTileByLatLonQuery: nullable record (double?/int?) so the minimal-API binder never short-circuits with BadHttpRequestException before filters - GetTileByLatLonQueryValidator: Cascade(Stop) + NotNull + InclusiveBetween per param; missing surfaces as `\`<name>\` is required.` - RejectUnknownQueryParamsEndpointFilter: reusable IEndpointFilter that rejects any query key outside the allowed set with errors[<key>] map; catches legacy `?Latitude=` typos and hostile probes (`?debug=1&admin=1`) - Handler: [AsParameters] GetTileByLatLonQuery + .Value deref post-validator - Unit (validator + filter) + integration tests + curl probe script - New contract: contracts/api/tile-latlon.md v1.0.0 Shared hygiene - Promote AssertErrorsContainsMention from per-test-file private helpers to ProblemDetailsAssertions (closes batch-1 Low-severity DRY warning) - Sync Swagger param descriptions, README, blackbox/security/perf scripts, uuidv5 doc with the new lat/lon/zoom query-param names Docs - system-flows.md F1/F2 reference the new contracts + validation layers - modules/api_program.md adds Api/Validators + Api/DTOs sections - _autodev_state.md: batch 2 of 4 complete; next batch = AZ-809 All smoke tests green (mode=smoke, exit 0). AZ-808 + AZ-811 transitioned to In Testing on Jira. Co-authored-by: Cursor <cursoragent@cursor.com>
193 lines
4.9 KiB
C#
193 lines
4.9 KiB
C#
using FluentValidation.TestHelper;
|
|
using SatelliteProvider.Api.Validators;
|
|
using SatelliteProvider.Common.DTO;
|
|
|
|
namespace SatelliteProvider.Tests.Validators;
|
|
|
|
// AZ-808: unit tests for RegionRequestValidator. Each RuleFor in the validator
|
|
// has at least one passing case + one failing case. Required-field detection
|
|
// (id / lat / lon / sizeMeters / zoomLevel / stitchTiles) is not unit-tested
|
|
// here because it lives at the deserializer layer (JsonRequired), not the
|
|
// validator — covered by the integration tests (RegionRequestValidationTests).
|
|
public class RegionRequestValidatorTests
|
|
{
|
|
private readonly RegionRequestValidator _validator;
|
|
|
|
public RegionRequestValidatorTests()
|
|
{
|
|
GlobalValidatorConfig.ApplyOnce();
|
|
_validator = new RegionRequestValidator();
|
|
}
|
|
|
|
private static RequestRegionRequest ValidRequest() => new()
|
|
{
|
|
Id = Guid.NewGuid(),
|
|
Lat = 47.461747,
|
|
Lon = 37.647063,
|
|
SizeMeters = 200.0,
|
|
ZoomLevel = 18,
|
|
StitchTiles = false,
|
|
};
|
|
|
|
[Fact]
|
|
public void Validate_AllValid_Passes()
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest();
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveAnyValidationErrors();
|
|
}
|
|
|
|
[Fact]
|
|
public void Validate_IdEmpty_FailsNotEmptyRule()
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { Id = Guid.Empty };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("id")
|
|
.WithErrorMessage("`id` must be a non-zero GUID (the caller's idempotency key).");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-90.001)]
|
|
[InlineData(90.001)]
|
|
[InlineData(180.0)]
|
|
[InlineData(-181.0)]
|
|
public void Validate_LatOutOfRange_FailsRangeRule(double lat)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { Lat = lat };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("lat");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-90.0)]
|
|
[InlineData(0.0)]
|
|
[InlineData(47.461747)]
|
|
[InlineData(90.0)]
|
|
public void Validate_LatAtOrInsideBounds_Passes(double lat)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { Lat = lat };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("lat");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-180.001)]
|
|
[InlineData(180.001)]
|
|
[InlineData(360.0)]
|
|
public void Validate_LonOutOfRange_FailsRangeRule(double lon)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { Lon = lon };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("lon");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-180.0)]
|
|
[InlineData(0.0)]
|
|
[InlineData(37.647063)]
|
|
[InlineData(180.0)]
|
|
public void Validate_LonAtOrInsideBounds_Passes(double lon)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { Lon = lon };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("lon");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(99.999)]
|
|
[InlineData(0.0)]
|
|
[InlineData(10000.001)]
|
|
[InlineData(100000.0)]
|
|
[InlineData(-1.0)]
|
|
public void Validate_SizeMetersOutOfRange_FailsRangeRule(double sizeMeters)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { SizeMeters = sizeMeters };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("sizeMeters");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(100.0)]
|
|
[InlineData(200.0)]
|
|
[InlineData(5000.0)]
|
|
[InlineData(10000.0)]
|
|
public void Validate_SizeMetersAtOrInsideBounds_Passes(double sizeMeters)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { SizeMeters = sizeMeters };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("sizeMeters");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(-1)]
|
|
[InlineData(23)]
|
|
[InlineData(100)]
|
|
public void Validate_ZoomLevelOutOfRange_FailsRangeRule(int zoomLevel)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { ZoomLevel = zoomLevel };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldHaveValidationErrorFor("zoomLevel");
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0)]
|
|
[InlineData(18)]
|
|
[InlineData(22)]
|
|
public void Validate_ZoomLevelAtOrInsideBounds_Passes(int zoomLevel)
|
|
{
|
|
// Arrange
|
|
var request = ValidRequest() with { ZoomLevel = zoomLevel };
|
|
|
|
// Act
|
|
var result = _validator.TestValidate(request);
|
|
|
|
// Assert
|
|
result.ShouldNotHaveValidationErrorFor("zoomLevel");
|
|
}
|
|
}
|