mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 10:11:13 +00:00
Oleksandr Bezdieniezhnykh
745f4840e6
AZ-493 (2 SP): replace the cycle-2 wallclock-seeded _coordinateCounter workaround with a proper Postgres state-reset hook that runs at integration test runner startup, eliminating the per-source-unique-index collision risk that the persistent docker-compose Postgres volume introduced post-AZ-484. The reset is split into two surfaces: * SatelliteProvider.TestSupport.IntegrationTestResetGuard - pure static class, I/O-free, unit-tested. Two independent guards: (a) ASPNETCORE_ENVIRONMENT must equal "Testing", (b) DB_CONNECTION_STRING Host must be in the allowed-host list (postgres, localhost, 127.0.0.1). Failure of either guard surfaces a structured operator-friendly InvalidOperationException. * SatelliteProvider.IntegrationTests.IntegrationTestDatabaseReset - instance class owning the Npgsql side effects. Calls the guard then runs TRUNCATE TABLE route_regions, route_points, routes, regions, tiles RESTART IDENTITY CASCADE inside a single Npgsql transaction. Spec-vs-reality: the task spec prescribed "DB name contains _test" as Guard 2; the actual compose file uses Database=satelliteprovider and DB rename is gated on user confirmation per coderule.mdc. Substituted a Host allowlist as the equivalent guard (intent identical: reject remote / production hosts). Recorded as Low/Spec-Gap in the review. Program.cs adds --keep-state CLI flag and INTEGRATION_KEEP_STATE env var (1/true) opt-outs so a developer can inspect leftover state when debugging. Startup banner shows which path executed. docker-compose.tests.yml gets ASPNETCORE_ENVIRONMENT=Testing + passthrough for INTEGRATION_KEEP_STATE. scripts/run-tests.sh wires the --keep-state flag through to compose. UavUploadTests._coordinateCounter wallclock seed is retained as defense-in-depth (per the task spec's implementer choice). The reset is the primary isolation path; the seed is the belt-and-suspenders fallback for --keep-state runs. 8 new unit tests in SatelliteProvider.Tests/TestSupport/ IntegrationTestResetGuardTests.cs cover Production/Staging/missing-env throw, allowed-host case-insensitivity, disallowed-host rejection with representative prod hostnames, and the AllowedHosts contract. tests_integration.md gains a Reliability section that documents the hook, the two guards, the truncate order, and the three opt-out forms. module-layout.md TestSupport entry extended with the new pure guard and the explicit "Npgsql stays in IntegrationTests" boundary. Test-suite gate (AC-6) deferred to Step 16 Final Test Run per implement skill convention. Per-batch review verdict: PASS_WITH_WARNINGS with 1 Low (spec-vs-reality on Guard 2, non-blocking). Co-authored-by: Cursor <cursoragent@cursor.com>
37 lines
917 B
YAML
37 lines
917 B
YAML
services:
|
|
postgres:
|
|
extends:
|
|
file: docker-compose.yml
|
|
service: postgres
|
|
|
|
api:
|
|
extends:
|
|
file: docker-compose.yml
|
|
service: api
|
|
|
|
integration-tests:
|
|
build:
|
|
context: .
|
|
dockerfile: SatelliteProvider.IntegrationTests/Dockerfile
|
|
container_name: satellite-provider-integration-tests
|
|
environment:
|
|
- API_URL=http://api:8080
|
|
- INTEGRATION_TESTS_MODE=${INTEGRATION_TESTS_MODE:-full}
|
|
- INTEGRATION_KEEP_STATE=${INTEGRATION_KEEP_STATE:-}
|
|
- ASPNETCORE_ENVIRONMENT=Testing
|
|
- DB_CONNECTION_STRING=Host=postgres;Port=5432;Database=satelliteprovider;Username=postgres;Password=postgres
|
|
- JWT_SECRET=${JWT_SECRET}
|
|
volumes:
|
|
- ./ready:/app/ready
|
|
- ./tiles:/app/tiles
|
|
depends_on:
|
|
api:
|
|
condition: service_started
|
|
postgres:
|
|
condition: service_healthy
|
|
restart: "no"
|
|
|
|
volumes:
|
|
postgres_data:
|
|
|