mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 23:01:14 +00:00
865dfdb3b9
AZ-794: rename inventory wire fields tileZoom/tileX/tileY -> z/x/y to match the slippy-map URL convention. Contract bumped to v2.0.0. AZ-795: shared validation infrastructure -- FluentValidation + ValidationEndpointFilter + GlobalValidatorConfig (camelCase paths). GlobalExceptionHandler now converts JsonException (UnmappedMember + JsonRequired) into RFC 7807 ValidationProblemDetails. JSON layer hardened with UnmappedMemberHandling.Disallow + camelCase naming policy. New error-shape.md contract. AZ-796: InventoryRequestValidator covers 9 rules (XOR tiles vs locationHashes, cap 1000, z 0..22, x/y in slippy bounds, hash length/charset). 16 unit tests + 16 integration tests + a manual curl probe script. Adjacent fixes uncovered by the new strict layer: - IdempotentPostTests RoutePoint payload corrected to lat/lon (the DTO has used JsonPropertyName for ages; previously silently ignored under PascalCase fallback). - TileInventoryTests slippy x/y reduced to fit z=18 bounds. - docker-compose.yml host port for Postgres moved 5432 -> 5433 to avoid sibling-project conflict; appsettings.Development + README + AGENTS + architecture + containerization docs aligned. New coderule (suite + repo): API consumer-facing OpenAPI descriptions must not contain task IDs, contract filenames, or version-bump history -- internal change tracking belongs in commits/contract docs/changelogs. Existing offending descriptions in Program.cs cleaned up. Co-authored-by: Cursor <cursoragent@cursor.com>
103 lines
4.2 KiB
C#
103 lines
4.2 KiB
C#
using System.Text.Json;
|
|
|
|
namespace SatelliteProvider.IntegrationTests;
|
|
|
|
// AZ-795: shared ProblemDetails / ValidationProblemDetails assertion helper
|
|
// for integration tests. Every endpoint that emits a 4xx error MUST produce
|
|
// a body matching the contract in
|
|
// `_docs/02_document/contracts/api/error-shape.md` (v1.0.0). Tests use this
|
|
// helper instead of re-deriving the shape per call site.
|
|
public static class ProblemDetailsAssertions
|
|
{
|
|
private static readonly JsonSerializerOptions JsonOptions = new()
|
|
{
|
|
PropertyNamingPolicy = JsonNamingPolicy.CamelCase,
|
|
PropertyNameCaseInsensitive = true
|
|
};
|
|
|
|
public static async Task<JsonElement> ReadProblemDetailsAsync(HttpResponseMessage response, string label)
|
|
{
|
|
var contentType = response.Content.Headers.ContentType?.MediaType;
|
|
if (contentType is null || !contentType.Contains("application/problem+json", StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
var body = await response.Content.ReadAsStringAsync();
|
|
throw new Exception(
|
|
$"{label}: expected Content-Type 'application/problem+json', got '{contentType}'. Body: {body}");
|
|
}
|
|
|
|
var stream = await response.Content.ReadAsStreamAsync();
|
|
using var doc = await JsonDocument.ParseAsync(stream);
|
|
return doc.RootElement.Clone();
|
|
}
|
|
|
|
public static void AssertValidationProblem(
|
|
JsonElement problem,
|
|
int expectedStatus,
|
|
string label,
|
|
string? expectedErrorPath = null,
|
|
string? expectedErrorContains = null)
|
|
{
|
|
if (!problem.TryGetProperty("status", out var statusEl) || statusEl.GetInt32() != expectedStatus)
|
|
{
|
|
throw new Exception(
|
|
$"{label}: expected status={expectedStatus}, got {(statusEl.ValueKind == JsonValueKind.Number ? statusEl.GetInt32().ToString() : "missing")}");
|
|
}
|
|
|
|
if (!problem.TryGetProperty("title", out var titleEl) || string.IsNullOrEmpty(titleEl.GetString()))
|
|
{
|
|
throw new Exception($"{label}: expected non-empty 'title', got missing/empty.");
|
|
}
|
|
|
|
if (!problem.TryGetProperty("errors", out var errorsEl) || errorsEl.ValueKind != JsonValueKind.Object)
|
|
{
|
|
throw new Exception($"{label}: expected 'errors' object, got {errorsEl.ValueKind}.");
|
|
}
|
|
|
|
if (expectedErrorPath is not null)
|
|
{
|
|
if (!errorsEl.TryGetProperty(expectedErrorPath, out var fieldEl) || fieldEl.ValueKind != JsonValueKind.Array)
|
|
{
|
|
throw new Exception(
|
|
$"{label}: expected errors['{expectedErrorPath}'] array, got {(errorsEl.TryGetProperty(expectedErrorPath, out var raw) ? raw.ValueKind.ToString() : "missing")}. " +
|
|
$"Available paths: {string.Join(", ", EnumeratePaths(errorsEl))}.");
|
|
}
|
|
|
|
if (expectedErrorContains is not null)
|
|
{
|
|
var first = fieldEl.EnumerateArray().FirstOrDefault();
|
|
var firstStr = first.ValueKind == JsonValueKind.String ? first.GetString() : null;
|
|
if (firstStr is null || !firstStr.Contains(expectedErrorContains, StringComparison.OrdinalIgnoreCase))
|
|
{
|
|
throw new Exception(
|
|
$"{label}: expected errors['{expectedErrorPath}'][0] to contain '{expectedErrorContains}', got '{firstStr}'.");
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public static void AssertProblemDetails(
|
|
JsonElement problem,
|
|
int expectedStatus,
|
|
string label)
|
|
{
|
|
if (!problem.TryGetProperty("status", out var statusEl) || statusEl.GetInt32() != expectedStatus)
|
|
{
|
|
throw new Exception(
|
|
$"{label}: expected status={expectedStatus}, got {(statusEl.ValueKind == JsonValueKind.Number ? statusEl.GetInt32().ToString() : "missing")}");
|
|
}
|
|
|
|
if (!problem.TryGetProperty("title", out var titleEl) || string.IsNullOrEmpty(titleEl.GetString()))
|
|
{
|
|
throw new Exception($"{label}: expected non-empty 'title', got missing/empty.");
|
|
}
|
|
}
|
|
|
|
private static IEnumerable<string> EnumeratePaths(JsonElement errorsEl)
|
|
{
|
|
foreach (var prop in errorsEl.EnumerateObject())
|
|
{
|
|
yield return prop.Name;
|
|
}
|
|
}
|
|
}
|