mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 16:11:14 +00:00
5e056b2334
Third concrete child of AZ-795 (cycle 8 batch 3). FluentValidation +
[JsonRequired] + UnmappedMemberHandling.Disallow combine to reject every
malformed payload at the API boundary with RFC 7807 ValidationProblemDetails.
Validators (SatelliteProvider.Api/Validators/, all new)
- CreateRouteRequestValidator: id non-empty, name/description length,
regionSizeMeters/zoomLevel ranges, points count [2, 500], cross-field
createTilesZip => requestMaps. Chains RoutePointValidator (per-point)
and GeofencePolygonValidator (per-polygon, guarded by When(Geofences != null)).
OverridePropertyName("geofences.polygons") on the geofences chain so
FluentValidation's default leaf-only key policy doesn't drop the parent
path on deep expressions like req.Geofences!.Polygons.
- RoutePointValidator: lat/lon ranges; OverridePropertyName("lat"/"lon")
chained AFTER InclusiveBetween (the extension is defined on
IRuleBuilderOptions<T, TProperty>, so the generic type is only
inferable after the first concrete rule) so error keys match the
wire format (`points[i].lat`) rather than the C# property name
(`points[i].latitude`).
- GeofencePolygonValidator: per-corner range checks via private nested
GeoCornerValidator; cross-field NW.Lat > SE.Lat and NW.Lon < SE.Lon
invariants emit at errors["geofences.polygons[i].northWest"].
DTOs (SatelliteProvider.Common/DTO/, [JsonRequired] additions only)
- CreateRouteRequest: id, name, regionSizeMeters, zoomLevel, points,
requestMaps, createTilesZip
- RoutePoint: Latitude, Longitude
- GeofencePolygon: NorthWest, SouthEast; Geofences: Polygons
- GeoPoint: Lat, Lon
Tests
- Unit: 26 methods total — 16 in CreateRouteRequestValidatorTests, 6 in
GeofencePolygonValidatorTests, 4 in RoutePointValidatorTests. Each
RuleFor/RuleForEach chain has at least one positive + one negative case.
- Integration: CreateRouteValidationTests.cs — 16 methods (happy + 15
failure modes) wired into smoke + full suites. Covers empty body,
missing/zero id, empty name, out-of-range regionSizeMeters/zoomLevel,
points count < 2, per-point lat/lon out-of-range, geofence invariants,
missing requestMaps, cross-field createTilesZip, unknown root field,
nested type mismatch.
- Manual probe: scripts/probe_route_validation.sh curl-exercises every
failure mode end-to-end + happy path.
Docs
- New contract _docs/02_document/contracts/api/route-creation.md v1.0.0
with nested DTO chain, invariants, per-field test cases table, and
advisories on the legacy service-layer RouteValidator + the
input/output RoutePoint vs RoutePointDto naming asymmetry.
- system-flows.md F4 sequence diagram extended with the validation-filter
branch; preconditions + error scenarios reference the new contract.
- modules/api_program.md: CreateRoute handler section added; Api/Validators
bumped to AZ-808/AZ-809/AZ-811.
- modules/common_dtos.md: DTO descriptions updated with [JsonRequired]
annotations and constraint summaries.
- tests/blackbox-tests.md BT-06/BT-N03/BT-N04/BT-N05 align with the new
wire format and named error keys.
- tests/security-tests.md SEC-04 references GlobalExceptionHandler's
JsonException branch + AZ-353 correlationId.
- _docs/03_implementation/batch_03_cycle8_report.md + reviews/batch_03_cycle8_review.md
(PASS_WITH_NOTES — F1 Low: OverridePropertyName documented inline,
F2 + F3 Info: pre-existing advisories for follow-up).
Smoke green (mode=smoke, exit 0). AZ-809 transitioned to In Testing on Jira.
Task file moved to _docs/02_tasks/done/.
Co-authored-by: Cursor <cursoragent@cursor.com>
195 lines
5.1 KiB
Bash
Executable File
195 lines
5.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
# Manual end-to-end probe for POST /api/satellite/route strict validation
|
|
# (AZ-809). Each failure call should return HTTP 400 with an
|
|
# `application/problem+json` body. The happy path should return HTTP 200.
|
|
#
|
|
# Two enforcement layers:
|
|
# 1. UnmappedMemberHandling.Disallow + [JsonRequired] — deserializer rejects
|
|
# missing-required and unknown fields with errors via GlobalExceptionHandler.
|
|
# 2. WithValidation<CreateRouteRequest> — runs CreateRouteRequestValidator +
|
|
# RoutePointValidator + GeofencePolygonValidator (range, count, cross-field).
|
|
#
|
|
# Usage:
|
|
# API_URL=https://localhost:8080 JWT="<bearer-token>" ./scripts/probe_route_validation.sh
|
|
|
|
API_URL="${API_URL:-https://localhost:8080}"
|
|
JWT="${JWT:-}"
|
|
ENDPOINT="${API_URL%/}/api/satellite/route"
|
|
|
|
if [[ -z "${JWT}" ]]; then
|
|
echo "ERROR: set JWT env var to a bearer token. Mint one via:"
|
|
echo " dotnet run --project SatelliteProvider.IntegrationTests -- --mint-only"
|
|
exit 2
|
|
fi
|
|
|
|
curl_args=(-sS -k -H "Authorization: Bearer ${JWT}" -H "Content-Type: application/json")
|
|
|
|
probe() {
|
|
local label="$1"
|
|
local body="$2"
|
|
local expected_status="$3"
|
|
|
|
echo "----- ${label} (expecting HTTP ${expected_status}) -----"
|
|
local response
|
|
response=$(curl "${curl_args[@]}" -X POST -d "${body}" "${ENDPOINT}" -w "\nHTTP_STATUS=%{http_code}\n")
|
|
echo "${response}"
|
|
local actual_status
|
|
actual_status=$(echo "${response}" | tail -n 1 | sed 's/HTTP_STATUS=//')
|
|
if [[ "${actual_status}" != "${expected_status}" ]]; then
|
|
echo "FAIL: expected HTTP ${expected_status}, got ${actual_status}"
|
|
return 1
|
|
fi
|
|
echo "OK: HTTP ${expected_status}"
|
|
echo
|
|
}
|
|
|
|
route_id=$(uuidgen | tr '[:upper:]' '[:lower:]')
|
|
|
|
probe "happy-path-no-maps" '{
|
|
"id": "'"${route_id}"'",
|
|
"name": "probe-route-1",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 200
|
|
|
|
# Rule 2: missing id (probe-confirmed gap)
|
|
probe "missing-id" '{
|
|
"name": "probe-missing-id",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 2: zero-Guid id
|
|
probe "zero-guid-id" '{
|
|
"id": "00000000-0000-0000-0000-000000000000",
|
|
"name": "probe-zero-id",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 3: empty name
|
|
probe "empty-name" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 7: points too few (1)
|
|
probe "points-too-few" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-1-point",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 8: nested point lat out of range
|
|
probe "point-lat-out-of-range" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-point-lat",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 91.0, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 9: geofence NW not north-of SE (cross-field invariant)
|
|
probe "geofence-nw-not-north" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-geofence-inverted",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"geofences": {
|
|
"polygons": [
|
|
{ "northWest": { "lat": 50.05, "lon": 36.05 },
|
|
"southEast": { "lat": 50.05, "lon": 36.15 } }
|
|
]
|
|
},
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
# Rule 12: cross-field createTilesZip without requestMaps
|
|
probe "createTilesZip-without-requestMaps" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-cross-field",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": true
|
|
}' 400
|
|
|
|
# Rule 13: unknown root field
|
|
probe "unknown-root-field" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-unknown",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": 50.10, "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false,
|
|
"debug": "fingerprint-probe"
|
|
}' 400
|
|
|
|
# Rule 14: nested type mismatch
|
|
probe "point-lat-type-mismatch" '{
|
|
"id": "'$(uuidgen | tr '[:upper:]' '[:lower:]')'",
|
|
"name": "probe-type-mismatch",
|
|
"regionSizeMeters": 1000,
|
|
"zoomLevel": 18,
|
|
"points": [
|
|
{ "lat": "fifty", "lon": 36.10 },
|
|
{ "lat": 50.11, "lon": 36.11 }
|
|
],
|
|
"requestMaps": false,
|
|
"createTilesZip": false
|
|
}' 400
|
|
|
|
echo "All probes passed."
|