mirror of
https://github.com/azaion/satellite-provider.git
synced 2026-06-21 08:21:14 +00:00
c396740644
AZ-491 (3 SP): eliminate the cycle-2 duplicate of JWT-minting logic that existed in both SatelliteProvider.Tests/TestUtilities/ JwtTokenFactory.cs (unit-side) and SatelliteProvider.IntegrationTests/ JwtTestHelpers.cs (integration-side), where the same Expires < NotBefore bug needed parallel fixes in commitsf64d0d7+11b7074. Option A chosen: new SatelliteProvider.TestSupport class library (no test framework) holds the canonical JwtTokenFactory.Create / CreateExpired / TamperSignature. Both Tests and IntegrationTests consume it via ProjectReference; production projects (Api, Common, DataAccess, Services.*) cannot depend on it. The notBefore-shift workaround is preserved with an inline regression-prevention comment back-referencing the cycle-2 fix commits. SatelliteProvider.IntegrationTests/JwtTestHelpers.cs is stripped to runner-only concerns: ResolveSecretOrThrow, AttachDefaultAuthorization, and the DefaultSubject = "integration-tests" constant. Call sites in Program.cs, JwtIntegrationTests.cs, and UavUploadTests.cs (10 sites) switched to JwtTokenFactory.* with JwtTestHelpers.DefaultSubject explicitly passed for the runner subject - behavior parity preserved. Dockerfile for IntegrationTests gets the new TestSupport csproj in its pre-restore COPY layer. Api Dockerfile unchanged (TestSupport is NOT a production dependency). A new code-review SKILL.md Phase 6 checklist row flags near-identical helper logic across test projects as a Medium / Maintainability finding with explicit cycle-2 retro back-reference, so this whole pattern stops at one occurrence. module-layout.md adds a TestSupport Shared/Cross-Cutting entry documenting the production-isolation invariant. tests_unit.md + tests_integration.md updated to describe the consolidated layout. sln updated. Test-suite gate (AC-2 + AC-3) deferred to Step 16 Final Test Run per implement-skill convention. Per-batch review verdict: PASS_WITH_WARNINGS with 1 Low (pre-existing 7.0.3 version pin preserved verbatim from cycle-2 IntegrationTests csproj for parity; not blocking; deferred bump). Co-authored-by: Cursor <cursoragent@cursor.com>
3.5 KiB
3.5 KiB
Module: Tests/SatelliteProvider.IntegrationTests
Purpose
Console application that runs end-to-end integration tests against a live API instance. Designed to run in Docker alongside the API and PostgreSQL containers.
Public Interface
Test Classes
TileTests— tile download via lat/lon endpointRegionTests— region request → polling → completion flowBasicRouteTests— route creation with intermediate pointsComplexRouteTests— routes with geofencingExtendedRouteTests— routes withrequestMaps: trueand tile ZIP creationMigrationTests— direct PostgreSQL schema/index validation (no HTTP). AZ-484 cycle added:NewUniqueConstraintIncludesSourceColumn_AZ484_AC1,BackfillUpdateAssignsGoogleMapsAndCapturedAt_AZ484_AC4,MultiSourceInsertCoexistsUnderNewIndex_AZ484_AC1,MostRecentAcrossSourcesSelection_AZ484_AC2,SameSourceUpsertReplacesPreviousRow_AZ484_AC3(latter four use temp tables to keep production data untouched).JwtIntegrationTests(added by AZ-487, cycle 2; helpers consolidated by AZ-491 cycle 3) —AnonymousRequest_To_AnyEndpoint_Returns401,ExpiredToken_Returns401,InvalidSignature_Returns401,ValidToken_Returns200_OnHealthyEndpoint,SwaggerDocument_AdvertisesBearerSecurityScheme. HS256 token minting lives in the sharedSatelliteProvider.TestSupport.JwtTokenFactory(consumed viaProjectReference); runner-specific concerns (JwtTestHelpers.ResolveSecretOrThrow,AttachDefaultAuthorization,DefaultSubject = "integration-tests") remain in this project. The test runner setsJWT_SECRETon the API container and attaches a Bearer token to every existing test's HTTP requests so the pre-cycle-2 suite continues to pass.UavUploadTests(added by AZ-488, cycle 2) —HappyPathSingleItem_PersistsRow,MixedBatch_ReturnsPerItemResults,MultiSourceCoexistence_AZ484_Cycle2,SameSourceUpsert_AZ484_Cycle2,NoToken_Returns401,ValidTokenWithoutGpsPermission_Returns403,OversizedBatch_Returns400. Uses a wall-clock-seeded coordinate counter (_coordinateCounterinitialized fromDateTime.UtcNow) so each docker-compose run picks a fresh coordinate band — the postgres named volume persists across runs and a naïveint = 0counter collided with prior runs on the per-source unique index (fixed mid-Step-11).StubAndErrorContractTests(existing) — updated in cycle 2 to drop the legacyStubUpload_Returns501expectation since AZ-488 implemented the endpoint.
Supporting Classes
Models.cs— HTTP response DTOs for deserializationRouteTestHelpers.cs— shared utilities (wait-for-completion polling, geofence polygon builders, test data)Program.cs— test runner entry point
Internal Logic
- Makes HTTP calls to the API at
API_URLenvironment variable (default:http://api:8080) - Tests are methods called sequentially from
Program.cs(not xUnit — plain console app) - Poll-based waiting for async operations (region/route completion)
- Validates response structure, status transitions, file creation
Dependencies
- No project references (standalone console app)
- Communicates with the API exclusively via HTTP
- NuGet: implicit .NET 8 runtime
Consumers
docker-compose.tests.yml— runs as a container that depends on the API service
Configuration
API_URLenvironment variable (set in docker-compose.tests.yml tohttp://api:8080)
External Integrations
- HTTP to the SatelliteProvider API
- Reads output files from mounted
./ready/and./tiles/volumes
Security
None.
Tests
This IS the integration test suite.