Files
satellite-provider/SatelliteProvider.Tests/TestSupport/IntegrationTestResetGuardTests.cs
T
Oleksandr Bezdieniezhnykh 745f4840e6
ci/woodpecker/push/01-test Pipeline was successful
ci/woodpecker/push/02-build-push Pipeline was successful
[AZ-493] Cycle 3 batch 3: integration test DB-reset hook
AZ-493 (2 SP): replace the cycle-2 wallclock-seeded _coordinateCounter
workaround with a proper Postgres state-reset hook that runs at
integration test runner startup, eliminating the per-source-unique-index
collision risk that the persistent docker-compose Postgres volume
introduced post-AZ-484.

The reset is split into two surfaces:

* SatelliteProvider.TestSupport.IntegrationTestResetGuard - pure
  static class, I/O-free, unit-tested. Two independent guards: (a)
  ASPNETCORE_ENVIRONMENT must equal "Testing", (b) DB_CONNECTION_STRING
  Host must be in the allowed-host list (postgres, localhost, 127.0.0.1).
  Failure of either guard surfaces a structured operator-friendly
  InvalidOperationException.
* SatelliteProvider.IntegrationTests.IntegrationTestDatabaseReset -
  instance class owning the Npgsql side effects. Calls the guard then
  runs TRUNCATE TABLE route_regions, route_points, routes, regions,
  tiles RESTART IDENTITY CASCADE inside a single Npgsql transaction.

Spec-vs-reality: the task spec prescribed "DB name contains _test" as
Guard 2; the actual compose file uses Database=satelliteprovider and
DB rename is gated on user confirmation per coderule.mdc. Substituted
a Host allowlist as the equivalent guard (intent identical: reject
remote / production hosts). Recorded as Low/Spec-Gap in the review.

Program.cs adds --keep-state CLI flag and INTEGRATION_KEEP_STATE env
var (1/true) opt-outs so a developer can inspect leftover state when
debugging. Startup banner shows which path executed.
docker-compose.tests.yml gets ASPNETCORE_ENVIRONMENT=Testing +
passthrough for INTEGRATION_KEEP_STATE. scripts/run-tests.sh wires the
--keep-state flag through to compose.

UavUploadTests._coordinateCounter wallclock seed is retained as
defense-in-depth (per the task spec's implementer choice). The reset
is the primary isolation path; the seed is the belt-and-suspenders
fallback for --keep-state runs.

8 new unit tests in SatelliteProvider.Tests/TestSupport/
IntegrationTestResetGuardTests.cs cover Production/Staging/missing-env
throw, allowed-host case-insensitivity, disallowed-host rejection
with representative prod hostnames, and the AllowedHosts contract.

tests_integration.md gains a Reliability section that documents the
hook, the two guards, the truncate order, and the three opt-out forms.
module-layout.md TestSupport entry extended with the new pure guard
and the explicit "Npgsql stays in IntegrationTests" boundary.

Test-suite gate (AC-6) deferred to Step 16 Final Test Run per implement
skill convention. Per-batch review verdict: PASS_WITH_WARNINGS with 1
Low (spec-vs-reality on Guard 2, non-blocking).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-12 01:38:42 +03:00

98 lines
2.9 KiB
C#

using FluentAssertions;
using SatelliteProvider.TestSupport;
namespace SatelliteProvider.Tests.TestSupport;
public class IntegrationTestResetGuardTests
{
[Fact]
public void EnsureGuardPassesOrThrow_ProductionEnvironment_Throws()
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Production", "postgres");
// Assert
act.Should().Throw<InvalidOperationException>()
.WithMessage("*ASPNETCORE_ENVIRONMENT*Production*expected*Testing*");
}
[Fact]
public void EnsureGuardPassesOrThrow_StagingEnvironment_Throws()
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Staging", "postgres");
// Assert
act.Should().Throw<InvalidOperationException>()
.WithMessage("*Staging*expected*Testing*");
}
[Fact]
public void EnsureGuardPassesOrThrow_MissingEnvironment_Throws()
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow(null, "postgres");
// Assert
act.Should().Throw<InvalidOperationException>()
.WithMessage("*not set*expected*Testing*");
}
[Fact]
public void EnsureGuardPassesOrThrow_TestingEnvironment_AllowedHost_DoesNotThrow()
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Testing", "postgres");
// Assert
act.Should().NotThrow();
}
[Theory]
[InlineData("postgres")]
[InlineData("Postgres")]
[InlineData("POSTGRES")]
[InlineData("localhost")]
[InlineData("127.0.0.1")]
public void EnsureGuardPassesOrThrow_TestingEnvironment_AcceptsAllowedHosts(string host)
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Testing", host);
// Assert
act.Should().NotThrow();
}
[Theory]
[InlineData("prod.example.com")]
[InlineData("rds.amazonaws.com")]
[InlineData("db.staging.internal")]
public void EnsureGuardPassesOrThrow_TestingEnvironment_RejectsDisallowedHosts(string host)
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Testing", host);
// Assert
act.Should().Throw<InvalidOperationException>()
.WithMessage($"*Host '{host}' is not in the allowed-host list*");
}
[Fact]
public void EnsureGuardPassesOrThrow_TestingEnvironment_MissingHost_Throws()
{
// Act
var act = () => IntegrationTestResetGuard.EnsureGuardPassesOrThrow("Testing", null);
// Assert
act.Should().Throw<InvalidOperationException>()
.WithMessage("*connection string has no Host*");
}
[Fact]
public void AllowedHosts_IsImmutableContract()
{
// Assert
IntegrationTestResetGuard.AllowedHosts.Should().BeEquivalentTo(new[] { "postgres", "localhost", "127.0.0.1" });
}
}