Commit Graph

4 Commits

Author SHA1 Message Date
Oleksandr Bezdieniezhnykh e8caa29da6 [AZ-943] [AZ-951] [AZ-952] Pause AZ-943 on OKVIS2 telemetry gap
AZ-943 implementation attempt confirmed the C++ binding cannot satisfy
AC-4 without upstream OKVIS2 patches. The spec's "approach (a)
in-binding subclass workaround" is structurally impossible:
- ThreadedSlam::estimator_ is `private` (not `protected`)
- ViSlamBackend has no public covariance / counts / parallax / MRE
  accessor in the v2 upstream headers
- TrackingState carries only id / isKeyframe / TrackingQuality enum /
  recognisedPlace / isFullGraphOptimising / currentKeyframeId — none
  of the five tracking-stats fields the binding needs

Filed the spec-documented "approach (b)" fallback as two sibling
tickets, both linked Jira-side as `is blocked by` against AZ-943:

- AZ-951 (3 SP): upstream patch — expose 6x6 pose covariance accessor
  (+ ADR-XXX for the AZ-332 Plan-phase pin deviation)
- AZ-952 (3 SP): upstream patch — expose tracking-stats accessor
  (feature counts + parallax + MRE)

AZ-943 transitioned In Progress -> To Do in Jira, full audit comment
attached. Local AZ-943 spec moved todo/ -> backlog/ with PAUSED
preamble; original AC list preserved for the post-unblock turn.

Per user 2026-05-29 confirmation: cycle-4 Derkachi demo target stays
KLT/RANSAC (tests/e2e/replay/conftest.py line 159
c1_vio: strategy: klt_ransac), so AZ-951 + AZ-952 + AZ-943 chain is
correctly deferred. Pivoting next batch to AZ-897 (replay UI form).

Touches: _docs/02_tasks/_dependencies_table.md (preamble + table
rows for AZ-943 paused / AZ-951 / AZ-952 added; totals bumped to
142 product + 41 blackbox-test = 183, 448 product + 133 blackbox
= 581), _docs/_autodev_state.md (sub_step pivot to AZ-897).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-29 11:48:09 +03:00
Oleksandr Bezdieniezhnykh 007aa36fbf [AZ-895] Deprecate replay auto-sync surface; file AZ-908 follow-up
Option A (minimum-deprecation, 2 SP) per user complexity-budget
decision. Auto-sync stays importable as a raising stub for one cycle
so external callers see a clean ReplayInputAdapterError instead of an
ImportError. Full physical removal is filed as AZ-908 (cycle-5+ backlog).

Production:
- auto_sync.py: 700+ LOC -> 56-line no-op stub raising
  "auto-sync removed; supply --imu CSV instead"
- tlog_video_adapter.py: 700+ LOC -> 105-line deprecated stub;
  ReplayInputAdapter.open() raises immediately, close() is a no-op
- _replay_branch.py: dropped legacy auto-sync branch +
  _build_auto_sync_config; _validate_replay_paths now requires
  imu_csv_path; replay_input_adapter_factory parameter removed
- cli/replay.py: --time-offset-ms / --skip-auto-sync / --auto-trim
  emit DeprecationWarning + stderr line; values ignored
- tlog_replay_adapter.py + tlog_ground_truth.py docstrings: AUDIT-ONLY

Tests:
- DELETED test_az405_auto_sync, test_az405_replay_input_adapter,
  test_az698_window_alignment (covered code no longer runs)
- ADDED test_az895_auto_sync_deprecated_stub (5 parametrised, pins AC-1)
- test_az402_replay_cli: deprecation warnings + ignored-value asserts
- test_az401_compose_root_replay: new imu_csv_path-required gate;
  deleted the calibration-loading test that relied on the removed
  replay_input_adapter_factory injection point
- test_derkachi_real_tlog: xfail reason refreshed to AZ-848 + AZ-883
  (AC-4 "AZ-848-scoped reason")

Docs:
- module-layout.md: replay_input file list flags deprecated modules,
  adds csv_ground_truth.py
- _dependencies_table.md: +AZ-908 row, preamble + totals updated
  (179 -> 180 tasks, 567 -> 570 SP)
- AZ-908 backlog spec added; AZ-895 spec moved todo -> done
- batch_03_cycle4_report.md written

Touched-module tests green (111 passed, 1 skipped). Full unit suite
green: 2287 passed, 85 skipped, 1 deselected (pre-existing flaky perf
test, unrelated).

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-26 22:09:59 +03:00
Oleksandr Bezdieniezhnykh 940066bee2 chore: WIP pre-implement
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-26 17:09:13 +03:00
Oleksandr Bezdieniezhnykh 6d51e06886 [AZ-589] [AZ-590] [AZ-591] [AZ-592] [AZ-593] Re-classify cycle1 gate findings
Cycle 1 Product Implementation Completeness Gate post-mortem.
AZ-589 + AZ-590 were the wrong abstraction:

- AZ-589 targeted `okvis::ThreadedKFVio` (OKVIS v1 API) which does
  not exist in the vendored OKVIS2 upstream; smartroboticslab/okvis2
  exposes `okvis::ThreadedSlam` instead.
- AZ-590 assumed a "de-ROSified VINS-Mono pin" submodule exists;
  `cpp/vins_mono/upstream/` has no `.gitmodules` entry.
- The actual production gap is the empty central
  `_STRATEGY_REGISTRY`: `register_strategy(...)` is never called
  outside test fixtures, so `compose_root()` raises
  `StrategyNotLinkedError` for every component slug with a
  strategy-selecting config field. Affects c1_vio + c2_vpr +
  c2_5_rerank + c3_matcher + c3_5_adhop + c4_pose + c5_state.

Re-classification:

- AZ-589 + AZ-590 closed Won't Fix (Jira); spec files removed
  from todo/ but rows retained in the dependencies table as
  audit-trail.
- AZ-591 created (todo/, 5pt) — cross-cutting compose_root
  per-binary bootstrap that populates `_STRATEGY_REGISTRY` for
  the airborne binary. Scheduled as Batch 66 sole task.
- AZ-592 created (backlog/, 5pt placeholder) — AZ-332 Tier-2
  validation bundle (real `okvis::ThreadedSlam` wiring + Linux CI
  apt-install + DBoW2 vocab + Jetson). BLOCKED on Tier-2
  prerequisites; honors AZ-332's `AZ-332_tier2_validation`
  self-deferral handle.
- AZ-593 created (backlog/, 5pt placeholder) — AZ-333 Tier-2
  validation bundle (de-ROSified VINS-Mono upstream + binding +
  CI + Jetson). BLOCKED on upstream vendoring decision plus
  Tier-2 prerequisites; honors AZ-333's parallel deferral pattern.
- AZ-332 + AZ-333 re-classified in cycle1 gate report from FAIL
  to BLOCKED-on-Tier-2.

Step 7 stays in_progress until AZ-591 lands; after that it can
advance to Step 8 with AZ-592 + AZ-593 parked in backlog/.

Co-authored-by: Cursor <cursoragent@cursor.com>
2026-05-16 12:45:58 +03:00